[dpdk-dev] [PATCH] common/qat: support GEN2 device C34xx

[dpdk-dev] [PATCH] common/qat: support GEN2 device C34xx

[Adam Dybkowski]

This adds pci detection and documentation for Intel GEN2
QuickAssist device C34xx (PF Did 0x18ee, VF Did 0x18ef).

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 doc/guides/compressdevs/qat_comp.rst   | 3 ++-
 doc/guides/cryptodevs/qat.rst          | 8 ++++++--
 doc/guides/rel_notes/release_20_08.rst | 5 +++++
 drivers/common/qat/qat_device.c        | 6 +++++-
 4 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/doc/guides/compressdevs/qat_comp.rst b/doc/guides/compressdevs/qat_comp.rst
index 475c4a9f9..93757957a 100644
--- a/doc/guides/compressdevs/qat_comp.rst
+++ b/doc/guides/compressdevs/qat_comp.rst
@@ -1,5 +1,5 @@
 ..  SPDX-License-Identifier: BSD-3-Clause
-    Copyright(c) 2018 Intel Corporation.
+    Copyright(c) 2018-2020 Intel Corporation.
 
 Intel(R) QuickAssist (QAT) Compression Poll Mode Driver
 =======================================================
@@ -9,6 +9,7 @@ support for the following hardware accelerator devices:
 
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
+* ``Intel QuickAssist Technology C34xx``
 * ``Intel QuickAssist Technology DH895x``
 
 
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index c2cc3d5ca..8311abffe 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology DH895xCC``
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
+* ``Intel QuickAssist Technology C34xx``
 * ``Intel QuickAssist Technology D15xx``
 * ``Intel QuickAssist Technology P5xxx``
 
@@ -154,6 +155,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology DH895xCC``
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
+* ``Intel QuickAssist Technology C34xx``
 * ``Intel QuickAssist Technology D15xx``
 * ``Intel QuickAssist Technology P5xxx``
 
@@ -383,6 +385,8 @@ to see the full table)
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | Yes | Yes | "   | "        | 01.org/4.2.0+ | "             | "          | "      | "    | "      | "      |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
+   | Yes | Yes | Yes | 2   | C34xx    | p             | qat_c34xx     | c34xx      | 18ee   | 1    | 18ef   | 16     |
+   +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 2   | D15xx    | p             | qat_d15xx     | d15xx      | 6f54   | 1    | 6f55   | 16     |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 3   | P5xxx    | p             | qat_p5xxx     | p5xxx      | 18a0   | 1    | 18a1   | 128    |
@@ -609,8 +613,8 @@ adjust the unbind command below::
         done; \
     done
 
-For Intel(R) QuickAssist Technology C3xxx or D15xx device
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+For Intel(R) QuickAssist Technology C3xxx or C34xx or D15xx device
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 The unbind command below assumes ``BDFs`` of ``01:01.00-01:02.07``, if your
 VFs are different adjust the unbind command below::
diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
index 39064afbe..29c380532 100644
--- a/doc/guides/rel_notes/release_20_08.rst
+++ b/doc/guides/rel_notes/release_20_08.rst
@@ -56,6 +56,11 @@ New Features
      Also, make sure to start the actual text at the margin.
      =========================================================
 
+* **Added support for GEN2 device C34xx to Intel QAT driver.**
+
+  Added support for Intel GEN2 QuickAssist device C34xx
+  (PF Did 0x18ee, VF Did 0x18ef).
+
 
 Removed Items
 -------------
diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
index 2b41d9a13..b135eb869 100644
--- a/drivers/common/qat/qat_device.c
+++ b/drivers/common/qat/qat_device.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2018 Intel Corporation
+ * Copyright(c) 2018-2020 Intel Corporation
  */
 
 #include <rte_string_fns.h>
@@ -53,6 +53,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
 		{
 			RTE_PCI_DEVICE(0x8086, 0x6f55),
 		},
+		{
+			RTE_PCI_DEVICE(0x8086, 0x18ef),
+		},
 		{
 			RTE_PCI_DEVICE(0x8086, 0x18a1),
 		},
@@ -199,6 +202,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,
 	case 0x37c9:
 	case 0x19e3:
 	case 0x6f55:
+	case 0x18ef:
 		qat_dev->qat_dev_gen = QAT_GEN2;
 		break;
 	case 0x18a1:
-- 
2.25.1

[dpdk-dev] [PATCH v2 0/1] common/qat: support GEN2 QAT device 200xx

[Adam Dybkowski]

This adds pci detection and documentation for Intel GEN2
QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).

--
v2:
* update the marketing name

Adam Dybkowski (1):
  common/qat: support GEN2 QAT device 200xx

 doc/guides/compressdevs/qat_comp.rst   | 3 ++-
 doc/guides/cryptodevs/qat.rst          | 8 ++++++--
 doc/guides/rel_notes/release_20_08.rst | 5 +++++
 drivers/common/qat/qat_device.c        | 6 +++++-
 4 files changed, 18 insertions(+), 4 deletions(-)

-- 
2.25.1

[dpdk-dev] [PATCH v2 1/1] common/qat: support GEN2 QAT device 200xx

[Adam Dybkowski]

This adds pci detection and documentation for Intel GEN2
QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 doc/guides/compressdevs/qat_comp.rst   | 3 ++-
 doc/guides/cryptodevs/qat.rst          | 8 ++++++--
 doc/guides/rel_notes/release_20_08.rst | 5 +++++
 drivers/common/qat/qat_device.c        | 6 +++++-
 4 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/doc/guides/compressdevs/qat_comp.rst b/doc/guides/compressdevs/qat_comp.rst
index 475c4a9f9..d421df235 100644
--- a/doc/guides/compressdevs/qat_comp.rst
+++ b/doc/guides/compressdevs/qat_comp.rst
@@ -1,5 +1,5 @@
 ..  SPDX-License-Identifier: BSD-3-Clause
-    Copyright(c) 2018 Intel Corporation.
+    Copyright(c) 2018-2020 Intel Corporation.
 
 Intel(R) QuickAssist (QAT) Compression Poll Mode Driver
 =======================================================
@@ -9,6 +9,7 @@ support for the following hardware accelerator devices:
 
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
+* ``Intel QuickAssist Technology 200xx``
 * ``Intel QuickAssist Technology DH895x``
 
 
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index 7f4036c32..a527744a4 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology DH895xCC``
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
+* ``Intel QuickAssist Technology 200xx``
 * ``Intel QuickAssist Technology D15xx``
 * ``Intel QuickAssist Technology P5xxx``
 
@@ -162,6 +163,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology DH895xCC``
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
+* ``Intel QuickAssist Technology 200xx``
 * ``Intel QuickAssist Technology D15xx``
 * ``Intel QuickAssist Technology P5xxx``
 
@@ -391,6 +393,8 @@ to see the full table)
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | Yes | Yes | "   | "        | 01.org/4.2.0+ | "             | "          | "      | "    | "      | "      |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
+   | Yes | Yes | Yes | 2   | 200xx    | p             | qat_200xx     | 200xx      | 18ee   | 1    | 18ef   | 16     |
+   +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 2   | D15xx    | p             | qat_d15xx     | d15xx      | 6f54   | 1    | 6f55   | 16     |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 3   | P5xxx    | p             | qat_p5xxx     | p5xxx      | 18a0   | 1    | 18a1   | 128    |
@@ -617,8 +621,8 @@ adjust the unbind command below::
         done; \
     done
 
-For Intel(R) QuickAssist Technology C3xxx or D15xx device
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+For Intel(R) QuickAssist Technology C3xxx or 200xx or D15xx device
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 The unbind command below assumes ``BDFs`` of ``01:01.00-01:02.07``, if your
 VFs are different adjust the unbind command below::
diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
index f19b74872..20209ef19 100644
--- a/doc/guides/rel_notes/release_20_08.rst
+++ b/doc/guides/rel_notes/release_20_08.rst
@@ -225,6 +225,11 @@ New Features
   See the :doc:`../sample_app_ug/l2_forward_real_virtual` for more
   details of this parameter usage.
 
+* **Added support for GEN2 device 200xx to Intel QAT driver.**
+
+  Added support for Intel GEN2 QuickAssist device 200xx
+  (PF Did 0x18ee, VF Did 0x18ef).
+
 
 Removed Items
 -------------
diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
index a6ab29f95..b050ce20e 100644
--- a/drivers/common/qat/qat_device.c
+++ b/drivers/common/qat/qat_device.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2018 Intel Corporation
+ * Copyright(c) 2018-2020 Intel Corporation
  */
 
 #include <rte_string_fns.h>
@@ -53,6 +53,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
 		{
 			RTE_PCI_DEVICE(0x8086, 0x6f55),
 		},
+		{
+			RTE_PCI_DEVICE(0x8086, 0x18ef),
+		},
 		{
 			RTE_PCI_DEVICE(0x8086, 0x18a1),
 		},
@@ -223,6 +226,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,
 	case 0x37c9:
 	case 0x19e3:
 	case 0x6f55:
+	case 0x18ef:
 		qat_dev->qat_dev_gen = QAT_GEN2;
 		break;
 	case 0x18a1:
-- 
2.25.1

Re: [dpdk-dev] [PATCH v2 1/1] common/qat: support GEN2 QAT device 200xx

[Trahe, Fiona]

Hi Adam,


> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Sent: Monday, July 13, 2020 12:10 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com; dev@dpdk.org
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH v2 1/1] common/qat: support GEN2 QAT device 200xx
> 
> This adds pci detection and documentation for Intel GEN2
> QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
>  doc/guides/compressdevs/qat_comp.rst   | 3 ++-
>  doc/guides/cryptodevs/qat.rst          | 8 ++++++--
>  doc/guides/rel_notes/release_20_08.rst | 5 +++++
>  drivers/common/qat/qat_device.c        | 6 +++++-
>  4 files changed, 18 insertions(+), 4 deletions(-)
> 
> diff --git a/doc/guides/compressdevs/qat_comp.rst b/doc/guides/compressdevs/qat_comp.rst
> index 475c4a9f9..d421df235 100644
> --- a/doc/guides/compressdevs/qat_comp.rst
> +++ b/doc/guides/compressdevs/qat_comp.rst
> @@ -1,5 +1,5 @@
>  ..  SPDX-License-Identifier: BSD-3-Clause
> -    Copyright(c) 2018 Intel Corporation.
> +    Copyright(c) 2018-2020 Intel Corporation.
> 
>  Intel(R) QuickAssist (QAT) Compression Poll Mode Driver
>  =======================================================
> @@ -9,6 +9,7 @@ support for the following hardware accelerator devices:
> 
>  * ``Intel QuickAssist Technology C62x``
>  * ``Intel QuickAssist Technology C3xxx``
> +* ``Intel QuickAssist Technology 200xx``
>  * ``Intel QuickAssist Technology DH895x``
> 
> 
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index 7f4036c32..a527744a4 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
>  * ``Intel QuickAssist Technology DH895xCC``
>  * ``Intel QuickAssist Technology C62x``
>  * ``Intel QuickAssist Technology C3xxx``
> +* ``Intel QuickAssist Technology 200xx``
>  * ``Intel QuickAssist Technology D15xx``
>  * ``Intel QuickAssist Technology P5xxx``
> 


> @@ -162,6 +163,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
>  * ``Intel QuickAssist Technology DH895xCC``
>  * ``Intel QuickAssist Technology C62x``
>  * ``Intel QuickAssist Technology C3xxx``
> +* ``Intel QuickAssist Technology 200xx``
>  * ``Intel QuickAssist Technology D15xx``
>  * ``Intel QuickAssist Technology P5xxx``
> 
> @@ -391,6 +393,8 @@ to see the full table)
>     +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
>     | Yes | Yes | Yes | "   | "        | 01.org/4.2.0+ | "             | "          | "      | "    | "      | "      |
>     +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
> +   | Yes | Yes | Yes | 2   | 200xx    | p             | qat_200xx     | 200xx      | 18ee   | 1    | 18ef   | 16     |
> +   +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+

[Fiona] For 20.08 this device should only be enabled for sym crypto - the rest will be enabled later.

[dpdk-dev] [PATCH v3 0/2] common/qat: support GEN2 QAT device 200xx

[Adam Dybkowski]

This adds pci detection and documentation for Intel GEN2
QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).

Adam Dybkowski (2):
  common/qat: support GEN2 QAT device 200xx
  doc: update QAT PMD release notes

 doc/guides/cryptodevs/qat.rst          |  7 +++++--
 doc/guides/rel_notes/release_20_08.rst | 12 +++++++++++-
 drivers/common/qat/qat_device.c        |  6 +++++-
 3 files changed, 21 insertions(+), 4 deletions(-)

-- 
2.25.1

[dpdk-dev] [PATCH v3 1/2] common/qat: support GEN2 QAT device 200xx

[Adam Dybkowski]

This adds pci detection and documentation for Intel GEN2
QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 doc/guides/cryptodevs/qat.rst          | 7 +++++--
 doc/guides/rel_notes/release_20_08.rst | 2 ++
 drivers/common/qat/qat_device.c        | 6 +++++-
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index 931a18f9a..b681180af 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology DH895xCC``
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
+* ``Intel QuickAssist Technology 200xx``
 * ``Intel QuickAssist Technology D15xx``
 * ``Intel QuickAssist Technology C4xxx``
 
@@ -391,6 +392,8 @@ to see the full table)
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | Yes | Yes | "   | "        | 01.org/4.2.0+ | "             | "          | "      | "    | "      | "      |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
+   | Yes | No  | No  | 2   | 200xx    | p             | qat_200xx     | 200xx      | 18ee   | 1    | 18ef   | 16     |
+   +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 2   | D15xx    | p             | qat_d15xx     | d15xx      | 6f54   | 1    | 6f55   | 16     |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 3   | C4xxx    | p             | qat_c4xxx     | c4xxx      | 18a0   | 1    | 18a1   | 128    |
@@ -617,8 +620,8 @@ adjust the unbind command below::
         done; \
     done
 
-For Intel(R) QuickAssist Technology C3xxx or D15xx device
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+For Intel(R) QuickAssist Technology C3xxx or 200xx or D15xx device
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 The unbind command below assumes ``BDFs`` of ``01:01.00-01:02.07``, if your
 VFs are different adjust the unbind command below::
diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
index f19b74872..e598d4882 100644
--- a/doc/guides/rel_notes/release_20_08.rst
+++ b/doc/guides/rel_notes/release_20_08.rst
@@ -191,6 +191,8 @@ New Features
     ``rte_security`` API.
   * Added Chacha20-Poly1305 AEAD algorithm.
   * Improved handling of multi process in QAT crypto and compression PMDs.
+  * Added support for Intel GEN2 QuickAssist device 200xx
+  (PF Did 0x18ee, VF Did 0x18ef).
 
 * **Updated the OCTEON TX2 crypto PMD.**
 
diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
index a6ab29f95..b050ce20e 100644
--- a/drivers/common/qat/qat_device.c
+++ b/drivers/common/qat/qat_device.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2018 Intel Corporation
+ * Copyright(c) 2018-2020 Intel Corporation
  */
 
 #include <rte_string_fns.h>
@@ -53,6 +53,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
 		{
 			RTE_PCI_DEVICE(0x8086, 0x6f55),
 		},
+		{
+			RTE_PCI_DEVICE(0x8086, 0x18ef),
+		},
 		{
 			RTE_PCI_DEVICE(0x8086, 0x18a1),
 		},
@@ -223,6 +226,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,
 	case 0x37c9:
 	case 0x19e3:
 	case 0x6f55:
+	case 0x18ef:
 		qat_dev->qat_dev_gen = QAT_GEN2;
 		break;
 	case 0x18a1:
-- 
2.25.1

[dpdk-dev] [PATCH v3 2/2] doc: update QAT PMD release notes

[Adam Dybkowski]

This patch separates QAT PMD paragraphs in the release notes
into three parts, for QAT Symmetric Crypto PMD, QAT Asymmetric
Crypto PMD and QAT Compression PMD.

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 doc/guides/rel_notes/release_20_08.rst | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
index e598d4882..da2833170 100644
--- a/doc/guides/rel_notes/release_20_08.rst
+++ b/doc/guides/rel_notes/release_20_08.rst
@@ -185,7 +185,7 @@ New Features
   Added support for lookaside protocol offload for DOCSIS through the
   ``rte_security`` API.
 
-* **Updated the QuickAssist Technology (QAT) PMD.**
+* **Updated the QuickAssist Technology (QAT) Symmetric Crypto PMD.**
 
   * Added support for lookaside protocol offload for DOCSIS through the
     ``rte_security`` API.
@@ -194,6 +194,14 @@ New Features
   * Added support for Intel GEN2 QuickAssist device 200xx
   (PF Did 0x18ee, VF Did 0x18ef).
 
+* **Updated the QuickAssist Technology (QAT) Asymmetric Crypto PMD.**
+
+  * Improved handling of multi process in QAT crypto and compression PMDs.
+
+* **Updated the QuickAssist Technology (QAT) Compression PMD.**
+
+  * Improved handling of multi process in QAT crypto and compression PMDs.
+
 * **Updated the OCTEON TX2 crypto PMD.**
 
   Added Chacha20-Poly1305 AEAD algorithm support in OCTEON TX2 crypto PMD.
-- 
2.25.1

Re: [dpdk-dev] [PATCH v3 2/2] doc: update QAT PMD release notes

[Akhil Goyal]

Hi Adam,
> 
> This patch separates QAT PMD paragraphs in the release notes
> into three parts, for QAT Symmetric Crypto PMD, QAT Asymmetric
> Crypto PMD and QAT Compression PMD.
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
>  doc/guides/rel_notes/release_20_08.rst | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/rel_notes/release_20_08.rst
> b/doc/guides/rel_notes/release_20_08.rst
> index e598d4882..da2833170 100644
> --- a/doc/guides/rel_notes/release_20_08.rst
> +++ b/doc/guides/rel_notes/release_20_08.rst
> @@ -185,7 +185,7 @@ New Features
>    Added support for lookaside protocol offload for DOCSIS through the
>    ``rte_security`` API.
> 
> -* **Updated the QuickAssist Technology (QAT) PMD.**
> +* **Updated the QuickAssist Technology (QAT) Symmetric Crypto PMD.**
> 
>    * Added support for lookaside protocol offload for DOCSIS through the
>      ``rte_security`` API.
> @@ -194,6 +194,14 @@ New Features
>    * Added support for Intel GEN2 QuickAssist device 200xx
>    (PF Did 0x18ee, VF Did 0x18ef).
> 
> +* **Updated the QuickAssist Technology (QAT) Asymmetric Crypto PMD.**
> +
> +  * Improved handling of multi process in QAT crypto and compression PMDs.
> +
> +* **Updated the QuickAssist Technology (QAT) Compression PMD.**
> +
> +  * Improved handling of multi process in QAT crypto and compression PMDs.
> +
I don't think these changes are required.
It is already updated as a bullet in QAT release notes for both crypto and compression PMD.
And I believe you do not need to sym and asym separately in the release notes.

[dpdk-dev] [PATCH v4 0/1] common/qat: support GEN2 QAT device 200xx

[Adam Dybkowski]

This adds pci detection and documentation for Intel GEN2
QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).

v2:
* rename the device
v3:
* improve release notes
v4:
* simplify release notes

Adam Dybkowski (1):
  common/qat: support GEN2 QAT device 200xx

 doc/guides/cryptodevs/qat.rst          | 7 +++++--
 doc/guides/rel_notes/release_20_08.rst | 8 +++++---
 drivers/common/qat/qat_device.c        | 6 +++++-
 3 files changed, 15 insertions(+), 6 deletions(-)

-- 
2.25.1

[dpdk-dev] [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx

[Adam Dybkowski]

This adds pci detection and documentation for Intel GEN2
QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 doc/guides/cryptodevs/qat.rst          | 7 +++++--
 doc/guides/rel_notes/release_20_08.rst | 8 +++++---
 drivers/common/qat/qat_device.c        | 6 +++++-
 3 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index 7ede427a2..e5d2cf499 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology DH895xCC``
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
+* ``Intel QuickAssist Technology 200xx``
 * ``Intel QuickAssist Technology D15xx``
 * ``Intel QuickAssist Technology C4xxx``
 
@@ -393,6 +394,8 @@ to see the full table)
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | Yes | Yes | "   | "        | 01.org/4.2.0+ | "             | "          | "      | "    | "      | "      |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
+   | Yes | No  | No  | 2   | 200xx    | p             | qat_200xx     | 200xx      | 18ee   | 1    | 18ef   | 16     |
+   +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 2   | D15xx    | 01.org/4.2.0+ | qat_d15xx     | d15xx      | 6f54   | 1    | 6f55   | 16     |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 3   | C4xxx    | p             | qat_c4xxx     | c4xxx      | 18a0   | 1    | 18a1   | 128    |
@@ -619,8 +622,8 @@ adjust the unbind command below::
         done; \
     done
 
-For Intel(R) QuickAssist Technology C3xxx or D15xx device
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+For Intel(R) QuickAssist Technology C3xxx or 200xx or D15xx device
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 The unbind command below assumes ``BDFs`` of ``01:01.00-01:02.07``, if your
 VFs are different adjust the unbind command below::
diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
index 2c8ac3647..48620e823 100644
--- a/doc/guides/rel_notes/release_20_08.rst
+++ b/doc/guides/rel_notes/release_20_08.rst
@@ -187,10 +187,12 @@ New Features
 
 * **Updated the QuickAssist Technology (QAT) PMD.**
 
-  * Added support for lookaside protocol offload for DOCSIS through the
-    ``rte_security`` API.
-  * Added Chacha20-Poly1305 AEAD algorithm.
+  * Added support for lookaside protocol offload in QAT crypto PMD
+    for DOCSIS through the ``rte_security`` API.
+  * Added Chacha20-Poly1305 AEAD algorithm in QAT crypto PMD.
   * Improved handling of multi process in QAT crypto and compression PMDs.
+  * Added support for Intel GEN2 QuickAssist device 200xx
+    (PF Did 0x18ee, VF Did 0x18ef).
 
 * **Updated the OCTEON TX2 crypto PMD.**
 
diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
index a6ab29f95..b050ce20e 100644
--- a/drivers/common/qat/qat_device.c
+++ b/drivers/common/qat/qat_device.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2018 Intel Corporation
+ * Copyright(c) 2018-2020 Intel Corporation
  */
 
 #include <rte_string_fns.h>
@@ -53,6 +53,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
 		{
 			RTE_PCI_DEVICE(0x8086, 0x6f55),
 		},
+		{
+			RTE_PCI_DEVICE(0x8086, 0x18ef),
+		},
 		{
 			RTE_PCI_DEVICE(0x8086, 0x18a1),
 		},
@@ -223,6 +226,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,
 	case 0x37c9:
 	case 0x19e3:
 	case 0x6f55:
+	case 0x18ef:
 		qat_dev->qat_dev_gen = QAT_GEN2;
 		break;
 	case 0x18a1:
-- 
2.25.1

Re: [dpdk-dev] [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx

[Trahe, Fiona]

> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Sent: Wednesday, July 22, 2020 9:07 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx
> 
> This adds pci detection and documentation for Intel GEN2
> QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH v4 1/1] common/qat: support GEN2 QAT device 200xx

[Akhil Goyal]

Hi Adam,

> diff --git a/doc/guides/rel_notes/release_20_08.rst
> b/doc/guides/rel_notes/release_20_08.rst
> index 2c8ac3647..48620e823 100644
> --- a/doc/guides/rel_notes/release_20_08.rst
> +++ b/doc/guides/rel_notes/release_20_08.rst
> @@ -187,10 +187,12 @@ New Features
> 
>  * **Updated the QuickAssist Technology (QAT) PMD.**
> 
> -  * Added support for lookaside protocol offload for DOCSIS through the
> -    ``rte_security`` API.
> -  * Added Chacha20-Poly1305 AEAD algorithm.
> +  * Added support for lookaside protocol offload in QAT crypto PMD
> +    for DOCSIS through the ``rte_security`` API.
> +  * Added Chacha20-Poly1305 AEAD algorithm in QAT crypto PMD.
>    * Improved handling of multi process in QAT crypto and compression PMDs.
> +  * Added support for Intel GEN2 QuickAssist device 200xx
> +    (PF Did 0x18ee, VF Did 0x18ef).

Please split these release notes in 2 patches.
For " Added support for Intel GEN2 QuickAssist device 200xx ", it should be part of this patch.

And for other updates, add a new patch with Fixes tag to the original patch which
introduced this change so that feature patch can be tracked from release notes
using git blame.

[dpdk-dev] [PATCH v5 0/2] common/qat: support GEN2 QAT device 200xx

[Adam Dybkowski]

This adds pci detection and documentation for Intel GEN2
QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).

v2:
* rename the device
v3:
* improve release notes
v4:
* simplify release notes
v5:
* split actual implementation patch and additional release notes update

Adam Dybkowski (2):
  common/qat: support GEN2 QAT device 200xx
  doc: update QAT PMD release notes

 doc/guides/cryptodevs/qat.rst          | 7 +++++--
 doc/guides/rel_notes/release_20_08.rst | 8 +++++---
 drivers/common/qat/qat_device.c        | 6 +++++-
 3 files changed, 15 insertions(+), 6 deletions(-)

-- 
2.25.1

[dpdk-dev] [PATCH v5 1/2] common/qat: support GEN2 QAT device 200xx

[Adam Dybkowski]

This adds pci detection and documentation for Intel GEN2
QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
 doc/guides/cryptodevs/qat.rst          | 7 +++++--
 doc/guides/rel_notes/release_20_08.rst | 2 ++
 drivers/common/qat/qat_device.c        | 6 +++++-
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index 7ede427a2..e5d2cf499 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -22,6 +22,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology DH895xCC``
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
+* ``Intel QuickAssist Technology 200xx``
 * ``Intel QuickAssist Technology D15xx``
 * ``Intel QuickAssist Technology C4xxx``
 
@@ -393,6 +394,8 @@ to see the full table)
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | Yes | Yes | "   | "        | 01.org/4.2.0+ | "             | "          | "      | "    | "      | "      |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
+   | Yes | No  | No  | 2   | 200xx    | p             | qat_200xx     | 200xx      | 18ee   | 1    | 18ef   | 16     |
+   +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 2   | D15xx    | 01.org/4.2.0+ | qat_d15xx     | d15xx      | 6f54   | 1    | 6f55   | 16     |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 3   | C4xxx    | p             | qat_c4xxx     | c4xxx      | 18a0   | 1    | 18a1   | 128    |
@@ -619,8 +622,8 @@ adjust the unbind command below::
         done; \
     done
 
-For Intel(R) QuickAssist Technology C3xxx or D15xx device
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+For Intel(R) QuickAssist Technology C3xxx or 200xx or D15xx device
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 The unbind command below assumes ``BDFs`` of ``01:01.00-01:02.07``, if your
 VFs are different adjust the unbind command below::
diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
index d65f77250..bb4a10053 100644
--- a/doc/guides/rel_notes/release_20_08.rst
+++ b/doc/guides/rel_notes/release_20_08.rst
@@ -200,6 +200,8 @@ New Features
     ``rte_security`` API.
   * Added Chacha20-Poly1305 AEAD algorithm.
   * Improved handling of multi process in QAT crypto and compression PMDs.
+  * Added support for Intel GEN2 QuickAssist device 200xx
+    (PF Did 0x18ee, VF Did 0x18ef).
 
 * **Updated the OCTEON TX2 crypto PMD.**
 
diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c
index a6ab29f95..b050ce20e 100644
--- a/drivers/common/qat/qat_device.c
+++ b/drivers/common/qat/qat_device.c
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2018 Intel Corporation
+ * Copyright(c) 2018-2020 Intel Corporation
  */
 
 #include <rte_string_fns.h>
@@ -53,6 +53,9 @@ static const struct rte_pci_id pci_id_qat_map[] = {
 		{
 			RTE_PCI_DEVICE(0x8086, 0x6f55),
 		},
+		{
+			RTE_PCI_DEVICE(0x8086, 0x18ef),
+		},
 		{
 			RTE_PCI_DEVICE(0x8086, 0x18a1),
 		},
@@ -223,6 +226,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev,
 	case 0x37c9:
 	case 0x19e3:
 	case 0x6f55:
+	case 0x18ef:
 		qat_dev->qat_dev_gen = QAT_GEN2;
 		break;
 	case 0x18a1:
-- 
2.25.1

[dpdk-dev] [PATCH v5 2/2] doc: update QAT PMD release notes

[Adam Dybkowski]

This patch updates 20.08 release notes inside
the part that describe changes in Intel QuickAssist PMD.

Fixes: faa57df0b458 ("crypto/qat: support ChaCha20-Poly1305")
Fixes: 9904ff684981 ("common/qat: improve multi-process handling")

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
 doc/guides/rel_notes/release_20_08.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
index bb4a10053..dce18f84d 100644
--- a/doc/guides/rel_notes/release_20_08.rst
+++ b/doc/guides/rel_notes/release_20_08.rst
@@ -196,9 +196,9 @@ New Features
 
 * **Updated the QuickAssist Technology (QAT) PMD.**
 
-  * Added support for lookaside protocol offload for DOCSIS through the
-    ``rte_security`` API.
-  * Added Chacha20-Poly1305 AEAD algorithm.
+  * Added support for lookaside protocol offload in QAT crypto PMD
+    for DOCSIS through the ``rte_security`` API.
+  * Added Chacha20-Poly1305 AEAD algorithm in QAT crypto PMD.
   * Improved handling of multi process in QAT crypto and compression PMDs.
   * Added support for Intel GEN2 QuickAssist device 200xx
     (PF Did 0x18ee, VF Did 0x18ef).
-- 
2.25.1

Re: [dpdk-dev] [PATCH v5 0/2] common/qat: support GEN2 QAT device 200xx

[Akhil Goyal]

> -----Original Message-----
> From: Adam Dybkowski <adamx.dybkowski@intel.com>
> Sent: Monday, July 27, 2020 3:44 PM
> To: dev@dpdk.org; fiona.trahe@intel.com; Akhil Goyal <akhil.goyal@nxp.com>
> Cc: Adam Dybkowski <adamx.dybkowski@intel.com>
> Subject: [PATCH v5 0/2] common/qat: support GEN2 QAT device 200xx
> 
> This adds pci detection and documentation for Intel GEN2
> QuickAssist device 200xx (PF Did 0x18ee, VF Did 0x18ef).
> 
> v2:
> * rename the device
> v3:
> * improve release notes
> v4:
> * simplify release notes
> v5:
> * split actual implementation patch and additional release notes update
> 
> Adam Dybkowski (2):
>   common/qat: support GEN2 QAT device 200xx
>   doc: update QAT PMD release notes
> 
>  doc/guides/cryptodevs/qat.rst          | 7 +++++--
>  doc/guides/rel_notes/release_20_08.rst | 8 +++++---
>  drivers/common/qat/qat_device.c        | 6 +++++-
>  3 files changed, 15 insertions(+), 6 deletions(-)
> 
Applied to dpdk-next-crypto

Thanks.

Re: [dpdk-dev] [PATCH v5 2/2] doc: update QAT PMD release notes

[Thomas Monjalon]

27/07/2020 12:14, Adam Dybkowski:
> This patch updates 20.08 release notes inside
> the part that describe changes in Intel QuickAssist PMD.
> 
> Fixes: faa57df0b458 ("crypto/qat: support ChaCha20-Poly1305")
> Fixes: 9904ff684981 ("common/qat: improve multi-process handling")
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
>  doc/guides/rel_notes/release_20_08.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
> index bb4a10053..dce18f84d 100644
> --- a/doc/guides/rel_notes/release_20_08.rst
> +++ b/doc/guides/rel_notes/release_20_08.rst
> @@ -196,9 +196,9 @@ New Features
>  
>  * **Updated the QuickAssist Technology (QAT) PMD.**
>  
> -  * Added support for lookaside protocol offload for DOCSIS through the
> -    ``rte_security`` API.
> -  * Added Chacha20-Poly1305 AEAD algorithm.
> +  * Added support for lookaside protocol offload in QAT crypto PMD
> +    for DOCSIS through the ``rte_security`` API.
> +  * Added Chacha20-Poly1305 AEAD algorithm in QAT crypto PMD.

I don't see the need for this patch.
Isn't it obvious that DOCSIS and ChachaPoly are related to crypto?
If you specify "QAT crypto PMD" or "QAT compress PMD"
in each item of QAT features, it will become not pleasant to read.