From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) by dpdk.org (Postfix) with ESMTP id ECCA8F60E for ; Thu, 30 Mar 2017 17:00:16 +0200 (CEST) Received: by mail-lf0-f44.google.com with SMTP id z15so28950429lfd.1 for ; Thu, 30 Mar 2017 08:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Emu3A3b3ywGWHOPJFJ2C3JI5O1j4DmztO0bFBlxNq6Y=; b=IKmdrpOlH8cxI8DSnscljANsjfUgHOs+fVkeJt+x3fLNeGKSpq6iyy24gn5/3Gu5SW NjtFiqu82CyVGOcOkNWOhuOU0hoaG2TvECsAX0/yKVheLtnqMg9sxNV5og9FrKJaWUlt FAIKQPHkkgjWPuTH2LumuqQXdAVK9Iv3FXtKU2x4iXwXGQtNNcKLgdyNqFuXXweYtvx7 m9GVa7CjETr/ko2YdyAryMWox+kDkjv1FhFqOM0+IGGYiEWiyQqZeyPnT6LE9e38Gsvb HvokF7jzxNGcuYJMrpmSFf5oKv5gtbRqjoR5z20AE+Xbuvw8QndigX8WhnvXN6smMyA0 Q+lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Emu3A3b3ywGWHOPJFJ2C3JI5O1j4DmztO0bFBlxNq6Y=; b=go58iRHagZ+byrteweAUDkZg1WFdMnjVDnh8PiNW056ODLjQIYQwMC9puCd02X3GcT V5ObmY8+MGKQzkbyo5IGu970Dx5yz65BLKF2pIe00kD/NGJGw2EOKcdpzw8hIFbPY6k7 g2jDtcmLZk+MXK1Kk6DWYjXn9rwBzKTgzDjWmSAYhz/sVKo1+MmgWV9n8/Our4sxG8L3 FptYRLRiruTB9nsvdTQEqIsOLwy0pWk8l6hbZ3cKEpIWcAhM4Eyd7CX8H9WypFv80GD3 hIHU7+GrGsQZmo8KzSjaThNS4LsGddspXp4CkU5Lcapzxray+xDEYTM1/0FN8QynJ0MJ n9rg== X-Gm-Message-State: AFeK/H1FAOnIFerD09S2CETWP8MJcsptQ+/C3Tz1LunVx6wFHU9o1/c1M02paA+OZjjNBPDP X-Received: by 10.28.46.198 with SMTP id u189mr3858317wmu.54.1490886016506; Thu, 30 Mar 2017 08:00:16 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id o66sm3537073wmg.33.2017.03.30.08.00.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2017 08:00:15 -0700 (PDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, "Rao, Nikhil" Date: Thu, 30 Mar 2017 17:00:14 +0200 Message-ID: <4264918.VdEWygDdWb@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1490742934-30608-1-git-send-email-nikhil.rao@intel.com> <1490745247-32001-1-git-send-email-nikhil.rao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] vfio: Fix vfio disable INTx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 15:00:17 -0000 2017-03-28 15:28, Burakov, Anatoly: > > From: Rao, Nikhil > > Sent: Wednesday, March 29, 2017 12:54 AM > > To: Burakov, Anatoly > > Cc: dev@dpdk.org > > Subject: [PATCH v2] vfio: Fix vfio disable INTx > > > > The flags member of irq_set should be ORed with > > VFIO_IRQ_SET_ACTION_MASK and not VFIO_IRQ_SET_ACTION_UNMASK. > > The bug was found by code inspection. > > > > Fixes: 5c782b3928b8 (\"vfio: interrupts\") > > > > Signed-off-by: Nikhil Rao > > Great find! > > Acked-by: Anatoly Burakov Applied, thanks