From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 697311B1C3
 for <dev@dpdk.org>; Wed, 11 Oct 2017 12:46:18 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id F02BD20AFE;
 Wed, 11 Oct 2017 06:46:17 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Wed, 11 Oct 2017 06:46:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=VwEd/GvCPPYub70TDvN0FL7Rjl
 w4qn8iEEvulX0dzw8=; b=FWhT9GmzfjQVr6S29gQh/5KxQfT47HkPxctFQdEFMR
 9w2ZngHKa1Jn2FsnwGI2xt/Iox+UWOW3qexgkK8WFjls917mXZxfsTdmnWgwewce
 tmmyC13ZXLyJtHlaabXptlyUHEbCN7xOpRDz3MwdUjrOB/JlVRQFYGXYmeJTM3c1
 4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=VwEd/G
 vCPPYub70TDvN0FL7Rjlw4qn8iEEvulX0dzw8=; b=mBn+ghtnyLLaPdXkXN111i
 tHaIJmUlDAlNNnjziYr9zstjiWpl5FBBaEM9z3xSUR7BNbPbHSUkjW2y5eYrae1A
 hAreLclLHMF2LKesOJsImswWZE+qU5/H/4sBQsq+uMI6TnIZfLe/60UbfOcWwWEK
 ZmwolEOdZJoeJ0xikWA0CTWXiT9U36glE3fPPV+dbX7jcxXq6OqR7VYBVMa8R7uu
 9JAZ1wDD5EFVFtpGlqzvBKtLxuVG/SRGY7B2zTuWOAhn4zLz2YPNpBMohmFOJgwT
 rxQj/VNouB+2OQJLnY0MIe1HZta37BfprBoYTCVA75219MElftOjihYtwgS8HSkQ
 ==
X-ME-Sender: <xms:efbdWRGs7FRNvHOOEtI0_NeQq5MzQhH62ooWeGrfBvYb99mX5_UA-w>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 9D99F24038;
 Wed, 11 Oct 2017 06:46:17 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org
Date: Wed, 11 Oct 2017 12:46:16 +0200
Message-ID: <4271901.RE8S8KQ4zy@xps>
In-Reply-To: <3da5949d-71d1-43d9-1583-c5d401ee0bcb@intel.com>
References: <1507565524-18590-1-git-send-email-matan@mellanox.com>
 <157d75ef-01d0-6aca-81ec-c69bce2360c1@intel.com>
 <3da5949d-71d1-43d9-1583-c5d401ee0bcb@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev
	op
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Oct 2017 10:46:18 -0000

11/10/2017 04:09, Ferruh Yigit:
> On 10/11/2017 3:01 AM, Ferruh Yigit wrote:
> > On 10/10/2017 9:20 PM, Matan Azrad wrote:
> >> The stats_get dev op API doesn't include return value, so PMD cannot
> >> return an error in case of failure at stats getting process time.
> >>
> >> Since PCI devices can be removed and there is a time between the
> >> physical removal to the RMV interrupt, the user may get invalid stats
> >> without any indication.
> >>
> >> This patch changes the stats_get API return value to be int instead of
> >> void.
> >>
> >> All the net PMDs stats_get dev ops are adjusted by this patch.
> >>
> >> Signed-off-by: Matan Azrad <matan@mellanox.com>
> > 
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Applied to dpdk-next-net/master, thanks.

It is breaking compilation of tests:

test/test/virtual_pmd.c:256:15: fatal error: incompatible pointer types
      initializing 'eth_stats_get_t' (aka 'int (*)(struct rte_eth_dev *, struct rte_eth_stats *)')
      with an expression of type 'void (struct rte_eth_dev *, struct rte_eth_stats *)'
      [-Wincompatible-pointer-types]
        .stats_get = virtual_ethdev_stats_get,