From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95BCEA0C40; Fri, 11 Jun 2021 09:19:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 583E1410E5; Fri, 11 Jun 2021 09:19:56 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 7430540FDF for <dev@dpdk.org>; Fri, 11 Jun 2021 09:19:55 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 05E7958083A; Fri, 11 Jun 2021 03:19:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 11 Jun 2021 03:19:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= DtQJSUwR+5l+J/IJs2WEaNC9oVNs7tLk7aGWE5IFpG0=; b=OmDRdYcV+sHkPT1J cRRI4t4lmiwPDM+Cw6vABesWG0apfsVcDt9NT1klnYU/5ynv/GiPAPBN8HeEgpMG Ipa/8pd3DPwz6rjoBj9CVhqzfq6aCfyUfedud+fhmD09gD7XXprUrTXdM8NN/a3p 4Auq0NPJ9i1Xphbz+2Rf86fgv2UJxckpLXP8lbBKsemHQE0ukAexE6A7S6U3lbB9 aVdWuaZXAQCQM8jA7nK3rgeE2R6e4OaXpNjX+Mtngv7Q5b836h1MfDluibLF79y1 BWTl9CJD/64aYsry5xG8NqO5Vqe4h7vEGUfSfCAVaGIWRjzK/TcAQ4RDxZPc+ktX y+yyrQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=DtQJSUwR+5l+J/IJs2WEaNC9oVNs7tLk7aGWE5IFp G0=; b=g0pffmqSRyuNhM2DAb28xFJAl6NOKARn+uGjObZK9LAvHwIztst+aLNl5 2UxHtnGHej/U2QYsIj6QEJmfc/xBvrVoY3byZ1Zj/aWR14/wIgNIXF53cKCiUf7b bEq6pfXdsJFQAHz+J+1G/EM5DZHgiE+wsvxiUXgTli+eDP1UziSCTdY+6pvdK/Dq 2oA28PrLl8owusJBsr4aHy9t1ltmC8ftw14QLX5L5rPzYYILaALio0c1YSTDsk+s 65+8A5qjhTR0kMWqjfKb23wldDMhPL36vzXtu3hIHjqSo2inqw1RBMI66bC7vFHR 5hJki81z21WQz+4gu8bafPJ9zuvcw== X-ME-Sender: <xms:mg7DYFbgPWkFQId5oxh5zpBxKrx3l0WMNTB5KDWS8Am8jRDfufwbKg> <xme:mg7DYMbkIxIEIFI8yt3OUr0isvSVm70W_QNu79qqQb-bwbNG8SMMyeT-PxewVFseY 8diP8C4GmFvPA_u-A> X-ME-Received: <xmr:mg7DYH-kuopnnwbOJJPiw2wnjoUhDB5vsWAEu4c9rJEWuyDjivChOXY_It1EnCIk3GvsEtF7C9xIxeSyqSFKbjF35w> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeduiedgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:mg7DYDqQOc21ave_UKeQOUv6mArGSoeNlzC-J-MSiKMgjENGidFFaA> <xmx:mg7DYApJ0pY1a_UCQTkgGao0KoAxigk9DmXIGtlyvznsNkVMEH_YlQ> <xmx:mg7DYJSxRqdQOjLcvS8vxhoVUXD8XQaMhzIPtqgozc2eQX6ybtAs1Q> <xmx:mw7DYFRR_DvTnI7zt5sgiZCvgaOgHaLnJbBnO6EFG64Ng03w0htpuQ> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Jun 2021 03:19:52 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Tiwei Bie <tiwei.bie@intel.com>, Chenbo Xia <chenbo.xia@intel.com> Cc: dev@dpdk.org, cunming.liang@intel.com, jingjing.wu@intel.com, anatoly.burakov@intel.com, ferruh.yigit@intel.com, mdr@ashroe.eu, nhorman@tuxdriver.com, bruce.richardson@intel.com, david.marchand@redhat.com, stephen@networkplumber.org, konstantin.ananyev@intel.com Date: Fri, 11 Jun 2021 09:19:51 +0200 Message-ID: <4274346.LoYqEGjqz4@thomas> In-Reply-To: <20210601030644.3318-5-chenbo.xia@intel.com> References: <20190715075214.16616-6-tiwei.bie@intel.com> <20210601030644.3318-1-chenbo.xia@intel.com> <20210601030644.3318-5-chenbo.xia@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC v3 4/6] eal: add a helper for reading string from sysfs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 01/06/2021 05:06, Chenbo Xia: > From: Tiwei Bie <tiwei.bie@intel.com> > > This patch adds a helper for reading string from sysfs. > > Signed-off-by: Cunming Liang <cunming.liang@intel.com> > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com> > --- > lib/eal/common/eal_filesystem.h | 10 ++++++++++ > lib/eal/freebsd/eal.c | 22 ++++++++++++++++++++++ > lib/eal/linux/eal.c | 22 ++++++++++++++++++++++ > lib/eal/version.map | 3 +++ > 4 files changed, 57 insertions(+) 3 separate comments: 1/ How much code is portable between Linux and FreeBSD? I guess the path will be different? 2/ Please think about Windows stub. 3/ Instead of EAL, we should start lib/sysfs/ I have other ideas of sysfs functions for PMD use.