From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, matan@mellanox.com,
maxime.coquelin@redhat.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] buildtools: allow pedantic empty pmdinfo
Date: Wed, 05 Feb 2020 18:29:17 +0100 [thread overview]
Message-ID: <4296948.CvnuH1ECHv@xps> (raw)
In-Reply-To: <20200205171422.GB759@bricha3-MOBL.ger.corp.intel.com>
05/02/2020 18:14, Bruce Richardson:
> On Wed, Feb 05, 2020 at 06:07:23PM +0100, Thomas Monjalon wrote:
> > If a driver has no info generated by pmdinfogen,
> > and if this driver is compiled as pedantic,
> > then an failure would occur:
> > drivers/rte_common_mlx5.pmd.c:1: error:
> > ISO C forbids an empty translation unit [-Werror=pedantic]
> > Such error is triggered with the new mlx5 common directory.
> >
> > In order to allow an "empty driver info" compiled in pedantic mode,
> > the script generating .pmd.c file is modified to add a static string
> > unconditionnaly.
> > The minimal generated code is:
> > static __attribute__((unused)) const char *generator =
> > "/path/to/dpdk/buildtools/gen-pmdinfo-cfile.sh";
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> LGTM
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks, it will allow pulling next-net
without breaking debug compilation for the new ABI tooling.
prev parent reply other threads:[~2020-02-05 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 17:07 Thomas Monjalon
2020-02-05 17:14 ` Bruce Richardson
2020-02-05 17:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4296948.CvnuH1ECHv@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).