From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE66AA04FA; Wed, 5 Feb 2020 18:29:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6B8661C438; Wed, 5 Feb 2020 18:29:21 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DEA831C2F1 for ; Wed, 5 Feb 2020 18:29:19 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 39D2E220B8; Wed, 5 Feb 2020 12:29:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 05 Feb 2020 12:29:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ppoxvryHXfBlH+kyOiROnqkp+kCytNkvARhtm1ielwc=; b=B2UaDxEcXqXc 9BPrQ0G3cqcJ+sz4jS7BBN4HQpSWHeqR5VDVg3aglgz0H8qK6ONC5frLpDoGBImo csJxPVcDNhvD7ef838NIm5Hx/LzFD/YjXAKjFF++VQWTZzTciU4w4xrZ32LPZ+cX IbBvXkw+radwFIpCd9zrgpu5qtU3jfg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ppoxvryHXfBlH+kyOiROnqkp+kCytNkvARhtm1iel wc=; b=FgK1OINwHgCPTJjvvMe5GOYTGW8v1knpfn8AODjFP1cE6HBYuiEI3E3Ik sFW1sZpOtGfuYxGaxCt8zVlaM3IZGY1LdAMEQV7nDO31nc0Mdy4XPm0o9uSjxEfO tZ7g77ygE4KLrXQ4SDfrf6GWQPtNmazmx15t3Xvi9DWxU1m45SiN5tCTqDW4Z0TB zew3eTLmC/Nf2t9mrhA5Enm0enJWix7Z4zpCtK/kC8FxeRXTMEaD8kLa69hVDVhs bu08nLe5+028RID+GPD9nduLsGJS0UnYOkqnjgUi08c6D8eVb0u/HhuYlLqrUO3a CysdCyL3QTmRojjG53pQrT1/c6oCg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrhedugdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 13D6130606FB; Wed, 5 Feb 2020 12:29:17 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, ferruh.yigit@intel.com, matan@mellanox.com, maxime.coquelin@redhat.com, david.marchand@redhat.com Date: Wed, 05 Feb 2020 18:29:17 +0100 Message-ID: <4296948.CvnuH1ECHv@xps> In-Reply-To: <20200205171422.GB759@bricha3-MOBL.ger.corp.intel.com> References: <20200205170723.3347232-1-thomas@monjalon.net> <20200205171422.GB759@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] buildtools: allow pedantic empty pmdinfo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/02/2020 18:14, Bruce Richardson: > On Wed, Feb 05, 2020 at 06:07:23PM +0100, Thomas Monjalon wrote: > > If a driver has no info generated by pmdinfogen, > > and if this driver is compiled as pedantic, > > then an failure would occur: > > drivers/rte_common_mlx5.pmd.c:1: error: > > ISO C forbids an empty translation unit [-Werror=pedantic] > > Such error is triggered with the new mlx5 common directory. > > > > In order to allow an "empty driver info" compiled in pedantic mode, > > the script generating .pmd.c file is modified to add a static string > > unconditionnaly. > > The minimal generated code is: > > static __attribute__((unused)) const char *generator = > > "/path/to/dpdk/buildtools/gen-pmdinfo-cfile.sh"; > > > > Signed-off-by: Thomas Monjalon > > LGTM > > Acked-by: Bruce Richardson Applied, thanks, it will allow pulling next-net without breaking debug compilation for the new ABI tooling.