From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F107E45BA3; Tue, 22 Oct 2024 18:01:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E451C40651; Tue, 22 Oct 2024 18:01:14 +0200 (CEST) Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) by mails.dpdk.org (Postfix) with ESMTP id 626784060B for ; Tue, 22 Oct 2024 18:01:13 +0200 (CEST) Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id E029C114015F; Tue, 22 Oct 2024 12:01:12 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Tue, 22 Oct 2024 12:01:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1729612872; x=1729699272; bh=+9WDDb4wqGa1Cll+L9IUXmAVmLNivN5USxYe7PFbz1A=; b= Y8+UN1Re2t34rictlOwHIqS1/bAItZbqCjX6BRDfiNauJw9dSTg6c5t7lS9HTX9L B1CLdRcJd88ezwGoy3T4Oi/D3HynND+K1VdIdEMTuSjNdoFQQgUO84y5ktiYnT3i +dl3PzTcOtt5Jmj+oPOF9LK2JH0Ga5TdZ17GuOcp6+vm20XXAKWgdtC7Zf+HjTyR 4XZq4i9fFCdE9zDC1ELsgqSiGdXmm0OjD31WFcHuI+Q1yyCvaLAAh/ZtGNJX8W3H ofZm+UOxtTCBV3P2ODrU3XZyN+OeWpmHvg71PVopUeZb4ZSeEquOPbnj70HrdW5o 313OS0SMxFmGyNNzEiE0WA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1729612872; x= 1729699272; bh=+9WDDb4wqGa1Cll+L9IUXmAVmLNivN5USxYe7PFbz1A=; b=m LU97dVWA3eDL9Mk9TOro/GWCBEs9ed1ej0tIyqYH9fh91m50poRffND5+zVSRp7L AnYRJW14vcm+wqYGIyGqgpDVXG6WlqgggjhMLRR+LgMoD/cUmPLKbICFq6XoVVtm sdgk6GsFwFQQ1p+1jGkL11i3NjJIociJZgD1RzqWOZmMP3Z/rMTyO8koYqnLVlAI KyFt1Ag1df691pUdqwIA6Cjf6Y9TWg3ROEs2hfHk1+GerUnUMFhAZ25P/B7+hhvB GP1VUZfVUGY0VgTEOQKeXBRfUo5euchrblrKs5WtKFX/o7vT2bsfEDHZxDVZGxWt V1Oa8dRdYV09I9Cg8JWQg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeihedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeejpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehrjhgrrh hrhiesrhgvughhrghtrdgtohhmpdhrtghpthhtohepsghruhgtvgdrrhhitghhrghrughs ohhnsehinhhtvghlrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhgpdhrtg hpthhtohepjhhsphgvfihotghksehiohhlrdhunhhhrdgvughupdhrtghpthhtoheplhhu tggrrdhvihiiiigrrhhrohesrghrmhdrtghomhdprhgtphhtthhopegumhgrrhigsehioh hlrdhunhhhrdgvughupdhrtghpthhtohepjhhurhgrjhdrlhhinhhkvghssehprghnthhh vghonhdrthgvtghh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Oct 2024 12:01:10 -0400 (EDT) From: Thomas Monjalon To: Robin Jarry , Bruce Richardson Cc: dev@dpdk.org, Jeremy Spewock , Luca Vizzarro , Dean Marx , Juraj =?UTF-8?B?TGlua2XFoQ==?= Subject: Re: [PATCH dpdk] meson: properly disable docs Date: Tue, 22 Oct 2024 18:01:08 +0200 Message-ID: <4297957.3T5rpR7ggn@thomas> In-Reply-To: References: <20241022151142.246535-2-rjarry@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 22/10/2024 17:49, Bruce Richardson: > On Tue, Oct 22, 2024 at 05:31:47PM +0200, Robin Jarry wrote: > > Bruce Richardson, Oct 22, 2024 at 17:25: > > > No strong objection to this. Just FYI, the reason it is currently done as > > > it is in the build, is that even if you configure a build without the docs > > > enabled, you can just build the docs explicitly by doing "ninja -C build > > > doc". That is so that one can do a test build of the docs without > > > a) having to reconfigure the whole project > > > b) not have every build from then on rebuild e.g. the APIs doc if you > > > change a header. > > > > Oh, I didn't know it was on purpose. I was surprised to see doc related > > warnings with -Denable_docs=false. > > > > Feel free to disregard this patch if you think it is too drastic. > > > Like I said, I don't have that strong of opinions about it - I just wanted > to let you and others know that there was *some* (however little) method > behind the madness of doing things this way. Let's not change the convenient behaviour. I reject this patch. > It is possible to fix the error directly, so that the warning does not > appear if docs are disabled? We must fix warnings yes.