From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 614941B6AF for ; Mon, 23 Oct 2017 22:15:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E8FCB20DC6; Mon, 23 Oct 2017 16:15:03 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 23 Oct 2017 16:15:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=PkWoFkCNbRFgRUPpo7uUATy6t8 we6Y/6w0GqI9kzmOI=; b=o+ju8jxoWdUICtb1lhieksJ38uo8QR+bqmnhnnhrrX CyIqaySVeAr8sZrQr7E3quntBo74XI0tesDpwvOCbuygmtA1ezJymrSXoQ7pES6E SHSNEMvlopGlvL13K8jvSJtyvM2m3h+XPgDZ+vob/vbS92TteHes9gVaL0Gzp5xZ A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=PkWoFk CNbRFgRUPpo7uUATy6t8we6Y/6w0GqI9kzmOI=; b=CUAeb27/FrLODuSx38jvgS ab6Ye1cbjP5QWhP7IzCf8Vft0Bv/xsdZXoBMuWsH/MnwikFn3dZtV+RHQuxrEpYk srpg3MlYjL9zsvjQukXlidqF1myo6vFnD1pVoKsfKuL/jRC6SUIGvXJcRpRcAwDi cwUCnm4LTWCslPAwdNlEdt5gwohT3cooABr8x/NfiEVXKkjlyE70Ohjdmkb7QEl4 dqn0lNH1L5deoBr0aps+mn/IB3CM2nbiYSQBJ43+NF4K+m2wTYTUqSMF2cEsu7R3 1B+0FtVFpxJBrvCPJOAcw8e4mmh0M+umggN96DruuvHy2yUNilr78VtldBebjEaw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A7F7B7FA7E; Mon, 23 Oct 2017 16:15:03 -0400 (EDT) From: Thomas Monjalon To: Santosh Shukla Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, anatoly.burakov@intel.com Date: Mon, 23 Oct 2017 22:15:02 +0200 Message-ID: <4299450.srK9Y67Yii@xps> In-Reply-To: <20171020123136.10557-3-santosh.shukla@caviumnetworks.com> References: <20170905103119.20511-1-santosh.shukla@caviumnetworks.com> <20171020123136.10557-1-santosh.shukla@caviumnetworks.com> <20171020123136.10557-3-santosh.shukla@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/6] eal/memory: rename buf physaddr to buf iovaaddr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 20:15:04 -0000 20/10/2017 14:31, Santosh Shukla: > Rename buf_physaddr to buf_iovaaddr > > Signed-off-by: Santosh Shukla > Reviewed-by: Anatoly Burakov > --- [...] > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -411,7 +411,7 @@ struct rte_mbuf { > * same mbuf cacheline0 layout for 32-bit and 64-bit. This makes > * working on vector drivers easier. > */ > - iova_addr_t buf_physaddr __rte_aligned(sizeof(iova_addr_t)); > + iova_addr_t buf_iovaaddr __rte_aligned(sizeof(iova_addr_t)); I really do not understand this naming scheme. The "A" of IOVA means Address. So "addr" in iovaaddr is redundant. It seems that IOVA is a too much famous acronym to avoid it. Unfortunately, there is no justification in the commit message. For the record, my preference was "IO address". We could at least add an underscore in iova_addr. But I will apply it as is because nobody else complained.