From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68625A04DB; Fri, 16 Oct 2020 18:44:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 54F771E938; Fri, 16 Oct 2020 18:44:17 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 05E171DCA7 for ; Fri, 16 Oct 2020 18:08:00 +0200 (CEST) IronPort-SDR: UaSp41dV+lxurvM3CUl3xjMFNrrOSkVc2w9/5QrtabS1E4J55xFj578SvEMv70LTFVrESPYeEN i4egSHj6KanQ== X-IronPort-AV: E=McAfee;i="6000,8403,9776"; a="230825358" X-IronPort-AV: E=Sophos;i="5.77,383,1596524400"; d="scan'208";a="230825358" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 09:06:56 -0700 IronPort-SDR: Zjph/XZbtc0NujmOunWMIBL1pfzzTaLFXC4JJHa/d23OG7irV4iwH3Ahc9IFm6VGapAz9r24Va MH0NY8GokXNg== X-IronPort-AV: E=Sophos;i="5.77,383,1596524400"; d="scan'208";a="531776431" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.19.66]) ([10.252.19.66]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2020 09:06:54 -0700 To: Thomas Monjalon Cc: Viacheslav Ovsiienko , dev@dpdk.org, stephen@networkplumber.org, olivier.matz@6wind.com, jerinjacobk@gmail.com, maxime.coquelin@redhat.com, david.marchand@redhat.com, arybchenko@solarflare.com References: <1602855582-15847-2-git-send-email-viacheslavo@nvidia.com> <512ad0ea-827a-3767-6d43-1d5100b25202@intel.com> <14842522.L6QGMzUDIC@thomas> From: Ferruh Yigit Message-ID: <42e02583-d0b9-1ebf-62e5-db6bd322a6c6@intel.com> Date: Fri, 16 Oct 2020 17:06:50 +0100 MIME-Version: 1.0 In-Reply-To: <14842522.L6QGMzUDIC@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v11 1/6] ethdev: introduce Rx buffer split X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/16/2020 5:05 PM, Thomas Monjalon wrote: > 16/10/2020 17:47, Ferruh Yigit: >> On 10/16/2020 2:39 PM, Viacheslav Ovsiienko wrote: >>> +__rte_experimental >>> +struct rte_eth_rxseg_split { >>> + struct rte_mempool *mp; /**< Memory pool to allocate segment from. */ >>> + uint16_t length; /**< Segment data length, configures split point. */ >>> + uint16_t offset; /**< Data offset from beginning of mbuf data buffer. */ >>> + uint32_t reserved; /**< Reserved field. */ >>> +}; >>> + >>> +/** >>> + * A common structure used to describe Rx packet segment properties. >>> + */ >>> +__rte_experimental >>> +union rte_eth_rxseg { >>> + /* The settings for buffer split offload. */ >>> + struct rte_eth_rxseg_split split; >>> + /* The other features settings should be added here. */ >>> +}; >> >> Is the '__rte_experimental' on the data structs do anything other than >> documentation? >> >> icc is complaining about them [1], if they are only for documenation, would it >> be OK to move it to the comment and remove the '__rte_experimental' tag? >> >> [1] >> ../lib/librte_ethdev/rte_ethdev.h(1005): error #2651: attribute does not apply >> to any entity >> __rte_experimental >> ^ > > Yes should be a comment. > Following is a sample from rte_flow.h as comment: https://git.dpdk.org/dpdk/tree/lib/librte_ethdev/rte_flow.h?h=v20.08#n1392