From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 628F8A2EFC for ; Tue, 17 Sep 2019 12:41:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 99A1C1BED5; Tue, 17 Sep 2019 12:41:44 +0200 (CEST) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id B137B1C07E for ; Tue, 17 Sep 2019 12:41:42 +0200 (CEST) Received: by mail-lj1-f193.google.com with SMTP id l21so1232011lje.4 for ; Tue, 17 Sep 2019 03:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=5yHEkWf4EZrnagth+USpi6oRzj/u76vDMXYsBViMqEQ=; b=G3nsg8XU8ET4dHp6we/OarpOvvnRujp/S7IER1dnAk7vZOSqnjBhcI3boAzSgZnKDQ n4wtzbU1rQjRzE51N08mux8nXTnxMCSjgrMaXV3ghcS6VXDSkDypcXfSq65NULoXnKGP 2D7RWuxwT1i1Za6iQrO8VhNVOMA/W9l+V44Mk/XiRQzqoOdKvf1IHeKGIbCrwxwIjnXz JknVrNUT/M9laSBoia7SAxlPY6MbhMtRhfIM0YIJY/BvxgfFKxV+Z/6yrlN421k3Na+U 5ESvs9SeZ7vs3fc7p1R1KDSr2dKBVdlPAv7zaoSJ/WIAku4qOaZdXrAxoIx8GPc9yNg5 uuNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5yHEkWf4EZrnagth+USpi6oRzj/u76vDMXYsBViMqEQ=; b=KIriL+0OHsVTbBUXq+YaVG2xrVgktgCWne53CedenzfFfmoxNkySCDWK/NHt2Whqk2 8Bdx4NAcVJONBE5/7Op1+OQMzCLFjGTFSC27K1AhdoAs36sqCDD1YfK/q+U/Bp2M5H/U 2sDT9rDKqOV4tPOcgSal4QzO5/Oxq2BQw96GrbiaJI6BjqOUbMWzxOqrgbFG+y92z3J4 fGHgQrU14LRklkehNAk3EDwkgxi7uW14PMlpTzxRPFucLTLzqH55ZwXyme/PW1yk0D9f ws45Za2NXPIYDtAK7dv742iKxGaTonqVI9haot8xzmcuXURWmBgH2jirCAet3F9Jgt6Z GDSw== X-Gm-Message-State: APjAAAVuiZ+sqiz3xtB/Cg3xTxwSceBA6EzMG2sOmIe7wKup6Ol3S8X5 P4hH1z39km7tqu5zEL54FYU6t78Nz4e8Uw== X-Google-Smtp-Source: APXvYqwMV0KUGvyszHeFQr/9yZOuU0u56a4KS1mSKdBBUOKXsEGEYKOtMf9iNk10poNcxmLm+1SRAA== X-Received: by 2002:a2e:87ca:: with SMTP id v10mr1491883ljj.53.1568716901945; Tue, 17 Sep 2019 03:41:41 -0700 (PDT) Received: from [10.0.0.72] (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id x15sm417478lff.54.2019.09.17.03.41.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 03:41:41 -0700 (PDT) To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org References: <20190905093239.27187-1-amo@semihalf.com> <20190905093239.27187-6-amo@semihalf.com> <85b8287e-4396-6cdd-bd24-79ebfd408e3c@gmail.com> From: Andrzej Ostruszka Message-ID: <42ea5abf-24a6-dbe2-3284-67adfb724312@semihalf.com> Date: Tue, 17 Sep 2019 12:41:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <85b8287e-4396-6cdd-bd24-79ebfd408e3c@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 05/10] app/test: fix maybe-uninitialized warnings for LTO build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/5/19 3:25 PM, Chas Williams wrote: [...] >> @@ -578,7 +578,9 @@ bond_get_update_timeout_ms(void) >> { >> struct rte_eth_bond_8023ad_conf conf; >> >> - rte_eth_bond_8023ad_conf_get(test_params.bonded_port_id, &conf); >> + if (rte_eth_bond_8023ad_conf_get(test_params.bonded_port_id, &conf) < 0) >> + return 0; >> + > > This would return a delay of 0ms, which doesn't feel like it captures > the intent of conf_get failing. Perhaps a TEST_ASSERT_FAILURE() instead? Chas, I've sent today reworked version. I've taken this remark into account however TEST_ASSERT_FAILURE() is not really appropriate here since this macro is not really an assert. It returns -1, which does not play well with the signature of this function (return is unsigned) and how it is used. So I've just inlined the logs. Regards Andrzej