From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 736C9A0C4D; Mon, 6 Sep 2021 13:21:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E708D4111A; Mon, 6 Sep 2021 13:21:40 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 1386A41109 for ; Mon, 6 Sep 2021 13:21:38 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10098"; a="305507243" X-IronPort-AV: E=Sophos;i="5.85,272,1624345200"; d="scan'208";a="305507243" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2021 04:21:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,272,1624345200"; d="scan'208";a="604583717" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 06 Sep 2021 04:21:38 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 6 Sep 2021 04:21:37 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 6 Sep 2021 04:21:37 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 6 Sep 2021 04:21:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KtbsgCWL68F5DGLMj+NvBG3LliTsQ4Yr9vZPjDWoZlYfe3HQpWZYIRNY1o7MCnqbUo3sp4S/3O10cagSDZ8E5Jxjhy1h0DjvvX37eo2BVUPeZoFexoVNJPaWRMEpk5wuvO7biXCbz1hLQn6yBJwbZMojErl90HVuU/Zp7ggzvY5FE5jI91L2c5F3oxPrm2vZ16lU9qE2woKRRtCs9S2qzwmoRULHlCSPJB//ve/J4unIjR1TAQZxIerEo4R2EUeeo3W1mcxojwa3oLaT7uEPAtTbBQ7PjTxhsp3EKhmMaE6MOzWd/NIxc1A5rdTZAjkNHG4JRKr7SAA4GIryh0MHKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OLsz3NEwKmsKKvJLseP7Ov0/1HjucUE88kb28x4SLxY=; b=WkR52MI0ps44gU3w7hcVoskROpiKLICNTj+XOOEz6zxnn26iVfRqpnBV6MPJokxhLw/OnKdNG724JMaUlgmReh/sX4ETMsPRe3ftbWAg9OiaSWgy6nYTC+fg8jmjdY7lnGrDwFeo9RrriCD7C14BsIfUegJsWcHtBgbnNgv/ONyRsbzU70v6m8DTPOxLAPFoMp3DIabibB3k8U64RNPExB1wmP3wj/FjfBT6uszYExaSElgIJ9jBEbooMD/1VInvqKVZbIMbf3U3lrCWJrErtS0mzhnZ+Om8ztqTa0Bgf+O7zL32GJbhpqxCODzs8vA9gkZuneW8p68brrV+HqwJCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OLsz3NEwKmsKKvJLseP7Ov0/1HjucUE88kb28x4SLxY=; b=ZewNQAD1fY7UQL9j66n+IcZ6Bn8+OPvFS29e3vxHtJqZbv5ry6tiZGVi7lDACdokkCD+yE6RGlxkRa83yO10kljez74loqkgGpnG02QuidBYHHZjntX7zQb7emnpWHh08XYOAsvTY/VtLKmXSNwcdQKRYEoOvRktKEz4QIuv4So= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) by MWHPR11MB1294.namprd11.prod.outlook.com (2603:10b6:300:2a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Mon, 6 Sep 2021 11:21:34 +0000 Received: from CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::6458:1368:f535:f287]) by CO1PR11MB4868.namprd11.prod.outlook.com ([fe80::6458:1368:f535:f287%9]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 11:21:34 +0000 To: Akhil Goyal , Declan Doherty CC: "dev@dpdk.org" , "mdr@ashroe.eu" , "konstantin.ananyev@intel.com" , "vladimir.medvedkin@intel.com" , "bruce.richardson@intel.com" , "roy.fan.zhang@intel.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "abhijit.sinha@intel.com" , "daniel.m.buckley@intel.com" , Archana Muniganti , Tejasree Kondoj , "matan@nvidia.com" References: <20210713133542.3550525-1-radu.nicolau@intel.com> <20210903112626.304692-1-radu.nicolau@intel.com> <20210903112626.304692-4-radu.nicolau@intel.com> From: "Nicolau, Radu" Message-ID: <42fdee36-53fd-340c-7e19-14e6972bd8f4@intel.com> Date: Mon, 6 Sep 2021 12:21:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: DB6PR1001CA0037.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::23) To CO1PR11MB4868.namprd11.prod.outlook.com (2603:10b6:303:90::19) MIME-Version: 1.0 Received: from [192.168.1.12] (109.255.186.106) by DB6PR1001CA0037.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 11:21:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 17dd164d-7ff2-4112-effc-08d971287c3a X-MS-TrafficTypeDiagnostic: MWHPR11MB1294: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wMh3DTsHwKr15lJD9oigvtS0HrBmHvYK5uAT/riY93P25AEsYY0WnJG6i3Wb+VdLOJSCwdG9DFHEALHF9d4+nKkeyg16IW48GpJMVzjS2H53505+rktii6AOoeuCiWP5ewdlk0GOzJ+kt/JADugpm+x7Ndbtpg4DECqfqb3bsHKKIUUX/THx1LheIhdK+97fdIUE/9iMz2T+DUMp9iA9cqm6gmJ1FnVXUbpB6J2KTsyT0hspFQWML2VGqX/wFLCKsS9wcjvO4lqCihcZzZwJO3Erp02VsvHYxx14u/TwyVQezzqrj60CuzQFcsLNUrSbqhkYe1Gje7VcgYoKzGNCfBxAk6vfzWsHxhBq3bYXbe8f9zEqje1J8JIk/YR9fWiMcv3eVY3m9EKvDBJe+svowT9RQFCW8fnbomC7YY9U+FlDR+BVTAEZ6WjGFa+Zhv9tBMMN8OrNRSe79WEiD7y3QN+bomvsrz3/9JKHaqbOAiofMrMj+aznoomBy3B5T+b7tNAxnIxERxfnePLQwEHbvT9wTKZwWd7G9Qr1Wqpn7UXRHvtIJkL7aYqAggK7ecS4reQOFjOK9foBL8WhIXrmxXiFLTTEx2u1VNaH0p9w4HREKryuNFMAY9pBPMFeH663PAkwuJyUG7hd1rt2GYjqbR0TSVWQtz1TjHEeK4BMbXUFpUCt3zHXQ2cCIgZqjP2aDPrN73Q1F7F/xU6Z2ruI/VCqYpCTDbzbGXjBDW3psx3z2hwuRdGOK54Nw8pZfzPyY8XXLMfbkEh2xe4wM5s9TBdkPZUt8+y6+9vOBVxzJmCWpKtUqq94xHumtCyoZSVc9ad2yR7t/DqeVjD5qBHHuw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(38100700002)(16576012)(478600001)(55236004)(83380400001)(31696002)(86362001)(8676002)(26005)(53546011)(31686004)(5660300002)(6636002)(6666004)(6486002)(316002)(54906003)(110136005)(4326008)(2906002)(2616005)(36756003)(966005)(186003)(8936002)(66946007)(66476007)(66556008)(15650500001)(956004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlpoOTBZZ09hdEZNVllkVHhGWE13dHQyRlJFVXZncVVCdnoycW1vK1RSUGdO?= =?utf-8?B?RUw1ekh0MGRlUXZtcklPUUt0Q214RHJNVEg5d2ZiaUhuNGsvVWNrSHViaE5W?= =?utf-8?B?RVFrRVozZ3FUMjV4N1EydUtOWFRKRzFobGZXZnhuTHBsSEVHNnYzNWtpdjdJ?= =?utf-8?B?VXRBNmdCaU1FMGxGVjJKTk10RGR3YWF2dEV2SVNrMzJCM1RCQXNTSkYzOXFq?= =?utf-8?B?Yms0eTdSa1ZpNndJWllLUm85ZjU4TnBKUXpaSUUrdjQzY2VIeUhWNXRRSndZ?= =?utf-8?B?amxXOG05aDVmeldyWXBDSEhLZnlxMUhOanVLcFdrVkVaeWlaNHA5eUtkN1Uy?= =?utf-8?B?MXJ4YUx5UmEwWVFWTEZjcm9ocU1mTTVMdHRJTG5FTUEyV0xHKzlEOWc4d1BI?= =?utf-8?B?b3lkVXZKcGtuKytSeSt5OFNZY1Z3cFI1eHRvcHJhVVVNS0xXN2VWa083WEJv?= =?utf-8?B?MGd0OXRzZjU5NkEzSE1OT2RocVVuUVVnWXNyQVlFQ2ZnakI4YjdYOSt2TUNE?= =?utf-8?B?c2wyS2ZBQzBRMm52c2xlL1NIMTUrWUVERmZJVENZRGdqNE1jSVZWdE9hREpq?= =?utf-8?B?L2xOdlgzREVWTFFSRUc2UW1GOEw3WlNJV0s0M2gvRHBIb1grR1NzUEdhWVFZ?= =?utf-8?B?Tk5CaG9vSDZQOHQzZjM0RUhrRWM3N3dQODhWbmhTWHI3a3gyeGRKcm0xZmxY?= =?utf-8?B?aHM4VkswNlk0MDNWNjdtR05rR3QvS1dIT2l4b3ZZdUtIdnE4VFVPelRCNlNi?= =?utf-8?B?akhEL2M5c2dUVEZFOWRQZkZZV1QyckdZb0tyRmozTUF6d3AxZHgvb3k5aWhv?= =?utf-8?B?d3dtSmRjVXE5amE0SXlMMUR0Zk9MY2x6RXVmeDF3S3JHK3dXRGdzSUhxQm1v?= =?utf-8?B?K0pmQWZlMVpYVWEzNWMwcjkyRjV2cUxMN0FMc1BwMXVrSVVCY0F3MTl6QnYr?= =?utf-8?B?ZTBMVmdrcm56dEc1Wk5UcUt1czRxRkx0YVFQVUV6bWcxQVNjbVBpdFY4eG4y?= =?utf-8?B?ZHY2T2JJWkNsVWl1QmdQaGVSVmI2YzV6K0dVWEprZitTR0UrSUdadSt6bkph?= =?utf-8?B?TXhnYmZ2OVVXR3lVWG9kOGZtcGNtMkN3ZlRTeHAvYjRNMnVwclRuVGk0bFNR?= =?utf-8?B?d3ptOUQ3WFRRUFV4TUdsVEpGRE1NUll4L2p1Wm5aN1hqRE1vTDg4aWE1Zyt6?= =?utf-8?B?eWpCVUhVdFEvd1pjOS9ldWFISzFSdmNGWkkrRHRoczNCSVhhb0hVR0h3NUFo?= =?utf-8?B?R1dJRU1SMXdKSjlYM21yYlMrNk1YS29mdzRZYm16TU8vRi80Nlp1c1ZDbzdT?= =?utf-8?B?TjZuQlRrTmdUTVNUZUwxbVRyU2R6ZmhVTTFjaW02akV4cGZWbGJPb2FzSlRQ?= =?utf-8?B?dU9lU0xySk1KS09VdzdTWjFMalV4Ry9zTFdaYktzZlhCaHRUUTdxcWlCSGo3?= =?utf-8?B?RjJKSE9mVSsxNG1POVJBeWUycnBsVmxYNTVGZUFpdnlwQlQ5ZGJiWGhqY1ls?= =?utf-8?B?b3Flc2w5QkJFdHFoNm5tcnhtdUEzaUZ1TlV6NXFJVEVsRUpCbjFsSmlzYWJL?= =?utf-8?B?TGRTUVdrUUc0eWNNSlUzbGtKaFpDNUNQYml0SXNsV054dG9MRWNoalZDVk9J?= =?utf-8?B?WDRtSGx4cUwxckttRzJFRUlGQWxzNEFPQ2VPTXZpZkRVTkozQ1lzbHhMREE5?= =?utf-8?B?R2thRjBubmxha0JYc3ZxOGxldGZNT0FSYXRqQk9YUE50WW5XSkxWNys4R0pF?= =?utf-8?Q?lITHt1tVYZvRt1+AQWr0JeNKPtNwgWtKqEK+aGZ?= X-MS-Exchange-CrossTenant-Network-Message-Id: 17dd164d-7ff2-4112-effc-08d971287c3a X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 11:21:34.7867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EE2NuvOjoFiywRSJYpDKXGIvG4cnMZUFaFNQtw4NEz+glbbGi09AXWRGNXNUjxjv4M85z17EzOHVyluJqyZ6gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1294 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH v4 03/10] security: add ESN field to ipsec_xform X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/5/2021 3:47 PM, Akhil Goyal wrote: > Hi Radu, > >> ---------------------------------------------------------------------- >> Update ipsec_xform definition to include ESN field. >> >> Signed-off-by: Declan Doherty >> Signed-off-by: Radu Nicolau >> Signed-off-by: Abhijit Sinha >> Signed-off-by: Daniel Martin Buckley >> --- >> lib/security/rte_security.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h >> index 03572b10ab..702de58b48 100644 >> --- a/lib/security/rte_security.h >> +++ b/lib/security/rte_security.h >> @@ -240,6 +240,14 @@ struct rte_security_ipsec_xform { >> */ >> uint32_t mss; >> /**< IPsec payload Maximum Segment Size */ >> + union { >> + uint64_t value; >> + struct { >> + uint32_t low; >> + uint32_t hi; >> + }; >> + } esn; >> + /**< Extended Sequence Number */ >> }; > Can we use the following change for monitoring ESN? > http://patches.dpdk.org/project/dpdk/patch/1629207767-262-2-git-send-email-anoobj@marvell.com/ > > I believe ESN is not required to be set as SA parameter, it is normally > maintained by the PMD and application should be notified if a limit is reached. > > Regards, > Akhil Hi Akhil, I suppose they can be complementary, with this one being a hard ESN limit that the user can enforce by setting the initial ESN value - but there is no requirement to do so. Also, this change doesn't need explicit support added in the PMDs.