From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB15CA053A; Wed, 5 Aug 2020 16:27:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C9BA12C23; Wed, 5 Aug 2020 16:27:12 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 7A9E32BF2 for ; Wed, 5 Aug 2020 16:27:11 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 17D945C00D1; Wed, 5 Aug 2020 10:27:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 10:27:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 09tOu5c4lvU5XKjQ5Q+T+6xUmsMj8QcygQBotlsJ5fc=; b=VA+O120SVBI1k8Hd lRZM+pwwcYBSEeZAnc1Ox5FG14xn5ar2cNrBphhB1Eliqb1m/5a3tDxJQYKhNu+L anmf9pB9QgvOv/qZaptcZD42xPhuzBlZxWM26R95aziDTwbdvFbU0IG/zN4ehdwk L3K1G++icygsJiQA7cjVuita/3kUNDuVfC4jJe9RBoEclnsaxgO6hdelrpMlJrYb oU+uNfFGV+UFKXvr6km9OVifhzuzPCjBWHiNR069PMMyfKQxJCufaNM/iYo+OkXg TKMcp62rPmYPrvBOwzCUHVb674mOuGHMfzwwr9uTKg9MxuXwfkdYknOGNBJLHQ38 8EPtfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=09tOu5c4lvU5XKjQ5Q+T+6xUmsMj8QcygQBotlsJ5 fc=; b=rK5TsVvpu321+fsL17ykStsLR+jq/hHnaCdOxdocG/HkB64jNVm7gQ8Gt GqNm9G8GuBNWTEMhbAnWGHEMKAYhBMnCWShLc+ynDdKVznaUSmQ5D3zRrxHhyszd Z41QDYBaHu6UHG171o/j7WqBF0o5qywhTQyrlHcZMUM1NvPMIK2CK8apehpvfSjS 6UxhSgte0UrrhGYue0gL61/02dKOye02xuZYvQRhEw2/Enf94+6l54V7keUScRSK 7Zz/ibuhQJtY9je0i8r1xZscAOKx72BeFYEX4+IbQk1OwxjU9kYd2tUJFw/3QsQH CXE+BwFEE7pCvSE75ZVikUY8PCm3g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E28E33280065; Wed, 5 Aug 2020 10:27:09 -0400 (EDT) From: Thomas Monjalon To: Dekel Peled Cc: dev@dpdk.org, matan@mellanox.com, viacheslavo@mellanox.com, rasland@mellanox.com Date: Wed, 05 Aug 2020 16:27:08 +0200 Message-ID: <4303174.Ka3ApcF3ie@thomas> In-Reply-To: <2991040.2UnnyQe84E@thomas> References: <70ff61d3d8431aeb73ee5c5c23c87e525dc221ec.1596446316.git.dekelp@mellanox.com> <2991040.2UnnyQe84E@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix number of retries for UAR allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/08/2020 16:14, Thomas Monjalon: > 03/08/2020 11:18, Dekel Peled: > > Previous patch added definition of number of retries for UAR allocation. > > This value is adequate for x86 systems with 4K pages. > > On power9 system with 64K pages the required value is 32. > > This patch updates the defined value from 2 to 32. > > What about bigger pages? > > > Fixes: a0bfe9d56f74 ("net/mlx5: fix UAR memory mapping type") > > Cc: stable@dpdk.org > > No need of stable@dpdk.org because it was introduced in this release. > > > Signed-off-by: Dekel Peled > > Acked-by: Viacheslav Ovsiienko > > --- > > drivers/net/mlx5/mlx5_defs.h | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h > > index e5f7acc..c26d5a2 100644 > > --- a/drivers/net/mlx5/mlx5_defs.h > > +++ b/drivers/net/mlx5/mlx5_defs.h > > @@ -202,9 +202,7 @@ > > * UAR base address if UAR was not the first object in the UAR page. > > * It caused the PMD failure and we should try to get another UAR > > * till we get the first one with non-NULL base address returned. > > - * Should follow the rdma_core internal (not exported) definition > > - * MLX5_NUM_NON_FP_BFREGS_PER_UAR. > > */ > > -#define MLX5_ALLOC_UAR_RETRY 2 > > +#define MLX5_ALLOC_UAR_RETRY 32 > > It is missing a comment to explain the calculation with 64K page. It seems getting reasons for this magic workaround is not trivial. Applied, thanks