From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 819F8A0546; Tue, 6 Apr 2021 20:53:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 111E8406A2; Tue, 6 Apr 2021 20:53:00 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id CDC844067C for ; Tue, 6 Apr 2021 20:52:58 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 303695804E2; Tue, 6 Apr 2021 14:52:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 06 Apr 2021 14:52:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= P4QoZvvyKhT6OdM5k2SbKqVDMjnIYQJ44Xegc5F4EcI=; b=f/F6r4SC8oWpqnz+ 48UgVLAIZS/aVshCX0jQBS4fbOwLhL5SBfAYxIepoIm94hxZGNUvu71cgBWCAyK2 M3WGxNYU0EPnEgloB1Qt0welm5BPwC/4FNpsAmm1AXxwuD0jQwpMCxoMI6UbCo+K x6LP2VbtTvGx8BNuopEXEeLbHZ4v4nBN0Lt/l4JUFYWopYqXJLSnbS6PPCeTj3RU UfZ0IS9loG5L/z6II3Vtlva9EIQSeQHwj8GkEQQ6tgAb9E/Hjy4U2dwIhfB+xOEA a7sk0Psgby2xbQ74BX+fHuUBcWuPl3xwsNSujupYDECEDblekCJyjeuT/rES5dDf vsjQcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=P4QoZvvyKhT6OdM5k2SbKqVDMjnIYQJ44Xegc5F4E cI=; b=vnzDIgzKh/y8ZXTbDmNYK+2kyG0Ur819BMPEBN7PbBvkZJBOFXJH2aibX HMhHaC4zfWZGlOXoadav3MgcaBk+yLgK+0AKUa8BdhD/cKwEOUtA8difIW247A0H H99kQcZgcO1KGDzgeyW216WBZT3fv1F5ki7i2xDWnefwulSh0T5i1Xf6uFnTAewg lqsl/50/r0F39pHZzZI0SptObvJSsI6cKrcJoyr5r4IWYgzmlelHrmCN5IKFCHPS kHloWEU8y0PPSZSmNdmz1IdCT9zGuXQxc6D3MQ5nUApfldbsY2fghmYoUm8yxwVM wVItznMHHEEbGigAayZjVdLPwRZ4Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejhedgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 24B60108005C; Tue, 6 Apr 2021 14:52:55 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, bruce.richardson@intel.com, Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Ray Kinsella , Neil Horman , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko Date: Tue, 06 Apr 2021 20:52:52 +0200 Message-ID: <4303766.JfoNgE5a7G@thomas> In-Reply-To: <20210406175910.24450-1-david.marchand@redhat.com> References: <20210406163231.19663-1-david.marchand@redhat.com> <20210406175910.24450-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" About the title, it is not a single file but one file per lib/driver. I think it would better convey the idea by saying "remove .def files". 06/04/2021 19:59, David Marchand: > Rather than have two files that keeps getting out of sync, let's > annotate the version.map to generate the Windows export file. > > Note: Existing version.map annotation achieved with: > $ for dir in lib/librte_eal drivers/common/mlx5; do > ./buildtools/map-list-symbol.sh $dir/*.map | > while read file version sym; do > ! git grep -qw $sym $dir/*.def || continue; > sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" $dir/*.map; > done; > done This patch keeps the exact same behaviour, right? There are a lot of symbols in EAL and mlx5 which should be exported for Windows too, but it is open for future fixes, right?