From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5026FA0569; Thu, 12 Mar 2020 09:05:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26C311C036; Thu, 12 Mar 2020 09:05:31 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 29C6A1C02A; Thu, 12 Mar 2020 09:05:29 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A717C2235B; Thu, 12 Mar 2020 04:05:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 12 Mar 2020 04:05:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Rts9HtlppTk/DQh2Soy6GCkuGR1AdgFqktMnVgq9isE=; b=ci7vyUKKUJjT zVk9NGIPppBLFwJAK4AnYubCyR4O+d0qqpUZIXR9XE5EhAzuUy9CCQVXEnxpW5V3 cgnbtZPlWGFfOckSpafQUichTMmgsDt76Au5JNc/2JQscK398ivCZUlngycO4ERf oYJ+wD0X+KDLGVl48/VJGlqCSukA71g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Rts9HtlppTk/DQh2Soy6GCkuGR1AdgFqktMnVgq9i sE=; b=EHXU3ebjrxhfEyXQC4gQJkFAYh2kvvzUyE7L1D+Kh0s91gXtIrRaXw8aK u6xr2H0ZbYtJlQI3542NV5DADHZkreXOz4ohqplzPuwUVZF+npagiwaFQVjonPjK 838xUmMByGI5YSkdem8EQA4HHaKDLQss0PCBMjFJTS/ct/OfGVgNcQimPsWa5fQj 4LczxfjlLQJqtCiB5wgFtU+EFmSOy8uamV4ZosSDf8YkWcXic5e4ioP9qa4/38Yg 7P95Y+mNit+2W4owXPIVMAHVfzAucfXsW55MPtmSMp34R7tPVh6DqVYg69U1eaXN gqfVDCNzRZe+oHCf/6fKp8C4Wb/Vg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddvgedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ffohhmrghinhepghhnuhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg hssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7F9763280059; Thu, 12 Mar 2020 04:05:27 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: stable@dpdk.org, roy.fan.zhang@intel.com, pablo.de.lara.guarch@intel.com, bruce.richardson@intel.com, Declan Doherty , Luca Boccassi , Akhil Goyal Date: Thu, 12 Mar 2020 09:05:26 +0100 Message-ID: <4305448.CvnuH1ECHv@xps> In-Reply-To: <20200228132547.650594-1-thomas@monjalon.net> References: <20200227223326.507857-1-thomas@monjalon.net> <20200228132547.650594-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] drivers/crypto: fix build with make 4.3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/02/2020 14:25, Thomas Monjalon: > In the check for the version of intel-ipsec-mb library, > there is a backslash in front of the #include. > This backslash is for escaping the hash sign parsed as > a number sign in make. > > Since make-4.3, escaping is not required for the number sign. > As a consequence, it resolves now to '\#': > > syntax error near unexpected token `|' > `grep -e "IMB_VERSION_STR" \#include | cut -d'"' -f2' > syntax error near unexpected token `|' > `grep -e "IMB_VERSION_NUM" \#include | cut -d' ' -f3' > > The makefiles are fixed by using a variable for the hash sign, > as recommended in make-4.3 changelog: > https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00004.html > > Fixes: 3067c8ce77ac ("crypto/aesni_mb: fix build with custom dependency path") > Fixes: 457b8e372975 ("crypto/aesni_gcm: check dependency version with make") > Fixes: bf6eb2c22fd1 ("crypto/kasumi: use IPsec library") > Fixes: 7c87e2d7b359 ("crypto/snow3g: use IPsec library") > Fixes: 61f7c988e39e ("crypto/zuc: use IPsec library") > Cc: stable@dpdk.org > > Signed-off-by: Thomas Monjalon > --- > > v2: > - found the root cause in make-4.3 > - use $H for compatibility with make < 4.3 > > Note the list of "Fixes" references are here to help backporting, > even if there was no bug before the recent release of make-4.3. I was expecting some reviews and a merge in the crypto tree. Given it is blocking me to merge any other patch, after waiting 2 weeks, Applied in master branch.