From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 4A0B31B311 for ; Tue, 13 Feb 2018 23:20:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EBBA421304; Tue, 13 Feb 2018 17:20:56 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 13 Feb 2018 17:20:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=DB1WFPQjtdT+J6WZQ4KGlHm/lA My6E5VA9mDn2lSC38=; b=m5rBJDg8yhTHETSTSmXOZed+TptUYePQK/sdqd7VMk AULKPogYjKRwpaRUtaP0Rd+XU7kDDzYFYzs8vT1lEf/DGPA+Skxs5cn3uirxXpSY B5f7Kpfa6c/XYD/YWhfu9/sIjHZ9vr0i07i6cdZfRD3OVyEkXttE/zv7RmBlqOBL s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=DB1WFP QjtdT+J6WZQ4KGlHm/lAMy6E5VA9mDn2lSC38=; b=Erq7buZHYkizXEJTIS5S94 VcbwT2wU2+YYxMZWtfkGp0jRtn20Hp6v9/1VuXNoolX4/A3CsuNilvwOGFFA6mDh yAA4k9vFZMfxATVynTWLRrX2gPI8KNTzFer7bRKElcr9u3y0FLfN2HxUMvjy7eVv yfBebx93rl0Sr0rzs/r9TCz4RBVhWVFU8dPwsYTX1s9smZs9vYKSJGUa941W4tWs vU3hM6o8YiGR7DtTPAO5vLlqwfvQZQTQ59au3b58AnEUHlKeRezN3eFW0ci1sT0I 3kfCSLxj1/cnvwm9GUkceCWuco6gypgSiFX7ZxoDbucPRWF3UV5OS4NrGQUQaw9g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 94A54246D5; Tue, 13 Feb 2018 17:20:56 -0500 (EST) From: Thomas Monjalon To: Matan Azrad , "De Lara Guarch, Pablo" Cc: dev@dpdk.org, "gaetan.rivet@6wind.com" Date: Tue, 13 Feb 2018 23:20:46 +0100 Message-ID: <4305556.A2Klv6Z1yo@xps> In-Reply-To: References: <20180213213312.22225-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: fix FreeBSD build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 22:20:57 -0000 > > > The type pthread_t is not portable because it is freely defined. > > > On Linux, it is an unsigned long int which can be printed with %l. > > > On FreeBSD, it is a pointer which can be printed with %p. > > > > > > That's why there was this error: > > > drivers/net/failsafe/failsafe_private.h:377:53: error: > > > format specifies type 'unsigned long' but the argument has > > > type 'pthread_t' (aka 'struct pthread *') > > > > > > Fixes: 655fcd68c7d2 ("net/failsafe: fix hotplug races") > > > > > > Reported-by: Pablo de Lara > > > Signed-off-by: Thomas Monjalon > > > > Tested-by: Pablo de Lara > > > Acked-by: Matan Azrad Applied