From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B3B442421; Wed, 25 Jan 2023 14:55:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F16842D3E; Wed, 25 Jan 2023 14:55:18 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 4C26C42D31 for ; Wed, 25 Jan 2023 14:55:17 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BE5325C01AE; Wed, 25 Jan 2023 08:55:16 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 25 Jan 2023 08:55:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674654916; x= 1674741316; bh=RwLSoXnlzuY08kWmSip0gJK27t5RjeFs/VFIdSIsb14=; b=W 42LFjjqPbIrrD5o56HUlXERIJlbCcgtZthlaipkaaZiBVaev276eP9AGAaicuWj3 Raz7NaW/XqLak6hhexMgIjYFO+cBbKVgqjgCJYx5JgVmt7CwZzTQpUjI0Usu8PqD N2+s1xEUsbiHXXc7HtH7HEaiPb/D7UPMpPScdy/VOZKUABnvsPVr0WTP3y41GFR7 3DP2vBzXzDFNJQA1uIX6U0ZD5vvkV7To4Tkfr8NkY1KtohNyeEEQxzAYEfbWXL1R enxn7QzZ0wv6Y2WBCxZu/r44XrxtJEg8Vj/PIdcrtu6WSEy2vSEDd7UBMX1SN2FU EAKRLhtKpKiqgBN4ola1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674654916; x= 1674741316; bh=RwLSoXnlzuY08kWmSip0gJK27t5RjeFs/VFIdSIsb14=; b=g i8ExGqwyYAW52hcDEN2vnzJsL540zx7uZkbkay6ftMZa0UMIcLgfLHMcjGbnCB7d vN8DZvI37WkEAUSAo5wUpV50fyHrwpW28NRYXiVW1dNlzsq8OSesMOm15kNYbYVq +F/romChStlMUELQswYk/ocXEL43/k7L0Na5k+abCGqDVn8bq2bg1Ei/14fLhyN1 /d1G2cUV5TsXDmBJh7c3uyvtA9RK1q8FOAIDUQfGI6NIqZb1WbdX+vKRKpds8/zn o75D4utyhOGynpRZEc2AKQEpJm7jq/sn4CZa+nhV5h4kst1m2xtjqPpAucbzirp/ r7OwKKWQOOQ9VkLjajeaw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvvddgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Jan 2023 08:55:15 -0500 (EST) From: Thomas Monjalon To: Shivah Shankar Shankar Narayan Rao , Srikanth Yalavarthi Cc: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Anup Prabhu , "ferruh.yigit@amd.com" , "bruce.richardson@intel.com" , "david.marchand@redhat.com" , Srikanth Yalavarthi Subject: Re: [EXT] Re: [PATCH v3 0/4] implementation of ML common code Date: Wed, 25 Jan 2023 14:55:14 +0100 Message-ID: <4307135.zXnORWrf4K@thomas> In-Reply-To: References: <20221212172108.17993-1-syalavarthi@marvell.com> <3276296.f0I1acK8xe@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 25/01/2023 14:25, Srikanth Yalavarthi: > From: Thomas Monjalon > > 20/12/2022 18:52, Srikanth Yalavarthi: > > > This patch series implements the common ML code that can be used by ML > > > drivers. Common code include functions to convert ML IO type to > > > string, IO format type to string, function get size of ML IO type, and > > > functions for converting data types from higher precision to lower > > > precision and vice-versa. > > > > I'm not sure about the path of this code. > > In general we implement drivers helper in the same directory as the driver > > and mark it as internal. > > Would it work here? > > We are planning to implement two different ML drivers, ml/cnxk driver (submitted for review) and a software only driver (part of ML roadmap and currently WIP). Both the drivers would be using these common functions for quantization and dequantization. Hence, placed the files in common/ml directory. > > Moreover, these functions are used to convert data from higher to lower precision or vice-versa and can also be used by future ML drivers for other platforms. I understand, and what you say does not contradict with having this code in lib/mldev/. So would you agree to move?