From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC544A04B6; Sun, 11 Oct 2020 22:52:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB1E71C225; Sun, 11 Oct 2020 22:52:13 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 8ABC81C20E for ; Sun, 11 Oct 2020 22:52:12 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 70D2DDF2; Sun, 11 Oct 2020 16:52:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 11 Oct 2020 16:52:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= t066QBm1q45f9QGP8ZBmtLUcnVVZkupQorXvtbxIKUE=; b=Ws/edOBLbNe80r7R iQ+WnGExqtIhbjwntrnM38oJmxZ4twgBvF/8ylIgRF2iUYbsq/WaMefKKlHmtoKE 6IHLW2YjWCqA6H2HtBsnvuGmcKmMQiZ/+rwYCEdRvidZWko+ducxqwZUuP+5HIv5 cizcAdJRDZLw7obrqxJ/YTayUmwnqHSZ473jR7Duy3nOwgleQW8p4QG9/xnlrZNV PagFk3OMqQx9T3uodFoePA84aJYtpgghKWsPjEVYCxIe226U0dHwip5h+zUDvrCQ Qr9RtWzS2vWSozHffAKvVGtTPMik+2Phan3GgqBQxjF81TZ70/x5ik8ZGoDoHVf/ gozT8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=t066QBm1q45f9QGP8ZBmtLUcnVVZkupQorXvtbxIK UE=; b=I/b4dJJ3P28LCbgg13hZ51pH7TXVdAfhXkhHNEw6ZStviths6gTbwsfnB Gkj2Ue0wyF/kHkSXyfLoKPEEE9taXA0I/5LSPUqA+228tEWaZYhfP6nJ1psUUVYb rK7jFpvXli94O9cUSwKOJvBGB/fwkOP/aud/feOBCgWPZn7aubpVeBWqaXVGyXB2 XxJ+MGr5847QxGvNpWKxsiSUbnmcaQQ84fKcz53X0gctOg+WuFPnFGdcWP2s/3dD lz7FruVgE+Oss42m/PP9z9UCpamsqU/6k4JzPLhGz3Dui2Bu6aPNt7CfXM/5yENK 2UQmilU37y+j5Vrq/GbNan3Im8pbg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrheehgdduheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 474EC3280064; Sun, 11 Oct 2020 16:52:09 -0400 (EDT) From: Thomas Monjalon To: Ciara Power Cc: dev@dpdk.org, Louise Kilheeney Date: Sun, 11 Oct 2020 22:52:08 +0200 Message-ID: <4308846.mfECYFcHTo@thomas> In-Reply-To: <20201009102140.20730-13-ciara.power@intel.com> References: <20200807123009.21266-1-ciara.power@intel.com> <20201009102140.20730-1-ciara.power@intel.com> <20201009102140.20730-13-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 12/14] doc: remove references to make from contributing guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/10/2020 12:21, Ciara Power: > - As in the linux kernel, the ``CONFIG_`` prefix is not used in C code. > - This is only needed in Makefiles or shell scripts. > +* Use build definition macros and conditions in the Meson build file. This is done when the differences > + are more significant. In this case, the code is split into two separate files that are architecture > + or environment specific. This should only apply inside the EAL library. When writing new sentences, it's better splitting lines after a punctuation, preferably the end of a sentence. > Per Architecture Sources > ~~~~~~~~~~~~~~~~~~~~~~~~ > > -The following config options can be used: > +The following macro options can be used: > > -* ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture. > -* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures. > +* ``RTE_ARCH`` is a string that contains the name of the architecture. > +* ``RTE_ARCH_I686``, ``RTE_ARCH_X86_64``, ``RTE_ARCH_X86_64_32`` or ``RTE_ARCH_PPC_64`` are defined only if we are building for those architectures. This is out of date. Arm is notably missing. > Per Execution Environment Sources > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > -The following config options can be used: > +The following macro options can be used: > > -* ``CONFIG_RTE_EXEC_ENV`` is a string that contains the name of the executive environment. > -* ``CONFIG_RTE_EXEC_ENV_FREEBSD`` or ``CONFIG_RTE_EXEC_ENV_LINUX`` are defined only if we are building for this execution environment. > +* ``RTE_EXEC_ENV`` is a string that contains the name of the executive environment. > +* ``RTE_EXEC_ENV_FREEBSD`` or ``RTE_EXEC_ENV_LINUX`` are defined only if we are building for this execution environment. This is out of date. Windows is missing. [...] > -* Generate all the documentation targets:: > +To enable doc building:: > > - make doc > + meson configure -Denable_docs=true No need of this option. "ninja -C build doc" works even without it.