From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com
 [209.85.215.54]) by dpdk.org (Postfix) with ESMTP id 151F3569F
 for <dev@dpdk.org>; Thu, 15 Sep 2016 16:05:58 +0200 (CEST)
Received: by mail-lf0-f54.google.com with SMTP id u14so38365358lfd.1
 for <dev@dpdk.org>; Thu, 15 Sep 2016 07:05:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=TunrD5gOssY9siihjLYh/qvs6ybhFoVdlZ5iCjnjXks=;
 b=KaWCpyx8KYKWvqvL7H0UdKKAEPCZU279Z/5a9wup60QZxysWAyyppTX/bHQiTD6Cts
 mRJROTAvdrF1mvx/pdqrYKgA7Hs0eXFbjAWqJ+WAsUHmxTnocUooDjAZsOM3nQZ8Bc56
 /D9Fq5ShsXR0SOISngV6e3q+e3wXWCAZ+ssQcyT1gNzh+HAnFx2y2HukUeIZRkbOS5kb
 zFNwvLULr/RXXZLTjAvdWOLi3n/AXLKr+XylNQ+/afvF1X8SW2F/j/MQ7YkVcXLN0DQu
 kJGEbES6KvtkRPpLoDVHCl++zKxH9HxUe2MWKVEM5Wegh/bK4C+mhed/l4lM9uSgOJZT
 DP1A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=TunrD5gOssY9siihjLYh/qvs6ybhFoVdlZ5iCjnjXks=;
 b=VPtU8pPhxKi9E1tsczav2+MCQxIGpyRwzPTw90uvOPswlx6LVRMpD3QqknFpfJev1B
 hXxjSns0FQkO6Ud+FfGaOAjU80SET5Nh4ZUDsEn8gqtpPfMs6suomWK+jSG3unRXjSY5
 fBvyWhri2b3HCUeFI/ZSFkMNT15RGDsYzM4NvWW5YlDxlE0YZRizEaKTTWMIJ/M4wrO6
 3AlAgXzLgObr+CWhtByzPJT7FfJP6APxas1kSeEtTMgI42CicGEQkK3VnmHjhnDWt5wf
 ZSBuGolsXpbFr4r9XlHwngeHDNf64lAyoVPR927rCch4uRQ3BNXtt1se9FLGnwqtj+do
 Ap6A==
X-Gm-Message-State: AE9vXwNXuBw/JdDMftQuW8nFeO3UoE8FFniL7PFoHr9ybXoHVZh/ZpIaWeMQ9DAI3L2kCvae
X-Received: by 10.28.169.66 with SMTP id s63mr579090wme.122.1473948356925;
 Thu, 15 Sep 2016 07:05:56 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id i127sm2643826wmf.4.2016.09.15.07.05.55
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 15 Sep 2016 07:05:55 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Hunt, David" <david.hunt@intel.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: dev@dpdk.org, viktorin@rehivetech.com, hemant.agrawal@nxp.com
Date: Thu, 15 Sep 2016 16:05:54 +0200
Message-ID: <4310538.hvdbegMmPc@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1378dc00-7fa7-6679-1118-5992cfd1adfd@intel.com>
References: <1451682326-5834-1-git-send-email-viktorin@rehivetech.com>
 <1473410639-10367-13-git-send-email-shreyansh.jain@nxp.com>
 <1378dc00-7fa7-6679-1118-5992cfd1adfd@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 12/15] ether: extract function
	eth_dev_get_intr_handle
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Sep 2016 14:05:58 -0000

2016-09-15 14:02, Hunt, David:
> On 9/9/2016 9:43 AM, Shreyansh Jain wrote:
> > +static inline
> > +struct rte_intr_handle *eth_dev_get_intr_handle(struct rte_eth_dev *dev)
> > +{
> > +	if (dev->pci_dev) {
> > +		return &dev->pci_dev->intr_handle;
> > +	}
> > +
> > +	RTE_VERIFY(0);
> 
> Rather than RTE_VERIFY(0), might I suggest using rte_panic with a more 
> relevant error message?

RTE_ASSERT is preferred.
We must stop adding some rte_panic calls except for debug.