From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 96D021B861 for ; Tue, 5 Jun 2018 15:39:10 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE495FDC7F; Tue, 5 Jun 2018 13:39:09 +0000 (UTC) Received: from [10.36.112.33] (ovpn-112-33.ams2.redhat.com [10.36.112.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F4BE217B400; Tue, 5 Jun 2018 13:39:08 +0000 (UTC) From: Maxime Coquelin To: Tiwei Bie Cc: zhihong.wang@intel.com, dev@dpdk.org References: <20180601124758.22652-1-maxime.coquelin@redhat.com> <20180601124758.22652-4-maxime.coquelin@redhat.com> <20180604115903.GB21406@debian> <9efa2c4c-a391-49d1-2444-7c1a70468a71@redhat.com> Message-ID: <4310f98c-2a1a-933b-ee6c-d9620dcf5166@redhat.com> Date: Tue, 5 Jun 2018 15:39:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <9efa2c4c-a391-49d1-2444-7c1a70468a71@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 05 Jun 2018 13:39:09 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 05 Jun 2018 13:39:09 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH 3/4] net/virtio: don't use simple Rx path if TCP LRO requested X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 13:39:10 -0000 On 06/04/2018 04:32 PM, Maxime Coquelin wrote: > > > On 06/04/2018 01:59 PM, Tiwei Bie wrote: >> On Fri, Jun 01, 2018 at 02:47:57PM +0200, Maxime Coquelin wrote: >>> Signed-off-by: Maxime Coquelin >>> --- >>>   drivers/net/virtio/virtio_ethdev.c | 3 ++- >>>   1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/virtio/virtio_ethdev.c >>> b/drivers/net/virtio/virtio_ethdev.c >>> index 5730620ed..d481b282e 100644 >>> --- a/drivers/net/virtio/virtio_ethdev.c >>> +++ b/drivers/net/virtio/virtio_ethdev.c >>> @@ -1893,7 +1893,8 @@ virtio_dev_configure(struct rte_eth_dev *dev) >>>       } >>>       if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM | >>> -               DEV_RX_OFFLOAD_TCP_CKSUM)) >>> +               DEV_RX_OFFLOAD_TCP_CKSUM | >>> +               DEV_RX_OFFLOAD_TCP_LRO)) >> >> Maybe we also need to consider not using simple Rx >> when DEV_RX_OFFLOAD_VLAN_STRIP is requested. > > I think that makes sense. And also the same for Tx when VLAN_INSERT is requested > Thanks, > Maxime > >> Best regards, >> Tiwei Bie >> >>>           hw->use_simple_rx = 0; >>>       if (tx_offloads & (DEV_TX_OFFLOAD_TCP_CKSUM | >>> -- >>> 2.14.3 >>>