From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 37D617CAC for ; Mon, 1 May 2017 00:59:57 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B30F820744; Sun, 30 Apr 2017 18:59:56 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 30 Apr 2017 18:59:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=GqtBS3Zc21A8Sdc QyjAR8HuidBeLFNGh+JODkbF0UIg=; b=Y4ENOer/4ppTnZBpwKq2a9669HfdBwe 3DF+SYWo3nG8Sr6ZeTmnCPwmr+vKWWHTsGjHgO/fJa3qTG5H4X7vZsVaAZijsqss +2s3i8eRBSq1ZQ87/tTqqcT2E8Bkv+4V0C4Xc5yHuUThiAvMFuWk34KHphDqQISl IbG/0q7JBiWg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=GqtBS3Zc21A8SdcQyjAR8HuidBeLFNGh+JODkbF0UIg=; b=L/ukVMRP A6TRB27fTTG3d/Gd88FymXMxJflVqbr1W4qWbk+8ws+0Uh/cfJtD6WNcYV/taCNC nPsV5ZM6qjrUybplsh70BYE2yA1ztMegY2g2tNpMvhDM7lFtcttpY04ufFWVycr6 YLJj9PGgu3+giKKrGRxcSod1r6ZcZmqsDOplGJQ0B0wq79T+pfMVOnUpuOEcoRMv 21D+8u+QvCyGTWD/l7lNes1MyLivC2G5DzQf2t/BJuiew8Fqr2pSEdR5akoEBoI2 6hYKKL7XRfGEeCyaSXZqcia50Vj4hmGim5jELh97LCV0UkNy4GMjXXG0+T6Fy4vf kjMWXS3R1GQnWg== X-ME-Sender: X-Sasl-enc: LIEITB/zd1VerDUljFhVLowV1FvEe2QFBbeB4/pXzp+Y 1493593196 Received: from xps.localnet (245.114.118.80.rev.sfr.net [80.118.114.245]) by mail.messagingengine.com (Postfix) with ESMTPA id 3A0097E32F; Sun, 30 Apr 2017 18:59:56 -0400 (EDT) From: Thomas Monjalon To: Wei Dai Cc: dev@dpdk.org, wenzhuo.lu@intel.com, harish.patil@cavium.com, rasesh.mody@cavium.com, stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, jing.d.chen@intel.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, bruce.richardson@intel.com, yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com Date: Mon, 01 May 2017 00:59:54 +0200 Message-ID: <4318072.gYggGDVejI@xps> In-Reply-To: <1493525507-56304-1-git-send-email-wei.dai@intel.com> References: <1493525507-56304-1-git-send-email-wei.dai@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 0/3] MAC address fail to be added shouldn't be stored X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Apr 2017 22:59:57 -0000 30/04/2017 06:11, Wei Dai: > Current ethdev always stores MAC address even it fails to be added. > Other function may regard the failed MAC address valid and lead to > some errors. So There is a need to check if the addr is added > successfully or not and discard it if it fails. > > In 3rd patch, add a command "add_more_mac_addr port_id base_mac_addr count" > to add more than one MAC address one time. > This command can simplify the test for the first patch. > Normally a MAC address may fails to be added only after many MAC > addresses have been added. > Without this command, a tester may only trigger failed MAC address > by running many times of testpmd command 'mac_addr add' . > > For v4 patch set, have got acknowledgement from > Nelio Laranjeiro for mlx changes > Yuanhan Liu for virtio changes You have not taken the ack from Konstantin, and you have again forgot --in-reply-to, so review is hard. Checkpatch reports: ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files Please make a perfect v6.