From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B80B3A00BE; Mon, 28 Oct 2019 17:34:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 095851BF53; Mon, 28 Oct 2019 17:34:42 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C18ED1BF4F; Mon, 28 Oct 2019 17:34:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D3BDA2099D; Mon, 28 Oct 2019 12:34:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 28 Oct 2019 12:34:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=NbRTYueQQJmcTJiteBtlwJpoBFDOxgOEh0mbQ6XHvs8=; b=Nj36cHqEiN/M Uos6x3X0wisJT+2QmjHSC3kQce2Uz6+OkG72LMr0f+9kVT4REH3b7rblV48scK+t NCogI+sxCnWDF4eqpp3+mGymLeqoDsssdXxrU1Umza4pasl1ZKsPg/KSumkd1zwE Tax/YSZX0K61zHB9ZzuhetQE8bGtXOI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=NbRTYueQQJmcTJiteBtlwJpoBFDOxgOEh0mbQ6XHv s8=; b=TUDocb28UYO91mcDtiQMDganed1shr9gEj+fe+VZNC0IvgF5FhPyS/kbd 2XzpMsXvkjWXbGyQY6AdoEg8QAOMLUVQyn7Zbijg4mFDXlIDLo7qwVS4g/c4SqQL I8L4rSK/g4WQeY/zxq2v7nuEdBF6ydHjQ/V1irJsoUEylIi3oPymWuu0K3xcnulv m9vTtCp/a7EVzetmpaJy9zbuCwlgLN6yqx3zjtspB4OdxN4Ab7IPUA5VIZ+VuyWs UPlp9tTtw6L2ifbjOTeNy3n3KVBLBV0tEyNjH+sI50kDvtJLDoNNhYqSpwz4JhwS uH9HrTgfEEMPxsfzyVEC69nI1121Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleelgdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 75AC88005B; Mon, 28 Oct 2019 12:34:38 -0400 (EDT) From: Thomas Monjalon To: Ali Alnubani Cc: dev@dpdk.org, jerinj@marvell.com, pbhagavatula@marvell.com, stable@dpdk.org Date: Mon, 28 Oct 2019 17:34:36 +0100 Message-ID: <4320268.0ttSs8cEyt@xps> In-Reply-To: <20191028112535.692-1-alialnu@mellanox.com> References: <20191028112535.692-1-alialnu@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] mk: fix build on arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2019 12:25, Ali Alnubani: > OcteonTx was disabled for causing an internal compiler error on old gcc > versions. > See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers"). > > The condition that was added later to apply disabling OcteonTx > only on arm64 caused the condition to never be obeyed because it > compares ["arm64"] to [arm64]. > > This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH, > because the former has the quotes removed, while the later doesn't. > > Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64") > Cc: stable@dpdk.org > > Signed-off-by: Ali Alnubani > --- > - ifeq ($(CONFIG_RTE_ARCH), arm64) > + ifeq ($(RTE_ARCH), arm64) Acked-by: Thomas Monjalon