From: Lewis Donzis <lew@perftech.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>
Subject: Re: [PATCH] ixgbe: Removed FreeBSD forcing wait in ixgbe_dev_link_update_share()
Date: Tue, 22 Oct 2024 10:58:11 -0500 (CDT) [thread overview]
Message-ID: <432110681.9010993.1729612691202.JavaMail.zimbra@donzis.com> (raw)
In-Reply-To: <20241022083455.65cbfb9a@hermes.local>
----- On Oct 22, 2024, at 10:34 AM, Stephen Hemminger stephen@networkplumber.org wrote:
> On Tue, 22 Oct 2024 09:42:05 -0500
> lew@perftech.com wrote:
>
>> From: Lewis Donzis <lew@perftech.com>
>>
>> Forcing wait true prevents checking link status without delay, because the
>> function will wait more than 10 seconds for link status to be true.
>>
>> Signed-off-by: Lewis Donzis <lew@perftech.com>
>
> A little concerned that original patch was trying to address a problem.
>
> Fixes: 0012111a3d87 ("net/ixgbe: fix link status synchronization on BSD")
Yeah, I was concerned, too, but the fix causes a call to "give me link status immediately without waiting" to wait, and worse, it waits a really long time for the link to be "up". So it pretty fundamentally breaks operation on FreeBSD.
I was worried it would wouldn't work properly with that change removed, but empirically, it appears to work correctly. It seems like the presumption was that, because FreeBSD doesn't support interrupts, it wouldn't be able to get link status, but it does properly interrogate the hardware and provide the correct link status.
Perhaps Zhihong Peng could comment on why this was done?
next prev parent reply other threads:[~2024-10-22 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 14:42 lew
2024-10-22 15:34 ` Stephen Hemminger
2024-10-22 15:58 ` Lewis Donzis [this message]
2024-10-22 16:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=432110681.9010993.1729612691202.JavaMail.zimbra@donzis.com \
--to=lew@perftech.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).