From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6710B45BA3; Tue, 22 Oct 2024 17:58:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5774040611; Tue, 22 Oct 2024 17:58:15 +0200 (CEST) Received: from smtp-gw.pt.net (smtp-gw.pt.net [206.210.192.15]) by mails.dpdk.org (Postfix) with ESMTP id 34EC1402EA for ; Tue, 22 Oct 2024 17:58:13 +0200 (CEST) X-ASG-Debug-ID: 1729612691-09411a490e2dd9a0001-TfluYd Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by smtp-gw.pt.net with ESMTP id lIEq9Ox3QCSLeBUt (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 22 Oct 2024 10:58:11 -0500 (CDT) X-Barracuda-Envelope-From: lew@perftech.com X-Barracuda-Effective-Source-IP: mail.pt.net[206.210.194.11] X-Barracuda-Apparent-Source-IP: 206.210.194.11 Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id A4C139719F8; Tue, 22 Oct 2024 10:58:11 -0500 (CDT) Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10032) with ESMTP id fHbrBwYoWG2M; Tue, 22 Oct 2024 10:58:11 -0500 (CDT) Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 767F397190F; Tue, 22 Oct 2024 10:58:11 -0500 (CDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.pt.net 767F397190F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perftech.com; s=B15A3A56-ABEA-11EE-9719-5F12F125680F; t=1729612691; bh=8hBG/u9DH11vxayXKsH/aY+ii5KDi5gw6ErFqBWQntg=; h=Date:From:To:Message-ID:MIME-Version; b=lbgX5n+JwFL0HMU8q7etJgs3H/uZBWkOMZIVCW87N5A6B3pZJ16DWA0EMEY1e0Veg API1+CS2dKuR/eGl29kNWcoJqSKonve+RDg9QT7P3gW9r96eMiVsr6z7mLL6Vu9z4y hxmNGfgbHnx5h9Y49hmV9ocAr3uXtjjExMtpoMdZlq3BUk9p5+PtW0PRy/nIOn4H4w vvh/sz8HS92X9Ls7It2SB+rqrefpQJ3ZEdRBpyKQyN5ee8/yJW6vkX6DhzJbxIccwo zwaMOByuwU7OtGsR7mswVBX0mmdZ60XMw3477qllOOXbmcl9IrwtdZ/NvpwlgdsjEg YPfb9EvB/OE8g== X-Virus-Scanned: amavis at pt.net Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10026) with ESMTP id SsvsPC3y7pB7; Tue, 22 Oct 2024 10:58:11 -0500 (CDT) Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by mail.pt.net (Postfix) with ESMTP id 65368971B00; Tue, 22 Oct 2024 10:58:11 -0500 (CDT) Date: Tue, 22 Oct 2024 10:58:11 -0500 (CDT) From: Lewis Donzis To: Stephen Hemminger Cc: dev Message-ID: <432110681.9010993.1729612691202.JavaMail.zimbra@donzis.com> In-Reply-To: <20241022083455.65cbfb9a@hermes.local> References: <20241022144205.49664-1-lew@perftech.com> <20241022083455.65cbfb9a@hermes.local> Subject: Re: [PATCH] ixgbe: Removed FreeBSD forcing wait in ixgbe_dev_link_update_share() MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [PATCH] ixgbe: Removed FreeBSD forcing wait in ixgbe_dev_link_update_share() Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: [206.210.194.11] X-Mailer: Zimbra 8.8.15_GA_4652 (ZimbraWebClient - GC130 (Mac)/8.8.15_GA_4652) Thread-Topic: ixgbe: Removed FreeBSD forcing wait in ixgbe_dev_link_update_share() Thread-Index: hoQlCQWJ0vwBmJoaQ42HxJ2E3ooqcw== X-Barracuda-Connect: mail.pt.net[206.210.194.11] X-Barracuda-Start-Time: 1729612691 X-Barracuda-Encrypted: TLS_AES_256_GCM_SHA384 X-Barracuda-URL: https://smtp-gw.pt.net:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at pt.net X-Barracuda-Scan-Msg-Size: 1208 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.132147 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org ----- On Oct 22, 2024, at 10:34 AM, Stephen Hemminger stephen@networkplumber.org wrote: > On Tue, 22 Oct 2024 09:42:05 -0500 > lew@perftech.com wrote: > >> From: Lewis Donzis >> >> Forcing wait true prevents checking link status without delay, because the >> function will wait more than 10 seconds for link status to be true. >> >> Signed-off-by: Lewis Donzis > > A little concerned that original patch was trying to address a problem. > > Fixes: 0012111a3d87 ("net/ixgbe: fix link status synchronization on BSD") Yeah, I was concerned, too, but the fix causes a call to "give me link status immediately without waiting" to wait, and worse, it waits a really long time for the link to be "up". So it pretty fundamentally breaks operation on FreeBSD. I was worried it would wouldn't work properly with that change removed, but empirically, it appears to work correctly. It seems like the presumption was that, because FreeBSD doesn't support interrupts, it wouldn't be able to get link status, but it does properly interrogate the hardware and provide the correct link status. Perhaps Zhihong Peng could comment on why this was done?