DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] build: fix memcpy behaviour regression
@ 2020-10-12 14:51 Bruce Richardson
  2020-10-16  2:13 ` Han, YingyaX
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2020-10-12 14:51 UTC (permalink / raw)
  To: dev; +Cc: yingyax.han, konstantin.ananyev, lijuan.tu, Bruce Richardson

When testing on some x86 platforms, code compiled with meson was observed
running at a different power-license level to that compiled with make. This
is due to the fact that meson auto-detects the instruction sets available
on the system and enabled AVX512 rte_memcpy when AVX512 was available,
while on make, a build time AVX-512 flag needed to be explicitly set to
enable that AVX512 rte_memcpy code path.

In the absense of runtime path selection for rte_memcpy - which is
complicated by it being a static inline function in a header file - we can
fix this behaviour regression by similarly having a build-time option which
must be set to enable the AVX-512 memcpy path.

Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds")
Fixes: 3e1bb55fd6ef ("build/x86: add SSE flags")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

---
NOTE: This patch is not suitable for backporting, as it will break the
build support for make builds without addition makefile changes.
---
 lib/librte_eal/include/generic/rte_memcpy.h | 4 ++++
 lib/librte_eal/x86/include/rte_memcpy.h     | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/include/generic/rte_memcpy.h b/lib/librte_eal/include/generic/rte_memcpy.h
index 701e550c3..e7f0f8eaa 100644
--- a/lib/librte_eal/include/generic/rte_memcpy.h
+++ b/lib/librte_eal/include/generic/rte_memcpy.h
@@ -95,6 +95,10 @@ rte_mov256(uint8_t *dst, const uint8_t *src);
  * @note This is implemented as a macro, so it's address should not be taken
  * and care is needed as parameter expressions may be evaluated multiple times.
  *
+ * @note For x86 platforms to enable the AVX-512 memcpy implementation, set
+ * -DRTE_MEMCPY_AVX512 macro in CFLAGS, or define the RTE_MEMCPY_AVX512 macro
+ * explicitly in the source file before including the rte_memcpy header file.
+ *
  * @param dst
  *   Pointer to the destination of the data.
  * @param src
diff --git a/lib/librte_eal/x86/include/rte_memcpy.h b/lib/librte_eal/x86/include/rte_memcpy.h
index 008a3de67..79f381dd9 100644
--- a/lib/librte_eal/x86/include/rte_memcpy.h
+++ b/lib/librte_eal/x86/include/rte_memcpy.h
@@ -45,7 +45,7 @@ extern "C" {
 static __rte_always_inline void *
 rte_memcpy(void *dst, const void *src, size_t n);
 
-#ifdef __AVX512F__
+#if defined __AVX512F__ && defined RTE_MEMCPY_AVX512
 
 #define ALIGNMENT_MASK 0x3F
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] build: fix memcpy behaviour regression
  2020-10-12 14:51 [dpdk-dev] [PATCH] build: fix memcpy behaviour regression Bruce Richardson
@ 2020-10-16  2:13 ` Han, YingyaX
  2020-10-17 10:32   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Han, YingyaX @ 2020-10-16  2:13 UTC (permalink / raw)
  To: Richardson, Bruce, dev; +Cc: Ananyev, Konstantin, Tu, Lijuan

Tested-by: Han, Yingya <yingyax.han@intel.com>

Best Regards,
Yingya
-----Original Message-----
From: Richardson, Bruce <bruce.richardson@intel.com> 
Sent: Monday, October 12, 2020 10:52 PM
To: dev@dpdk.org
Cc: Han, YingyaX <yingyax.han@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Tu, Lijuan <lijuan.tu@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>
Subject: [PATCH] build: fix memcpy behaviour regression

When testing on some x86 platforms, code compiled with meson was observed running at a different power-license level to that compiled with make. This is due to the fact that meson auto-detects the instruction sets available on the system and enabled AVX512 rte_memcpy when AVX512 was available, while on make, a build time AVX-512 flag needed to be explicitly set to enable that AVX512 rte_memcpy code path.

In the absense of runtime path selection for rte_memcpy - which is complicated by it being a static inline function in a header file - we can fix this behaviour regression by similarly having a build-time option which must be set to enable the AVX-512 memcpy path.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] build: fix memcpy behaviour regression
  2020-10-16  2:13 ` Han, YingyaX
@ 2020-10-17 10:32   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-10-17 10:32 UTC (permalink / raw)
  To: Richardson, Bruce; +Cc: dev, Ananyev, Konstantin, Tu, Lijuan, Han, YingyaX

> From: Richardson, Bruce <bruce.richardson@intel.com> 
> 
> When testing on some x86 platforms, code compiled with meson was observed running at a different power-license level to that compiled with make. This is due to the fact that meson auto-detects the instruction sets available on the system and enabled AVX512 rte_memcpy when AVX512 was available, while on make, a build time AVX-512 flag needed to be explicitly set to enable that AVX512 rte_memcpy code path.
> 
> In the absense of runtime path selection for rte_memcpy - which is complicated by it being a static inline function in a header file - we can fix this behaviour regression by similarly having a build-time option which must be set to enable the AVX-512 memcpy path.
> 
> Tested-by: Han, Yingya <yingyax.han@intel.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12 14:51 [dpdk-dev] [PATCH] build: fix memcpy behaviour regression Bruce Richardson
2020-10-16  2:13 ` Han, YingyaX
2020-10-17 10:32   ` Thomas Monjalon

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox