From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70044.outbound.protection.outlook.com [40.107.7.44]) by dpdk.org (Postfix) with ESMTP id 6C365160 for ; Mon, 8 Oct 2018 11:27:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oJdmO08nMTxtntZw1diEYVmb54BvJas76dGTbktKWqo=; b=V8QoDsq2XbSdgKlmX34JPIFC3ONWYnUlnEuK53qxiSxMkFXvAIEvsVY/FQy/5rjB5llL4yN4mFQr5NevbApqI3rVxqUlTpJ+jXIYTvGFWeKo6IXtR/n1rl1gLZNRAQlFb5PnBWNC/leg2uat6oN7gY2rmNWcttCdI2w2kd9FyPY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by AM6PR04MB4679.eurprd04.prod.outlook.com (2603:10a6:20b:1c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.21; Mon, 8 Oct 2018 09:27:42 +0000 To: Ferruh Yigit Cc: Reshma Pattan , Hemant Agrawal , Ashish Gupta , Fiona Trahe , Pablo de Lara , Akhil Goyal , Declan Doherty , Fan Zhang , Rahul Lakkireddy , Gaetan Rivet , Qi Zhang , Xiao Wang , Beilei Xing , Wenzhuo Lu , Konstantin Ananyev , Rasesh Mody , Harish Patil , Shahed Shaikh , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Nipun Gupta , Anatoly Burakov , Thomas Monjalon , Jerin Jacob , Olivier Matz , Ashish Gupta , dev@dpdk.org References: <20181004034047.26824-1-ferruh.yigit@intel.com> <20181005162612.31906-1-ferruh.yigit@intel.com> <20181005162612.31906-4-ferruh.yigit@intel.com> <13444cc5-2a1e-881b-40a0-4ab972324e5e@nxp.com> From: Shreyansh Jain Message-ID: <4333f59c-4f6f-34c3-fe61-aea8ffb00e10@nxp.com> Date: Mon, 8 Oct 2018 14:57:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BM1PR01CA0098.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::14) To AM6PR04MB4679.eurprd04.prod.outlook.com (2603:10a6:20b:1c::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0242c66-00cb-4898-7ea7-08d62d004f68 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4679; X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4679; 3:ELmXVkjz/uVJdaJtpWKHKI1k+D5r2GXLdecFsiSaYGXuBe70SxlIWbHdo8K+2F7bnsERcYLQTpY0MzxONtAEHC+xA/idz/1gq1corJZIDzo+R31GYKmdH/8zb0+X6sbTpgxIvX7J3PfbaKPK/s4AyXHCNwvOt19c+/bD2x2wv+9UyzXxWPJWEJlW6DJW8K/cl7NKnPdTD+c/oi4BYcTVSWnxbnUugnSN1UKO9WnzeHfo8u23moIWZVkVXWjxF+JA; 25:UZ+7kSv9Ew+1YO1zQ5dBBer7UFUD9jp3DGJ0wJHin0m3CKQ6nKuFj0vZUvgodz/RmOkgirqpAiTw4nnwRyYtZnWo5mV6N2JVGZG/3CrcGQexiGoh9OuMB8o3HdcKoPcYPlzlBQFIQHydebzjArXL2R1fv/59SXa08UcPLWg8nCcfEGDeISH6rdJZjMJ8Z1r26VImFw+E+Tuk3m1y0WmfCkiQlWOmXSC/RHzF0Zxe3A2yfm7ARG6l2quer2JF1yCBQfRoR3Ktu4yAshiDrLEyn9LyMy4mNuX2xXDgUlBYdLPLaU9FOBQc7NUNtLKNXmB1hNQyDVzKASLkZ33Ji3eY+Q==; 31:o4/WocajhY2IsO5pmc+fMxIfbT4TUa4VYXY8INvxcZ/D0ZwOy3G66MLIS29L617ickmf0g8Ci9a+e2n+fLMnSskblGLXnOMmpxrziQuGPxPGAavzTprgm/ZTgYQEF2S5LMxnSDuMKY3dLU17uDmmRf/eTqBXcoyrtnt2cYeaDPTD1MQsmT9AYnix80733of4Bud8Hdl5AKYpSMkEn+f5btQy4RZKSgR1q0FPG+5bxuE= X-MS-TrafficTypeDiagnostic: AM6PR04MB4679: X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4679; 20:qd674SoH4dCR0NYQ32YQF70dPd6MjhaSHFWvW94WqAqkQ0Y6jtn0A8EVYOMYWnOg/Zb9gXgr9JRJC7xsF5x7WU9R7GYGgnTRJr66jTrDFDAPAv/XHTKbnBZ0GuNj1r7o5ozCYkTFOOzDf7WzY0a/hBsRiTC7W0PeA86aeS8T/j0TKgV1nIjs6FsCknxaiLQo/AuEqmbHdZ6VfkjIcQFViBrtq5MkcV/yDXho6zmsK8/ltSVpkBXxXpechQhHtHpZODf3ad1zK6gLcCfw66t3gSv6ih4vwJOyeYL36gWQqHC4k8WmV7pNO7/7Jkoc2RG4Qh5ENCJr+QkL0P7c9KbM6A08L+aH6Cw3UBBGnvpg3KVkIIwTRHmtXwztn6buByHqaJRs1LmivHvN3zo0nBl2kS7JTh+jkzqKtkDqlGb046GYgQT28VuOqtQSjvETaQx5IvNhAKZrsaRk5jv6XHnpNKIK3gutDge9HaQoQ2T85vNynTqJjNZfJEXT0TORq7tW; 4:GR51jXW8VH4PPSQZC6Am4pPigpZhZHRlC4OuyTaqcpnZBwWvnnxZ7PhiE9LDKZqLJB8YPGx1ZuFjNwUbHp/eD6XB9pJXT5W8dwLFeGvEGIVvCvMC23XQYFzU61dQg7EG6Tg6EcTqd2/rm/fXbPL9rWJxw4cjT3TviVyVX2kVFFa9Wvkw9mnBgOXO11Rujt9Bz6DiugMt08oqPELXLLZj/Dt+BZH/lIA2FwJjFgZARF5gzYSCI+f0Mi3PqqXTJFnbccvDEy/t4vb7NJMTq3YrdoALD9nl9JbRgBu1/AL3KJonxcgd4YX1JYsfE5ToGsrFgmqeSXMA4PMMRtqw0mNXjYvRf8yOYFri8/qUfeMqij4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699)(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(201708071742011)(7699051)(76991055); SRVR:AM6PR04MB4679; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4679; X-Forefront-PRVS: 081904387B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(6049001)(366004)(136003)(396003)(376002)(39860400002)(346002)(189003)(199004)(55236004)(52116002)(76176011)(2486003)(23676004)(52146003)(50466002)(386003)(486006)(956004)(2616005)(305945005)(476003)(7736002)(11346002)(5009440100003)(230700001)(53546011)(44832011)(77096007)(26005)(446003)(97736004)(16526019)(478600001)(16576012)(316002)(186003)(36756003)(7416002)(8676002)(64126003)(86362001)(6916009)(6666003)(106356001)(5660300001)(65826007)(66066001)(5024004)(54906003)(65956001)(65806001)(105586002)(31686004)(47776003)(4326008)(53936002)(81156014)(6116002)(25786009)(3846002)(81166006)(67846002)(58126008)(68736007)(31696002)(6486002)(8936002)(93886005)(229853002)(6246003)(2906002)(110426005)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR04MB4679; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTZQUjA0TUI0Njc5OzIzOmt2N0hJTmd4NUdMQ3prMjN4NEZOR2NDNzdn?= =?utf-8?B?aTAyb3B4VjNXS2pQaDlDU0Y5RVR3VGphSkpOMXdzc0lrcGtMenpKRS9zcXNH?= =?utf-8?B?bVduZUp6cmRiSEdDcGl6NzJXaVJWRFNsZEFibXNoSHhCWUxYTmx2c2RvbmU1?= =?utf-8?B?dUZITkVpTko1UkkrNTI5bTJsQVRkdS96RWZLTGdnMnlMbXJvS2ZoL3RJNUV3?= =?utf-8?B?NEJaeWVicEF1dzREZFRnZVNqUzBHRG55WG40T2tRVC92dEl5djR4d05HVnZw?= =?utf-8?B?cXRhTVhkZytraG9YYWFGR2NlTGVhaUIrRmdtV2swcE9pRWZ5Y1hKVU5weVpM?= =?utf-8?B?KzhyK20ySUgwNGI2U1ZhVjdJV0RSNHVTSTZ2NTRKRnJFUGdyRzZ2WkR0UHQ1?= =?utf-8?B?L0FtY3BGTG5OekwreldyWVZjaFBwMldzMHduYlhwd1J5eGNyL1FLR2dJZEhF?= =?utf-8?B?MjBVOUt5WGJVbFZCeEZTcHFFbmR0dEI1eU5YVGNCc1BnekJYYTNYQ2NBYlRr?= =?utf-8?B?YVhsVmdpNXB0eUViVG04b2pPbzcyRWFURW1ybHVUUy9JMDc4ckxwc3VoVnVw?= =?utf-8?B?RU9ESWtVZHZBT09aR0MzVG9KcldpOStuNytBN1NRcXFQZnZtNndYSzJnekR5?= =?utf-8?B?L216TTc1cVg1QXRBdlBtMTJKOXVQTnpYMCtxblpFR3BneDFWVmx3dm40L2M4?= =?utf-8?B?b2tpU1YzVDhwdVFST0NGUit3SWllb2trZ3VBaklWM1AxSTFEQndlcC80Tko0?= =?utf-8?B?dVJHVitQOGhIbkh3V1hBcHdJWWR0TFRPcUswdFBkRnZCZ2JHRWlESVdFV1hO?= =?utf-8?B?NGdBbkFZd1diTVJLT1hoVldoVmdJT0Z1dEh4M01XSHpJUFFvaEdaaUo4TGo3?= =?utf-8?B?Z3hiVnBtRjJqNzRod2RZVjRVVzJDbkdMdDJSMGY0cEJ4TWc1UDdCSWNybC8y?= =?utf-8?B?T2w3NW4xSmx2YkdqY0ZYcXVyeVZpSnl6RVZ3TnhqbVZaK2lpMUFDRFNIckNs?= =?utf-8?B?bnBIOWFTNXZsSDM3YXpBTkFHR3A3bXlXYzgzUXdhSWZ3L0d0QXJHV2xvS1Zw?= =?utf-8?B?dkg4T0pwdzZSSmVSd0R1K3o4bXZJQTVubVp1ZXdsaCs5TkZGRHZ3ZEhjYnNh?= =?utf-8?B?VjVxTVhwTVpLYnJqbnRZOFJCalc1a0RaVlVIcFBpeGJpWkdkalJENlJNWWNP?= =?utf-8?B?THBCeWc2alZRRGhwQnl4eEVORTlmbCtMV05wUEdWT3NJWWtIMi9OdVVMazAz?= =?utf-8?B?Q2dWaGQ3WWZPT25Tdm5CblNPckh1cVdQZ1pNRVZzcXphMDY1YUhLMUt2Z3Zs?= =?utf-8?B?ZDU4NjBDN0hjSlU4a0ZzK1E3VUpOWnBkcVFXVmVoWkIrNG5TOTdIcDhzVWZr?= =?utf-8?B?a0haL1RmUitwempMWjZrNGZaY01nSzlCV1ZtRjBlZjRjSTMwMWxlVUdZdWxK?= =?utf-8?B?ZlJSQ1o5R0c5d2hHSVk4WlZ6QzNhUGgzYW1uN3RvV0paK3IvR0hxMzZQZmVs?= =?utf-8?B?V1AxV1dQZWgyVFVORGtWTk5TYUFqcXlRTkVsR2VtOURpaktEYVRDWHRtSUIz?= =?utf-8?B?VzFBQW5GYjJoREsvTzlWU3Z6cW9ERHk5ZGFBbDFvYTZaRDVVTXlyRUJoUnBV?= =?utf-8?B?RWQwNEkxYzR4bGxEUEZLQWsvL0QyTS8xMHhzdmlJSjhMQWFVTEhXdmkyaGI5?= =?utf-8?B?YnNaWjdndkdsckZLSnYvYWFPNmdoUHlMelFRTVlLczgwaGRwL0lGUnBEeXZB?= =?utf-8?B?NUhxb3BiUmRySkhOWkEvNStyVGo0bjhyZXNNSEUramNyOHFseUtXTzZ2ZkZw?= =?utf-8?B?blY3a3NuZzFHc3ErWDBFNURja092Nkl3UFlkSE9WaUFrR2lNUGJQVEtrakRW?= =?utf-8?B?aCtwVHVoVkYwTU1HeldHYmRVMG5WaHFyZm8rdjZWWDFnL293aDB3N0w4Uldw?= =?utf-8?B?OGZGcE9NbWJxMzdpKzl3bEoyT2dQYjdsdGZmK1NGS2lnUjZYNUl4QTY0SGlR?= =?utf-8?B?RlhDcWE3WUtQNjBBVU9Ocyt2WEJlajFPSWd1QytsZjF4cWN2K3J4THh2d0ZV?= =?utf-8?B?MEx6YmtXakdVQ3ZRQ0V6L3RzSFNrMnlEcVZ3ODgya0V1c3dzek84Ui9VRDk2?= =?utf-8?B?ajdidmVINlhScnVwS3QvZnAvQjJNQ1hQN3Y3RWpUSkd1Q1ZuL0ljd3BWVy9q?= =?utf-8?B?RnhZWldXQVJ6TUNKZ1JZbFhXOTJrYnlybmsxNmdZSkpVUHZFK1h6bkdpOE9p?= =?utf-8?B?YzhtQjZieTZqMkZ4OVpCV0QvUkRGVkxtS0VzTHR3RFdYbytmdkVManNhNEln?= =?utf-8?Q?YfBaY0dAVbLKalnY=3D?= X-Microsoft-Antispam-Message-Info: W6xKgeEc0e33FXrsgQWRy9i3o1bfjr5g0bPnHWESGt3Y4Js1J7Ha2wsTdqk1hX0vhU/t1ZdhIWYDJpqybtv9l9qGvV6LMNmIubDVHVp1qpTqrRgMIcLvQp1btmcc6om1jiHYIgyWl42V9ds6VkpD1tjQ33g+fp5TJTK1s+ZX3hltKKDLaJCYL8mrhiAyNP55rJYLdWcKwNxTxR6qGnzBhQzj79MWQYI9BPYVxcreg8Gem2iLjBSbg1x3tDg0S8hDIwxiMo5OLy9LpT7AhavUfrBzuwxDgzQRQ0/4s5pyO6eTuQgKgkdagvWm87emyiUXpDeZu4/TcBEHTUkidNPC2xpIb0slcgAJ6pljk1JQSxM= X-Microsoft-Exchange-Diagnostics: 1; AM6PR04MB4679; 6:mwd+qxGfpvdnZKPgDLtr9VrwsKdgHeuLFkuts3JyKOIwSQok75FpkTD+8nCf6P13rnxdlhXqBqmihMNcuZMsuCCPYcfBwAJhgYFQMoOSE53VGWG5Mjx1B4dZYEKSshSPkiQYZ7QbXaywz/BkG+0ozAqlXcCtUPoZw28aYDDlS9aCqaKpXJJqft/UFRbsN/0tBzoJe74+/WWisPjRBl8WVM6/KVzCxKRXg8ikdMvmTrrD013ewe7GYGlmGhe7lAaNuCnibXsah+d2XBDz0G9lAOfNHMPdoMMgtgJIuib4/2BrxGj5kHUCwNl9HPEES7eZRxDpoKtC8NZXqtzPAV28/jtVmORPaKp4EMY+3arSnkpe+lrIKGCc0lkjeCCBQ7ICoQzv1VZNURj19gBaRLxCEQsuKtUoEHFdkAMHWQAC9Xt3y9qTCUcU0Dnv/viqadqdK/A0dojNy/V3M7uAtbDj8A==; 5:wx6jfo6elcXQcakIYddcMhPYhijPySGQFJynOFZaEZX/oopNNxpSyDy4AoFT5Uqm26Guyyei+irgXeBSXTC9/dMqCGhoKx3Gzz4T1/OZ8So7e9+yHfWzK89KflLVSuy5NKdNWelguJXwEJc8gZaqLsTk1p8ZnQj4rhPm9pOk3sQ=; 7:DxnsdNtIbxEtlf/xgUMird2XAJPjKLqTAA7vFygB7AsNtg1s96hqjQL7ZYtPIfyX/cyaQwHBmNwkAGfi0snFxAiJvbyusC+llwpfQAfVTzXMj2c9PQQi8ZlCNmv1sSdxL2vGjHtgjE8T9P4nkM7lhTPrDwx6wjSNWlXXuIz/b81Sz9GFIuBrWUyQSQdk2RLxOhd7SF0pkeL5DbrAAt5iG5p/GXlBi6w8pKvvnkQg8M+W4Ea1+J8bSNamzZDoO/Hx SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2018 09:27:42.3595 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0242c66-00cb-4898-7ea7-08d62d004f68 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4679 Subject: Re: [dpdk-dev] [PATCH v2 4/4] lib: reduce global variable usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 09:27:49 -0000 On Monday 08 October 2018 02:41 PM, Ferruh Yigit wrote: > On 10/8/2018 9:45 AM, Shreyansh Jain wrote: >> On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote: >>> Some global variables can be eliminated, since they are not part of >>> public interface, it is free to remove them. >>> >>> Signed-off-by: Ferruh Yigit >>> --- >>> lib/librte_compressdev/rte_compressdev.c | 32 ++++++++---------- >>> lib/librte_compressdev/rte_compressdev_pmd.h | 5 --- >>> lib/librte_cryptodev/rte_cryptodev.c | 34 +++++++++----------- >>> lib/librte_cryptodev/rte_cryptodev_pmd.h | 3 -- >>> lib/librte_eventdev/rte_eventdev.c | 8 ++--- >>> lib/librte_eventdev/rte_eventdev_pmd.h | 2 -- >>> lib/librte_rawdev/rte_rawdev.c | 10 +++--- >>> lib/librte_rawdev/rte_rawdev_pmd.h | 2 -- >>> 8 files changed, 37 insertions(+), 59 deletions(-) >> >> [...] >> >>> diff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c >>> index 62b6b97ef..9f1e3592d 100644 >>> --- a/lib/librte_rawdev/rte_rawdev.c >>> +++ b/lib/librte_rawdev/rte_rawdev.c >>> @@ -35,21 +35,19 @@ >>> /* dynamic log identifier */ >>> int librawdev_logtype; >>> >>> -struct rte_rawdev rte_rawdevices[RTE_RAWDEV_MAX_DEVS]; >>> +static struct rte_rawdev rte_rawdevices[RTE_RAWDEV_MAX_DEVS]; >>> >>> -struct rte_rawdev *rte_rawdevs = &rte_rawdevices[0]; >>> +struct rte_rawdev *rte_rawdevs = rte_rawdevices; >>> >>> static struct rte_rawdev_global rawdev_globals = { >>> .nb_devs = 0 >>> }; >>> >>> -struct rte_rawdev_global *rte_rawdev_globals = &rawdev_globals; >>> - >>> /* Raw device, northbound API implementation */ >>> uint8_t >>> rte_rawdev_count(void) >>> { >>> - return rte_rawdev_globals->nb_devs; >>> + return rawdev_globals.nb_devs; >>> } >>> >>> uint16_t >>> @@ -60,7 +58,7 @@ rte_rawdev_get_dev_id(const char *name) >>> if (!name) >>> return -EINVAL; >>> >>> - for (i = 0; i < rte_rawdev_globals->nb_devs; i++) >>> + for (i = 0; i < rawdev_globals.nb_devs; i++) >>> if ((strcmp(rte_rawdevices[i].name, name) >>> == 0) && >>> (rte_rawdevices[i].attached == >>> diff --git a/lib/librte_rawdev/rte_rawdev_pmd.h b/lib/librte_rawdev/rte_rawdev_pmd.h >>> index bb9bbc350..811e51d07 100644 >>> --- a/lib/librte_rawdev/rte_rawdev_pmd.h >>> +++ b/lib/librte_rawdev/rte_rawdev_pmd.h >>> @@ -73,8 +73,6 @@ struct rte_rawdev_global { >>> uint16_t nb_devs; >>> }; >>> >>> -extern struct rte_rawdev_global *rte_rawdev_globals; >>> -/** Pointer to global raw devices data structure. */ >>> extern struct rte_rawdev *rte_rawdevs; >>> /** The pool of rte_rawdev structures. */ >> >> I think `rte_rawdevs` can also be removed from an exposed symbol. In all >> cases (at least for now), this is being accessed using an API (and no >> macros). There should be no need for people to read this directly if >> sufficient get_by_* APIs are available. > > +1 to make it library internal. > > But `rte_rawdevs` is both in public header and .map file, so it is part of > public API, we can't remove it without deprecation process. > And I want to leave the decision of removing an public symbol to library > maintainers. Yes, I missed that part :) I will fix it in next release by sending deprecation in this. > >> >> Wouldn't same be valid for rte_compressdevs as well? > > `rte_compressdevs` is already removed, but if you mean `rte_cryptodevs` it has > same problem with `rte_rawdevs`, it is part of API. Ah yes, my mistake. I was thinking about rte_eventdevs and rte_cryptodevs (but, this symbol is being used by a crypto/scheduler) > >> Besides the above: >> >> Acked-by: Shreyansh Jain >> >