From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDEF0A04B5; Thu, 29 Oct 2020 22:14:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A6C7C9F0; Thu, 29 Oct 2020 22:14:23 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 27570C9EC for ; Thu, 29 Oct 2020 22:14:22 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id CA0845C0105; Thu, 29 Oct 2020 17:14:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 29 Oct 2020 17:14:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= nlnyf5uNi33RZxwxrsk53nmJRzrzDVLb5CWxp6GtEZs=; b=XxsAwbOCrvyUb6Pa fjVKwmbj+E3/rdWXj1Xh9w7Py6CcSMt0sEw3e+er3GjfCFSXhSdpAPfeEw4cxmwL 8HluMvKBKVlooy12AZQmh2/NLYxVYR0PuprEPIkFr8a1wTNncQuFXp5w7wGloxeT x7b0sS6cvDz6wshMToMLWZQuB04UrgpCeqAi909Ioz7h/Z/lbzTN59hxVLQMvbua mm8JwGb5qqEEE3WyVEw2e9V8QV95+UhQtZyDYsHJWucD1SzlxWiPwqHPYKkfPCsI jw4hN4kbJjfklFc4i94sRDN0QIwypFqLMUgPpWKak2E0G1GlQtyu4Tle6suEL8eS Ba0J/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=nlnyf5uNi33RZxwxrsk53nmJRzrzDVLb5CWxp6GtE Zs=; b=n4inmfqKa4n50Ekh1qR0nTsDXadVbWJ4eEd3SQ6W2ApHNk0++zvEiLKeV 0gvMwzfwa9sVmld/xXbLtg8Nn3qiQMd42YkJ3WQykQh5jfy6hMJ3vBJMnS4a1x/Y hlx7qnAbt0V6z2ZpZ4Os2zErqdT4fYpgc7QACfG6jd+40WnVm2JPkRiIU1xbO7YK Rca/fbSXf1Sx+4PxoN+AQ055kXD7n1zaR4bpa2zCdZKbOaNr4RqnanFUkWLUOrEa VZgyPOsPcUlnI+Hn1/Cc6nr+jYeLgyzDvhD+4j8fmhM27orzQNCB5xoV4HF5znBk EQ9ZXOK75J7sZvYjNphsYse+adwQA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleefgddugeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C4CC43064684; Thu, 29 Oct 2020 17:14:19 -0400 (EDT) From: Thomas Monjalon To: Hariprasad Govindharajan Cc: dev@dpdk.org, ferruh.yigit@intel.com, anatoly.burakov@intel.com, bluca@debian.org Date: Thu, 29 Oct 2020 22:14:18 +0100 Message-ID: <43352649.oevFlYq0qV@thomas> In-Reply-To: <1604002251-43812-1-git-send-email-hariprasad.govindharajan@intel.com> References: <1601909255-26251-1-git-send-email-hariprasad.govindharajan@intel.com> <1604002251-43812-1-git-send-email-hariprasad.govindharajan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/10/2020 21:10, Hariprasad Govindharajan: > The igb_uio source code requires interrupt modes defined as > MACROS and enums in the header file rte_pci_dev_features.h. > Now, the definitions are moved to the igb_uio.c file so that > this module can be built without building DPDK > > Signed-off-by: Hariprasad Govindharajan > --- > linux/igb_uio/igb_uio.c | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c > index 039f5a5..84c3071 100644 > --- a/linux/igb_uio/igb_uio.c > +++ b/linux/igb_uio/igb_uio.c > @@ -15,7 +15,25 @@ > #include > #include > > -#include > +/** > + * These enums and MACRO definitions are copied from the s/These/This/ s/MACRO/macro/ > + * file rte_pci_dev_features.h > + */ > + > +/* interrupt mode */ Useless comment, creating a barrier between previous comment and definitions. Please remove. > + > +enum rte_intr_mode { > + RTE_INTR_MODE_NONE = 0, > + RTE_INTR_MODE_LEGACY, > + RTE_INTR_MODE_MSI, > + RTE_INTR_MODE_MSIX > +}; > + > +#define RTE_INTR_MODE_NONE_NAME "none" > +#define RTE_INTR_MODE_LEGACY_NAME "legacy" > +#define RTE_INTR_MODE_MSI_NAME "msi" > +#define RTE_INTR_MODE_MSIX_NAME "msix" I would remove the above blank lines to make clear what is from rte_pci_dev_features.h.