From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06AFBA034D; Wed, 16 Feb 2022 14:23:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C69B0410FB; Wed, 16 Feb 2022 14:23:04 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 4AAB440150 for ; Wed, 16 Feb 2022 14:23:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645017782; x=1676553782; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=0N5ZdoOqFAnaL7pXyBSYHUSWCrtx9I5CsOpECWfOMHA=; b=DoucoobahWuq5r6GbD4O+RQrPqGQu4X7qkfGfnMk0H1RdI/7Q5glQimv NyYJQ575wZOVZhrs1FWuIuKtvLDuM5t9+nTX+/PvJ7XFe1kEPh4XY6vfu FMNLtefFrlk0OYBqdXxxp0ibBST7hEX19RUdGYY9poZhVSaS70j/cDhEt 3oW0VUG6WrIY0oE0gOxm7s33FdM2BqGzKzcGEncmbwjwZ2+zrHOW+qx7i iiqHVGiXdTlbRLyDewtEE98z1tWj+Wz4vWEhJeMDTWAL8yNkEnUtGo+bQ Y06rQyv+A2a465D/p04tTR/WRO11tBt9acKz07iNbqjmwNVHPsoqhFid0 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10259"; a="248198314" X-IronPort-AV: E=Sophos;i="5.88,373,1635231600"; d="scan'208";a="248198314" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2022 05:23:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,373,1635231600"; d="scan'208";a="704297600" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 16 Feb 2022 05:23:01 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 16 Feb 2022 05:23:00 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 16 Feb 2022 05:23:00 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 16 Feb 2022 05:23:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fmbWUy+VSsrE2rL/TYxH5fVTV+jEcgTWAb2BSE0V85j2fcu/WAdc/y042dg/weRwxGpSBedQtby4Pc8Ji9A25lAqdDWu60SfD0KmHgDItpiWWnCQoZciUpN4vSd1Z/YekDUTr79awiLbxCWAWW/bUnjfJwrPHixHgLsgUFES9i39UTv/CiuW04wfVYOphw+Br+5rGuHph2Ue3jyFl8Mw/FuOA0KYDyCvJgI5r5wUZOko9cnn8bPvPEGOFHVUgtSSg7FEHiygAdKUjXipOVRnILSljBTKBzHTw+DBn84x47Tvldc6jReR+YMDLu8HGigbERY25bB7UP09jfHfn1Rfcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R5JI1nCtCqEQMTWaosWEHqQG9GMCjcBawh+Va4G8zGo=; b=dS3Eg8DnDkMXgOSCQEY5wS7+CQwQEFBFvTm3iOvY1owtC6GVqDoJLoCwjWjIkbaupIQ8PmKqcnZipUO+9+TMD61n8rJwWIH5Lc4MP6DTxLP9br5wbeUymlh4ucxJrTe5bBxfHKH9bklWxYlYGLBgLKQcztwmjP1LjbEft/q+PaqqlV2BsRXNSoAJxMMez5Wzq+aXZTZhqq1r2NTHW7O5XJNVT+Jy4jzkhzW5PIjMOpXxwIUCexpLz4NrybB9GGvZATMxnYhzb2fN5uGZ6hlvu1EsW+CkaF2nrvQFULOuVe4HARZWuiIsqu4po6LB4NUgOvNFTWAGwH7h/8l4dX1epQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM6PR11MB4057.namprd11.prod.outlook.com (2603:10b6:5:19d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 16 Feb 2022 13:22:58 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022 13:22:58 +0000 Message-ID: <433559c8-d367-d22b-45b8-8217c190a520@intel.com> Date: Wed, 16 Feb 2022 13:22:53 +0000 Content-Language: en-US To: Wan Junjie , CC: Chas Williams , Min Hu References: <20220214081344.13637-2-wanjunjie@bytedance.com> <20220215105940.60051-1-wanjunjie@bytedance.com> From: Ferruh Yigit Subject: Re: [PATCH v2 2/2] net/bonding: fix slaves initializing on mtu setting X-User: ferruhy In-Reply-To: <20220215105940.60051-1-wanjunjie@bytedance.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P265CA0012.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::17) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e440c6cf-a380-421d-a919-08d9f14f72bd X-MS-TrafficTypeDiagnostic: DM6PR11MB4057:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:118; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tvESDPkmQxXIfE8dAFCsDiQsV3xVZazGkdNP1SlMPrSDsJ8ShzQNZgr0kPfMeWf5TiNml5gkoueQXT0zUxD7RmqLrXv7UihYhEkPSWYW/qvI9pCbu38zAu97Dfw6fDyLZbJcoCc8ciKuHTTsi/9Pug5EoQfS/oIey600qIABqeRYj72As6Vo2u5zbzc7zHQmey9uPqg2T11atGgHfyIWG9/AjMAV1kHEOzUU7JyCSJUZraYrTaOE51adONOXIebjNQAc2ktsK6gQmNLKiC4R3UZG+42Kfbqmqfv3To7WevkjfDMt2tS6t8hoH6HYfiVriDP5Nubmy7gcFPONM+7LSwa0Ld4s7lsa5vzxASUImL5xmN5c6C/VhXIWcPaihtkymmu9kdYm685VLIGof2hoeMAYkeS/rVRCX/rfYi1H+2b0txmbE/SSBNdzaBQun7ATypNj0/DX6/hG0oUFVyVNk5/VwrA1u125OIlwEpYLG4UpdkDjK/fXTnDm5sYWerCVI2ZiqqhxT0Ivp8tz3zukUYd6w25xp89Rrn1Im+O56sZ41Z+OtVicbFEd0xpJ6rJ+YOlGuj1ApwDVJ99u+TVx0tcFI3f0MNgdPPtpkPo4kwnIMhXnVB/rWF0/S7s0cWIZRAhhPfAe6QYyeKj1XPqZqrp9PDXRkEGTqPeyYA4AkCVY6BaCUnt82aiF7amq0cg6xdP71ssyLrdCPXe6o0GXMA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(4326008)(36756003)(83380400001)(186003)(2906002)(44832011)(5660300002)(8936002)(66946007)(86362001)(31686004)(26005)(6506007)(2616005)(6486002)(53546011)(66556008)(8676002)(6512007)(66476007)(82960400001)(31696002)(316002)(54906003)(6666004)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTJ1YzBJOTAwRVk3M0R4dFE0TkJaL29IaW5HR09XREtoZzlmc1BaRWlZVXho?= =?utf-8?B?Nkwrbk90ZE14cjdwTWhyL1N4bnlyK1RGS29pVllNWlBaZ3NVcFQ1eExzVm8r?= =?utf-8?B?ejJIUWFrNWhyTlVBYXRnNktDQ0ZUTWZpanlvVHBQdVVUZWRkVDRhOG4zbi84?= =?utf-8?B?ZXpNUTZDUEhGbmhlSE5RYWUvSUtvYmc1SVl2M2M1Rm9sTWNKY3ZvYnRpQ2Np?= =?utf-8?B?RVg0d0pUOStIS1F3L1pOd3BmcU8rMlVVaE5sSGtmZFZBK2tueUxHTzNlWmtV?= =?utf-8?B?Q3puV05qMGI3cGZZVVJUbm40WlBrV0t1WVgzNlNNb2hWbk94b25YblJka2l6?= =?utf-8?B?WUNqRkZtbGdyUXlrcTVhS1BidmQyOHQxNnhPeThGNmloZm5ocmxibUpBMDJq?= =?utf-8?B?RTB5NE1yZlRoVEJoTU9RWjcyV2orR1VyZ3RpQlgrVGVDS1l3akdqbytIZi8r?= =?utf-8?B?VXNGL2FwREVYSjhsOERmUlc3bXBTc3ZNMmc3UVFURTdRbjZjeHVKUDdPOUhj?= =?utf-8?B?bldtb1dmOU90czNGRHpWamxrejlHeHBRMWJFMFN3ZGRPQ1owcG5LUmZJTUpo?= =?utf-8?B?aVdsTit1aEdwS2Zrczl4aTdpTml1NWE3TlNsZGVlUHBEQlYzSCs4YllvRmlq?= =?utf-8?B?VFh2QzRadkQ3SExoVGNQQ1d4SGsxbXFrem5MbkxxSXNucisvd2NVZ3VYYkhF?= =?utf-8?B?RkIvd2hMYTlXRnJCZWhhUXU3d1krcFBvaU5INjZnamsvR3AyZFFnbEs2MEUy?= =?utf-8?B?RDJNQlNCUW5hLy84RTIrWWZkb25lYWw1STFzQUdvQ2xuMDdWMytpZVNVZ1BG?= =?utf-8?B?ZWowbkt3TStkaDVCaVNyUDJxaUd0L0ZVU1Joa3Q5NGhsc1d4SXZ0aHVkci9m?= =?utf-8?B?VVlUd25EemNCdjlScnZ1MkZyTE50MjhQL1N4TVk1WS90bDhXN3EzRzd5MVc0?= =?utf-8?B?MnYxL1pOR0d1dFp5VXZCY2ZBRUt1Sjh6UG1MR0lPNHphZ3lPQ2dmSUo5eFZ3?= =?utf-8?B?ckU5UytycmpNUkovaHN6T0pDUE9jbVE0d0pyKzd4NUwxNEJ2WVZSWENHT3FK?= =?utf-8?B?T3duUnR3V0o4U1V4NHJuQStWa2xFeDcyOXlPWDFEdUxRcEdndDNrNVJzOUo4?= =?utf-8?B?OUdoRnpFaTRhQXhhdnlUZlFxc2Z1MGRadFhpWFJmaWkzZ0orOG1YNW5mdVMw?= =?utf-8?B?d3JFSmRYejZ4b0ZnRWhEMDUvcnRBMU9jVlo0cEdmbHdzMzdZRHdOeEhtVDVa?= =?utf-8?B?MjJHNDM2K2tjQXgzVFlkWWsrVTE4WlAxQVkwUFZ3ZWt0SkNGK2NmMGpDdHBR?= =?utf-8?B?NHJiMjNhRG5Kc1owa01HZlpQcmFmV2lLUVFVOU9Ib1ZMSnNHOXFsblAxaXVK?= =?utf-8?B?T3F1RVNvWUp2bElhcDZ1U2hzVkNtdHNXWmJzZytsZmlyRnJtekVlN0xwS3RM?= =?utf-8?B?cThtQUpzTlB0Z0NQc21RSFBaYm52dFVEYWdUbUM5dzlPNzBVWE92RUJGbHg1?= =?utf-8?B?VHpDRmU5NG0rQXdHVENoeEVRYlNmTnRMWEprdC9pMjUvUVRFTDBxRGwvcVN4?= =?utf-8?B?NGRSamtKcGxWYnJ0U0ZiMmRDMUQwN2hPUmZpMG5xUEhQaFExSk5CRGt4aXNj?= =?utf-8?B?VXZ4dGg1NmxEbEF6ajZleGRDOUN5Zk9xYmFDdU9JK0JKSTI2NU8vbEZKNndX?= =?utf-8?B?aWVaS2c5VUUwZnRHUSszT3hJUGFSSG50bG1FWi9zUkNpQndraGxIclF3d2NG?= =?utf-8?B?RERVdk15TDkvdTRBd0d5SHdFU0taOE5UbGxHdVErNVpBTHJsWkEwd1JuUTlY?= =?utf-8?B?TTViTkJnMXljejY1QW9Hc1VDam55b01OaEZUczhZRkhQTHhOenRUMDlRWUxV?= =?utf-8?B?bWhiZVZJWEc1dEpDMVlDMHMxZGxDM3J3OGhZZUxYRFR4L1U0eGN5ajJhSVdk?= =?utf-8?B?QjY0ZkgrZEVEbXVpY3pvR2tNRFQrbU5aZld6dE9VNEJHd1pNUllES24rZ2hB?= =?utf-8?B?SnNnSG9uQ1cxSG9QSHZ3RVV1OXprWWpjcEtTaXpraVc3NmFFOTFXeXhFQ2lM?= =?utf-8?B?N015N25NZHdRU3hOb3pCWTlUN3hqSlZzVm5wU3NDakhDMkVYWFJPQjFaODIy?= =?utf-8?B?VmN6Y3lMVVhqOUp1a21pTjNKMTdOTm5sbDFTa2d2QWVWb1M5TW5FKzRORkt4?= =?utf-8?Q?wzcYecrszeV0A7eU/5IPBiM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e440c6cf-a380-421d-a919-08d9f14f72bd X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 13:22:58.2659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fZjRodnlYnWSXYrFsxHFoCPWgJXYaD4uFHOBeAl5ImcgZWGqxbQAvGapapytxF2KZySmUcnTnG43YjV48sjECA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4057 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2022 10:59 AM, Wan Junjie wrote: > If a initial process for the bonding device is like: > rte_eth_dev_configure > rte_eth_dev_set_mtu > queue setup and start, etc. > > Pass the vdev args to application, and init bonding device only. > -a 0000:af:00.0 --vdev="net_bonding0,mode=2,slave=0000:af:00.0" > > It will fail and compain for the slave device > "Port 0 must be configured before MTU set" > Change looks good to me, previously configure(), queue setup & start() all done in .dev_start dev_ops. Now configure part separated and .dev_configure also calls the configure part, .dev_start still does the same. Conner, Chas, if there is no objection from you, I will proceed with the patch and merge it soon. > Test can be reproduced with ovs. > > Fixes: b26bee1 ("ethdev: forbid MTU set before device configure") > > Signed-off-by: Wan Junjie Tested-by: Ferruh Yigit > --- > v2: > fix typo in commit > add reproduce procedure > --- > app/test/test_link_bonding.c | 4 +++ > app/test/test_link_bonding_rssconf.c | 4 +++ > drivers/net/bonding/eth_bond_private.h | 4 +++ > drivers/net/bonding/rte_eth_bond_api.c | 6 ++++ > drivers/net/bonding/rte_eth_bond_pmd.c | 43 ++++++++++++++++++++++---- > 5 files changed, 55 insertions(+), 6 deletions(-) > > diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c > index dc6fc46b9c..12c50ef393 100644 > --- a/app/test/test_link_bonding.c > +++ b/app/test/test_link_bonding.c > @@ -181,6 +181,10 @@ configure_ethdev(uint16_t port_id, uint8_t start, uint8_t en_isr) > test_params->nb_tx_q, &default_pmd_conf), > "rte_eth_dev_configure for port %d failed", port_id); > > + int ret = rte_eth_dev_set_mtu(port_id, 1550); > + RTE_TEST_ASSERT(ret == 0 || ret == -ENOTSUP, > + "rte_eth_dev_set_mtu for port %d failed", port_id); > + > for (q_id = 0; q_id < test_params->nb_rx_q; q_id++) > TEST_ASSERT_SUCCESS(rte_eth_rx_queue_setup(port_id, q_id, RX_RING_SIZE, > rte_eth_dev_socket_id(port_id), &rx_conf_default, > diff --git a/app/test/test_link_bonding_rssconf.c b/app/test/test_link_bonding_rssconf.c > index f9eae93973..7228965ced 100644 > --- a/app/test/test_link_bonding_rssconf.c > +++ b/app/test/test_link_bonding_rssconf.c > @@ -128,6 +128,10 @@ configure_ethdev(uint16_t port_id, struct rte_eth_conf *eth_conf, > RXTX_QUEUE_COUNT, eth_conf) == 0, "Failed to configure device %u", > port_id); > > + int ret = rte_eth_dev_set_mtu(port_id, 1550); > + RTE_TEST_ASSERT(ret == 0 || ret == -ENOTSUP, > + "rte_eth_dev_set_mtu for port %d failed", port_id); > + > for (rxq = 0; rxq < RXTX_QUEUE_COUNT; rxq++) { > TEST_ASSERT(rte_eth_rx_queue_setup(port_id, rxq, RXTX_RING_SIZE, > rte_eth_dev_socket_id(port_id), NULL, > diff --git a/drivers/net/bonding/eth_bond_private.h b/drivers/net/bonding/eth_bond_private.h > index 156335c425..8222e3cd38 100644 > --- a/drivers/net/bonding/eth_bond_private.h > +++ b/drivers/net/bonding/eth_bond_private.h > @@ -246,6 +246,10 @@ int > slave_configure(struct rte_eth_dev *bonded_eth_dev, > struct rte_eth_dev *slave_eth_dev); > > +int > +slave_start(struct rte_eth_dev *bonded_eth_dev, > + struct rte_eth_dev *slave_eth_dev); > + > void > slave_remove(struct bond_dev_private *internals, > struct rte_eth_dev *slave_eth_dev); > diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c > index b78867b125..4ac191c468 100644 > --- a/drivers/net/bonding/rte_eth_bond_api.c > +++ b/drivers/net/bonding/rte_eth_bond_api.c > @@ -566,6 +566,12 @@ __eth_bond_slave_add_lock_free(uint16_t bonded_port_id, uint16_t slave_port_id) > slave_port_id); > return -1; > } > + if (slave_start(bonded_eth_dev, slave_eth_dev) != 0) { > + internals->slave_count--; > + RTE_BOND_LOG(ERR, "rte_bond_slaves_start: port=%d", > + slave_port_id); > + return -1; > + } > } > > /* Update all slave devices MACs */ > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c > index aa6519f83c..c31b723071 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -1678,14 +1678,10 @@ int > slave_configure(struct rte_eth_dev *bonded_eth_dev, > struct rte_eth_dev *slave_eth_dev) > { > - struct bond_rx_queue *bd_rx_q; > - struct bond_tx_queue *bd_tx_q; > uint16_t nb_rx_queues; > uint16_t nb_tx_queues; > > int errval; > - uint16_t q_id; > - struct rte_flow_error flow_error; > > struct bond_dev_private *internals = bonded_eth_dev->data->dev_private; > > @@ -1758,6 +1754,19 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, > slave_eth_dev->data->port_id, errval); > return errval; > } > + return 0; > +} > + > +int > +slave_start(struct rte_eth_dev *bonded_eth_dev, > + struct rte_eth_dev *slave_eth_dev) > +{ > + int errval = 0; > + struct bond_rx_queue *bd_rx_q; > + struct bond_tx_queue *bd_tx_q; > + uint16_t q_id; > + struct rte_flow_error flow_error; > + struct bond_dev_private *internals = bonded_eth_dev->data->dev_private; > > /* Setup Rx Queues */ > for (q_id = 0; q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) { > @@ -1806,10 +1815,13 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, > return errval; > } > > - if (internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id] != NULL) > - rte_flow_destroy(slave_eth_dev->data->port_id, > + if (internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id] != NULL) { > + errval = rte_flow_destroy(slave_eth_dev->data->port_id, > internals->mode4.dedicated_queues.flow[slave_eth_dev->data->port_id], > &flow_error); > + RTE_BOND_LOG(ERR, "bond_ethdev_8023ad_flow_destroy: port=%d, err (%d)", > + slave_eth_dev->data->port_id, errval); > + } > > errval = bond_ethdev_8023ad_flow_set(bonded_eth_dev, > slave_eth_dev->data->port_id); > @@ -2001,6 +2013,13 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev) > internals->slaves[i].port_id); > goto out_err; > } > + if (slave_start(eth_dev, slave_ethdev) != 0) { > + RTE_BOND_LOG(ERR, > + "bonded port (%d) failed to start slave device (%d)", > + eth_dev->data->port_id, > + internals->slaves[i].port_id); > + goto out_err; > + } > /* We will need to poll for link status if any slave doesn't > * support interrupts > */ > @@ -3849,6 +3868,18 @@ bond_ethdev_configure(struct rte_eth_dev *dev) > return -1; > } > > + /* configure slaves so we can pass mtu setting */ > + for (i = 0; i < internals->slave_count; i++) { > + struct rte_eth_dev *slave_ethdev = > + &(rte_eth_devices[internals->slaves[i].port_id]); > + if (slave_configure(dev, slave_ethdev) != 0) { > + RTE_BOND_LOG(ERR, > + "bonded port (%d) failed to configure slave device (%d)", > + dev->data->port_id, > + internals->slaves[i].port_id); > + return -1; > + } > + } > return 0; > } >