From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0838B4337E; Mon, 20 Nov 2023 12:42:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAC3542DF1; Mon, 20 Nov 2023 12:42:49 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 7CDEA42DEC for ; Mon, 20 Nov 2023 12:42:48 +0100 (CET) Received: from kwepemd100001.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SYlrS25tfzRjPQ; Mon, 20 Nov 2023 19:38:32 +0800 (CST) Received: from kwepemd100004.china.huawei.com (7.221.188.31) by kwepemd100001.china.huawei.com (7.221.188.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Mon, 20 Nov 2023 19:42:46 +0800 Received: from kwepemd100004.china.huawei.com ([7.221.188.31]) by kwepemd100004.china.huawei.com ([7.221.188.31]) with mapi id 15.02.1258.028; Mon, 20 Nov 2023 19:42:46 +0800 From: haijie To: "lihuisong (C)" , dev , ferruh.yigit , "Zhuangyuzeng (Yisen)" , "humin (Q)" CC: liuyonglong , "lihuisong (C)" Subject: RE: [PATCH v2 3/3] doc/hns3: fix the usage description for RSS flow Thread-Topic: [PATCH v2 3/3] doc/hns3: fix the usage description for RSS flow Thread-Index: AQHaG6KpXQC9euY3JUOPc1RvLd/5/rCDFhdg Date: Mon, 20 Nov 2023 11:42:46 +0000 Message-ID: <433690c94ad24e06ac045e9aacb136a3@huawei.com> References: <20231120111404.37924-1-lihuisong@huawei.com>, <20231120111404.37924-4-lihuisong@huawei.com> In-Reply-To: <20231120111404.37924-4-lihuisong@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: multipart/alternative; boundary="_000_433690c94ad24e06ac045e9aacb136a3huaweicom_" MIME-Version: 1.0 X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_433690c94ad24e06ac045e9aacb136a3huaweicom_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 DQpBY2tlZC1ieTogSmllIEhhaSA8aGFpamllMUBodWF3ZWkuY29tPG1haWx0bzpoYWlqaWUxQGh1 YXdlaS5jb20+Pg0KDQoNCg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCg0KSGFp IEppZQ0KRW1haWyjumhhaWppZTFAaHVhd2VpLmNvbTxtYWlsdG86aGFpamllMUBodWF3ZWkuY29t Pg0KDQq3orz+yMujuiBsaWh1aXNvbmcgKEMpPGxpaHVpc29uZ0BodWF3ZWkuY29tPG1haWx0bzps aWh1aXNvbmdAaHVhd2VpLmNvbT4+DQrK1bz+yMujuiBkZXY8ZGV2QGRwZGsub3JnPG1haWx0bzpk ZXZAZHBkay5vcmc+PjtmZXJydWgueWlnaXQ8ZmVycnVoLnlpZ2l0QGFtZC5jb208bWFpbHRvOmZl cnJ1aC55aWdpdEBhbWQuY29tPj47aGFpamllPGhhaWppZTFAaHVhd2VpLmNvbTxtYWlsdG86aGFp amllMUBodWF3ZWkuY29tPj47Wmh1YW5neXV6ZW5nIChZaXNlbik8eWlzZW4uemh1YW5nQGh1YXdl aS5jb208bWFpbHRvOnlpc2VuLnpodWFuZ0BodWF3ZWkuY29tPj47aHVtaW4gKFEpPGh1bWluMjlA aHVhd2VpLmNvbTxtYWlsdG86aHVtaW4yOUBodWF3ZWkuY29tPj4NCrOty82juiBsaXV5b25nbG9u ZzxsaXV5b25nbG9uZ0BodWF3ZWkuY29tPG1haWx0bzpsaXV5b25nbG9uZ0BodWF3ZWkuY29tPj47 bGlodWlzb25nIChDKTxsaWh1aXNvbmdAaHVhd2VpLmNvbTxtYWlsdG86bGlodWlzb25nQGh1YXdl aS5jb20+Pg0K1vfM4qO6IFtQQVRDSCB2MiAzLzNdIGRvYy9obnMzOiBmaXggdGhlIHVzYWdlIGRl c2NyaXB0aW9uIGZvciBSU1MgZmxvdw0KyrG85KO6IDIwMjMtMTEtMjAgMTk6MTM6NTkNCg0KVGhl IGhuczMgZHJpdmVyIHN1cHBvcnRzIGZvciBjcmVhdGluZyBydWxlIGJhc2Ugb24gaW5wdXQgdHVw bGUsIGhhc2gga2V5LA0KcXVldWVzIGFuZCBoYXNoIGFsZ29yaXRobS4gQnV0IGhhc2gga2V5LCBx dWV1ZXMgYW5kIGhhc2ggYWxnb3JpdGhtIGFyZSB0aGUNCmdsb2JhbCBjb25maWd1cmF0aW9uIGZv ciBoYXJkd2FyZSB3aGljaCB3aWxsIGFmZmVjdCBvdGhlciBydWxlcy4gVGhlIHJ1bGUNCmp1c3Qg c2V0dGluZyBpbnB1dCB0dXBsZSBpcyBjb21wbGV0ZWx5IGluZGVwZW5kZW50Lg0KDQpGaXhlczog NjNhMGY2NWM5NTcyICgiZG9jOiBhZGQgbW9yZSBkZXNjcmlwdGlvbiBpbiBobnMzIGd1aWRlIikN CkNjOiBzdGFibGVAZHBkay5vcmcNCg0KU2lnbmVkLW9mZi1ieTogSHVpc29uZyBMaSA8bGlodWlz b25nQGh1YXdlaS5jb20+DQotLS0NCiBkb2MvZ3VpZGVzL25pY3MvaG5zMy5yc3QgfCA0MiArKysr KysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tDQogMSBmaWxlIGNoYW5nZWQsIDI4 IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvZG9jL2d1aWRl cy9uaWNzL2huczMucnN0IGIvZG9jL2d1aWRlcy9uaWNzL2huczMucnN0DQppbmRleCAxMWQwYzA0 ODg0Li5lMjYwYjMwMWE4IDEwMDY0NA0KLS0tIGEvZG9jL2d1aWRlcy9uaWNzL2huczMucnN0DQor KysgYi9kb2MvZ3VpZGVzL25pY3MvaG5zMy5yc3QNCkBAIC0yMzksMzYgKzIzOSw1MCBAQCBHZW5l cmljIGZsb3cgQVBJDQoNCiAtIGBgUlNTIEZsb3dgYA0KDQotICBSU1MgRmxvdyBzdXBwb3J0cyB0 byBzZXQgaGFzaCBpbnB1dCBzZXQsIGhhc2ggZnVuY3Rpb24sIGVuYWJsZSBoYXNoDQotICBhbmQg Y29uZmlndXJlIHF1ZXVlcy4NCi0gIEZvciBleGFtcGxlOg0KLSAgQ29uZmlndXJlIHF1ZXVlcyBh cyBxdWV1ZSAwLCAxLCAyLCAzLg0KKyAgUlNTIEZsb3cgc3VwcG9ydHMgZm9yIGNyZWF0aW5nIHJ1 bGUgYmFzZSBvbiBpbnB1dCB0dXBsZSwgaGFzaCBrZXksIHF1ZXVlcw0KKyAgYW5kIGhhc2ggYWxn b3JpdGhtLiBCdXQgaGFzaCBrZXksIHF1ZXVlcyBhbmQgaGFzaCBhbGdvcml0aG0gYXJlIHRoZSBn bG9iYWwNCisgIGNvbmZpZ3VyYXRpb24gZm9yIGhhcmR3YXJlIHdoaWNoIHdpbGwgYWZmZWN0IG90 aGVyIHJ1bGVzLiBUaGUgcnVsZSBqdXN0DQorICBzZXR0aW5nIGlucHV0IHR1cGxlIGlzIGNvbXBs ZXRlbHkgaW5kZXBlbmRlbnQuDQorDQorICBSdW4gYGB0ZXN0cG1kYGA6DQoNCiAgIC4uIGNvZGUt YmxvY2s6OiBjb25zb2xlDQoNCi0gICAgdGVzdHBtZD4gZmxvdyBjcmVhdGUgMCBpbmdyZXNzIHBh dHRlcm4gZW5kIGFjdGlvbnMgcnNzIHR5cGVzIGVuZCBcDQotICAgICAgcXVldWVzIDAgMSAyIDMg ZW5kIC8gZW5kDQorICAgIGRwZGstdGVzdHBtZCAtYSAwMDAwOjdkOjAwLjAgLWwgMTAtMTggLS0g LWkgLS1yeHE9OCAtLXR4cT04DQorDQorICBBbGwgSVAgcGFja2V0cyBjYW4gYmUgZGlzdHJpYnV0 ZWQgdG8gOCBxdWV1ZXMuDQoNCi0gIEVuYWJsZSBoYXNoIGFuZCBzZXQgaW5wdXQgc2V0IGZvciBJ UHY0LVRDUC4NCisgIFNldCBpcHY0LXRjcCBwYWNrZXQgaXMgZGlzdHJpYnV0ZWQgdG8gOCBxdWV1 ZXMgYmFzZWQgb24gTDMvTDQgU1JDIG9ubHkuDQoNCiAgIC4uIGNvZGUtYmxvY2s6OiBjb25zb2xl DQoNCi0gICAgdGVzdHBtZD4gZmxvdyBjcmVhdGUgMCBpbmdyZXNzIHBhdHRlcm4gZXRoIC8gaXB2 NCAvIHRjcCAvIGVuZCBcDQotICAgICAgYWN0aW9ucyByc3MgdHlwZXMgaXB2NC10Y3AgbDMtc3Jj LW9ubHkgZW5kIHF1ZXVlcyBlbmQgLyBlbmQNCisgICAgdGVzdHBtZD4gZmxvdyBjcmVhdGUgMCBp bmdyZXNzIHBhdHRlcm4gZXRoIC8gaXB2NCAvIHRjcCAvIGVuZCBhY3Rpb25zIFwNCisgICAgICAg ICAgICAgcnNzIHR5cGVzIGlwdjQtdGNwIGw0LXNyYy1vbmx5IGwzLXNyYy1vbmx5IGVuZCBxdWV1 ZXMgZW5kIC8gZW5kDQoNCi0gIFNldCBzeW1tZXRyaWMgaGFzaCBlbmFibGUgZm9yIGZsb3cgdHlw ZSBJUHY0LVRDUC4NCisgIERpc2FibGUgaXB2NCBwYWNrZXQgUlNTIGhhc2guDQoNCiAgIC4uIGNv ZGUtYmxvY2s6OiBjb25zb2xlDQoNCi0gICAgdGVzdHBtZD4gZmxvdyBjcmVhdGUgMCBpbmdyZXNz IHBhdHRlcm4gZXRoIC8gaXB2NCAvIHRjcCAvIGVuZCBcDQotICAgICAgYWN0aW9ucyByc3MgdHlw ZXMgaXB2NC10Y3AgZW5kIHF1ZXVlcyBlbmQgZnVuYyBzeW1tZXRyaWNfdG9lcGxpdHogLyBlbmQN CisgICAgdGVzdHBtZD4gZmxvdyBjcmVhdGUgMCBpbmdyZXNzIHBhdHRlcm4gZXRoIC8gaXB2NCAv IGVuZCBhY3Rpb25zIHJzcyBcDQorICAgICAgICAgICAgIHR5cGVzIG5vbmUgZW5kIHF1ZXVlcyBl bmQgLyBlbmQNCg0KLSAgU2V0IGhhc2ggZnVuY3Rpb24gYXMgc2ltcGxlIHhvci4NCisgIFNldCBo YXNoIGZ1bmN0aW9uIGFzIHN5bW1ldHJpYyB0b2VwbGl0ei4NCg0KICAgLi4gY29kZS1ibG9jazo6 IGNvbnNvbGUNCg0KICAgICB0ZXN0cG1kPiBmbG93IGNyZWF0ZSAwIGluZ3Jlc3MgcGF0dGVybiBl bmQgYWN0aW9ucyByc3MgdHlwZXMgZW5kIFwNCi0gICAgICBxdWV1ZXMgZW5kIGZ1bmMgc2ltcGxl X3hvciAvIGVuZA0KKyAgICAgICAgICAgICBxdWV1ZXMgZW5kIGZ1bmMgc3ltbWV0cmljX3RvZXBs aXR6IC8gZW5kDQorDQorICBJbiB0aGlzIGNhc2UsIGFsbCBwYWNrZXRzIHRoYXQgZW5hYmxlZCBS U1MgYXJlIGhhc2hlZCB1c2luZyBzeW1tZXRyaWMNCisgIHRvZXBsaXR6IGFsZ29yaXRobS4NCisN CisgIEZsdXNoIGFsbCBSU1MgcnVsZXMNCisNCisgIC4uIGNvZGUtYmxvY2s6OiBjb25zb2xlDQor DQorICAgIHRlc3RwbWQ+IGZsb3cgZmx1c2ggMA0KKw0KKyAgVGhlIFJTUyBjb25maWd1cmF0aW9u cyBvZiBoYXJkd3JlIGlzIGJhY2sgdG8gdGhlIG9uZSBldGhkZXYgb3BzIHNldC4NCg0KIFN0YXRp c3RpY3MNCiAtLS0tLS0tLS0tDQotLQ0KMi4zMy4wDQoNCg== --_000_433690c94ad24e06ac045e9aacb136a3huaweicom_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

Acked-by: Jie Hai=  <haijie1@h= uawei.com>




Hai Jie
Email=A3=BAhaijie1@huawei.com

=B7=A2=BC=FE=C8=CB=A3=BA lihuisong (C)<lihuisong@huawei.com>
=CA=D5=BC=FE=C8=CB=A3=BA dev<dev@dpdk.org>;ferruh.yigit<ferruh.yigit@amd.com>;haijie<haijie1@huawei.com>;Zhuangyuzeng (Yisen)<yisen.zhuang@huawei.com>;humin (Q)<humin29@huawei.com>
=B3=AD=CB=CD=A3=BA liuyonglong<liuyonglong@huawei.com>;lihuisong (C)<lihuisong@huawei.com>
=D6=F7=CC=E2=A3=BA [PATCH v2 3/3] doc/hns3: fix the usage descr= iption for RSS flow
=CA=B1=BC=E4=A3=BA 2023-11-20 19:13:59

The hns3 driver supports for creating rule base on= input tuple, hash key,
queues and hash algorithm. But hash key, queues and hash algorithm are the<= br> global configuration for hardware which will affect other rules. The rule just setting input tuple is completely independent.

Fixes: 63a0f65c9572 ("doc: add more description in hns3 guide") Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/nics/hns3.rst | 42 ++++++++= ;+++++++++++++++= ;+++--------------
 1 file changed, 28 insertions(+), 14 deletions(-)

diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index 11d0c04884..e260b301a8 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -239,36 +239,50 @@ Generic flow API
 
 - ``RSS Flow``
 
-  RSS Flow supports to set hash input set, hash function, enable hash=
-  and configure queues.
-  For example:
-  Configure queues as queue 0, 1, 2, 3.
+  RSS Flow supports for creating rule base on input tuple, hash k= ey, queues
+  and hash algorithm. But hash key, queues and hash algorithm are= the global
+  configuration for hardware which will affect other rules. The r= ule just
+  setting input tuple is completely independent.
+
+  Run ``testpmd``:
 
   .. code-block:: console
 
-    testpmd> flow create 0 ingress pattern end actions r= ss types end \
-      queues 0 1 2 3 end / end
+    dpdk-testpmd -a 0000:7d:00.0 -l 10-18 -- -i --rxq= =3D8 --txq=3D8
+
+  All IP packets can be distributed to 8 queues.
 
-  Enable hash and set input set for IPv4-TCP.
+  Set ipv4-tcp packet is distributed to 8 queues based on L3/L4 S= RC only.
 
   .. code-block:: console
 
-    testpmd> flow create 0 ingress pattern eth / ipv4 / = tcp / end \
-      actions rss types ipv4-tcp l3-src-only end = queues end / end
+    testpmd> flow create 0 ingress pattern eth / ipv= 4 / tcp / end actions \
+           &nbs= p; rss types ipv4-tcp l4-src-only l3-src-only end queues end / end
 
-  Set symmetric hash enable for flow type IPv4-TCP.
+  Disable ipv4 packet RSS hash.
 
   .. code-block:: console
 
-    testpmd> flow create 0 ingress pattern eth / ipv4 / = tcp / end \
-      actions rss types ipv4-tcp end queues end f= unc symmetric_toeplitz / end
+    testpmd> flow create 0 ingress pattern eth / ipv= 4 / end actions rss \
+           &nbs= p; types none end queues end / end
 
-  Set hash function as simple xor.
+  Set hash function as symmetric toeplitz.
 
   .. code-block:: console
 
     testpmd> flow create 0 ingress pattern end acti= ons rss types end \
-      queues end func simple_xor / end
+           &nbs= p; queues end func symmetric_toeplitz / end
+
+  In this case, all packets that enabled RSS are hashed using sym= metric
+  toeplitz algorithm.
+
+  Flush all RSS rules
+
+  .. code-block:: console
+
+    testpmd> flow flush 0
+
+  The RSS configurations of hardwre is back to the one ethdev ops= set.
 
 Statistics
 ----------
--
2.33.0

 --_000_433690c94ad24e06ac045e9aacb136a3huaweicom_--