From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 4D74D5A71 for ; Mon, 16 May 2016 15:57:16 +0200 (CEST) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BBCCA7F0B0; Mon, 16 May 2016 13:57:15 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-57.ams2.redhat.com [10.36.4.57]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4GDvEwU021553; Mon, 16 May 2016 09:57:15 -0400 To: Fan Zhang , dev@dpdk.org References: <1463404710-25146-1-git-send-email-roy.fan.zhang@intel.com> <1463404710-25146-3-git-send-email-roy.fan.zhang@intel.com> From: Panu Matilainen Message-ID: <43389cdb-cdcd-03f3-5cf5-bd81c4a72e65@redhat.com> Date: Mon, 16 May 2016 16:57:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1463404710-25146-3-git-send-email-roy.fan.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 16 May 2016 13:57:15 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 2/2] doc: announce ABI change of struct rte_port_sink_params X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 13:57:16 -0000 On 05/16/2016 04:18 PM, Fan Zhang wrote: > The ABI changes are planned for rte_port_sink_params, which will be > supported from release 16.11. Here announces that ABI changes in detail. > > Signed-off-by: Fan Zhang > Acked-by: Cristian Dumitrescu > --- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index d228bae..d2f7306 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -78,3 +78,7 @@ Deprecation Notices > * ABI will change for rte_port_source_params struct. The member file_name > data type will be changed from char * to const char *. This change targets > release 16.11. > + > +* ABI will change for rte_port_sink_params struct. The member file_name > + data type will be changed from char * to const char *. This change targets > + release 16.11. > Surely such a minor change doesn't require two separate announcements or patches for that matter. In fact I doubt it's an ABI change at all (although it is an API change certainly). However to me the bigger issue is that a change like this alone doesn't seem like worth breaking the ABI. The ABI was just broken in 16.04 to introduce these struct members (among other things) and to break the ABI again just to fixup a const-correctness issue seems a bit much. Could it maybe wait until there's some actually compelling reason to break the ABI? Note that I'm not against the change as such, const-correctness is a good thing. - Panu -