* Re: [dpdk-dev] [PATCH] doc: announce change of rte service API parameter type
2019-01-22 5:44 [dpdk-dev] [PATCH] doc: announce change of rte service API parameter type Nikhil Rao
@ 2019-01-22 10:27 ` Van Haaren, Harry
2019-02-01 11:41 ` Kevin Traynor
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Van Haaren, Harry @ 2019-01-22 10:27 UTC (permalink / raw)
To: Rao, Nikhil, nhorman; +Cc: dev
> -----Original Message-----
> From: Rao, Nikhil
> Sent: Tuesday, January 22, 2019 5:44 AM
> To: nhorman@tuxdriver.com
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org; Rao,
> Nikhil <nikhil.rao@intel.com>
> Subject: [PATCH] doc: announce change of rte service API parameter type
>
> rte_service_attr_get() is passed a uint32_t * to retrieve
> an attribute value, this will be changed to uin64_t * as per
> patch posted at http://patchwork.dpdk.org/patch/49968/
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index f9a1f81..398e967 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -60,3 +60,6 @@ Deprecation Notices
>
> * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version
> will be
> changed from 0.49.0 to 0.52.0.
> +
> +* The attr_value parameter of rte_service_attr_get() will be changed from
> + uint32_t * to uint64_t * as the attributes are of type uint64_t.
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] doc: announce change of rte service API parameter type
2019-01-22 5:44 [dpdk-dev] [PATCH] doc: announce change of rte service API parameter type Nikhil Rao
2019-01-22 10:27 ` Van Haaren, Harry
@ 2019-02-01 11:41 ` Kevin Traynor
2019-02-01 12:01 ` Andrew Rybchenko
2019-02-01 12:01 ` David Marchand
2019-02-01 13:09 ` Thomas Monjalon
3 siblings, 1 reply; 6+ messages in thread
From: Kevin Traynor @ 2019-02-01 11:41 UTC (permalink / raw)
To: Nikhil Rao, nhorman; +Cc: harry.van.haaren, dev, Thomas Monjalon
On 01/22/2019 05:44 AM, Nikhil Rao wrote:
> rte_service_attr_get() is passed a uint32_t * to retrieve
> an attribute value, this will be changed to uin64_t * as per
> patch posted at http://patchwork.dpdk.org/patch/49968/
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index f9a1f81..398e967 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -60,3 +60,6 @@ Deprecation Notices
>
> * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version will be
> changed from 0.49.0 to 0.52.0.
> +
> +* The attr_value parameter of rte_service_attr_get() will be changed from
> + uint32_t * to uint64_t * as the attributes are of type uint64_t.
>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce change of rte service API parameter type
2019-02-01 11:41 ` Kevin Traynor
@ 2019-02-01 12:01 ` Andrew Rybchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Rybchenko @ 2019-02-01 12:01 UTC (permalink / raw)
To: Kevin Traynor, Nikhil Rao, nhorman; +Cc: harry.van.haaren, dev, Thomas Monjalon
On 2/1/19 2:41 PM, Kevin Traynor wrote:
> On 01/22/2019 05:44 AM, Nikhil Rao wrote:
>> rte_service_attr_get() is passed a uint32_t * to retrieve
>> an attribute value, this will be changed to uin64_t * as per
>> patch posted at http://patchwork.dpdk.org/patch/49968/
>>
>> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
>> ---
>> doc/guides/rel_notes/deprecation.rst | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index f9a1f81..398e967 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -60,3 +60,6 @@ Deprecation Notices
>>
>> * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version will be
>> changed from 0.49.0 to 0.52.0.
>> +
>> +* The attr_value parameter of rte_service_attr_get() will be changed from
>> + uint32_t * to uint64_t * as the attributes are of type uint64_t.
>>
> Acked-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce change of rte service API parameter type
2019-01-22 5:44 [dpdk-dev] [PATCH] doc: announce change of rte service API parameter type Nikhil Rao
2019-01-22 10:27 ` Van Haaren, Harry
2019-02-01 11:41 ` Kevin Traynor
@ 2019-02-01 12:01 ` David Marchand
2019-02-01 13:09 ` Thomas Monjalon
3 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2019-02-01 12:01 UTC (permalink / raw)
To: Nikhil Rao; +Cc: Neil Horman, harry.van.haaren, dev, Thomas Monjalon
On Tue, Jan 22, 2019 at 6:46 AM Nikhil Rao <nikhil.rao@intel.com> wrote:
> rte_service_attr_get() is passed a uint32_t * to retrieve
> an attribute value, this will be changed to uin64_t * as per
> patch posted at http://patchwork.dpdk.org/patch/49968/
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index f9a1f81..398e967 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -60,3 +60,6 @@ Deprecation Notices
>
> * crypto/aesni_mb: the minimum supported intel-ipsec-mb library version
> will be
> changed from 0.49.0 to 0.52.0.
> +
> +* The attr_value parameter of rte_service_attr_get() will be changed from
> + uint32_t * to uint64_t * as the attributes are of type uint64_t.
>
Should the version in which the change is going to occur be part of the
notice ?
Apart from this, and since it fixes a problem in (mostly unused)
rte_service_attr_get() api,
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce change of rte service API parameter type
2019-01-22 5:44 [dpdk-dev] [PATCH] doc: announce change of rte service API parameter type Nikhil Rao
` (2 preceding siblings ...)
2019-02-01 12:01 ` David Marchand
@ 2019-02-01 13:09 ` Thomas Monjalon
3 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-02-01 13:09 UTC (permalink / raw)
To: Nikhil Rao; +Cc: dev, nhorman, harry.van.haaren
22/01/2019 06:44, Nikhil Rao:
> rte_service_attr_get() is passed a uint32_t * to retrieve
> an attribute value, this will be changed to uin64_t * as per
> patch posted at http://patchwork.dpdk.org/patch/49968/
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: David Marchand <david.marchand@redhat.com>
Applied with some format changes, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread