From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 90DA5C398
 for <dev@dpdk.org>; Fri, 10 Jul 2015 16:49:36 +0200 (CEST)
Received: by wgxm20 with SMTP id m20so68066503wgx.3
 for <dev@dpdk.org>; Fri, 10 Jul 2015 07:49:36 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=d5JQldcysoN1lw7voKKs/w8zVjXSneZS2UjNTqosptE=;
 b=Srw5CwMcIrhyLIs2agUGrvN1domMroLT82sNQJ2Wla6J9JLcJoFw1wborOeORUa+fc
 FPv0EqKYjPdNBpLDxHO3MTHBE74/Fg+SA4ZAnk63ZO+oZsvoZY5hWw7holDisEuo8dF8
 AChYysg+Za7quXTz1DW9TwTD0FwkvQ94mYSBzianDlQidkCeP9KddAd1XEJydBDIfuaG
 Cg7p3FSKl7N35Tgd1aT0UDY6Orxqn/2oPcnhS7yUA8UUnwzCWG5R9VZGCbyg93ZQN29l
 KCA2YWZNghs72nO6pSKbBttA/D8sm+nMC7Hasekbq0wXjGPxgzWYIjESVWYhiZSoc8Zg
 Fqxg==
X-Gm-Message-State: ALoCoQmy9YMHEbHmcRi8B2RkYAs66C5zxsWlT25kj2PvLkxyF1wZncJ9rsNf1kguPit8so5RZSQJ
X-Received: by 10.180.36.129 with SMTP id q1mr7166240wij.10.1436539776387;
 Fri, 10 Jul 2015 07:49:36 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id q9sm3250819wiz.23.2015.07.10.07.49.34
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 10 Jul 2015 07:49:35 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: motomu <motomu@hongo.wide.ad.jp>
Date: Fri, 10 Jul 2015 16:48:27 +0200
Message-ID: <4340982.5yr692ncls@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1432484252-3517-1-git-send-email-motomu@hongo.wide.ad.jp>
References: <1432484252-3517-1-git-send-email-motomu@hongo.wide.ad.jp>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] drivers/net/e1000/igb_ethdev.c:fix
	eth_igb_add_del_flex_filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Jul 2015 14:49:36 -0000

We definitely need a maintainer for e1000.

2015-05-24 16:17, motomu:
> From: Motomu Utsumi <motomu@hongo.wide.ad.jp>
> 
> in add flexfiler it always write to same register address,
> so when try to adapt some filters only last one is enabled.
> I substitute value based on based on flex_filter->index for reg_off.
> 
> in del flexfilter, it delete target filter and 
> also delete first filter because of similar reason.
> I substitute value based on based on it->index for reg_off.

You forgot a Signed-off.

[...]
>  		}
> +    if (flex_filter->index < E1000_MAX_FHFT)
> +      reg_off = E1000_FHFT(flex_filter->index);
> +    else
> +      reg_off = E1000_FHFT_EXT(flex_filter->index - E1000_MAX_FHFT);

On the formatting side, it seems indent is wrong.