From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 26DE2592E for ; Tue, 4 Nov 2014 06:18:47 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 03 Nov 2014 21:28:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,311,1413270000"; d="scan'208";a="630915096" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga002.jf.intel.com with ESMTP; 03 Nov 2014 21:28:03 -0800 Received: from pgsmsx105.gar.corp.intel.com (10.221.44.96) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 4 Nov 2014 13:26:30 +0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by pgsmsx105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 4 Nov 2014 13:26:30 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.156]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.202]) with mapi id 14.03.0195.001; Tue, 4 Nov 2014 13:26:29 +0800 From: "Chen, Jing D" To: Thomas Monjalon Thread-Topic: [PATCH v2 2/6] igb: change for VMDQ arguments expansion Thread-Index: AQHP6SkWryHf9LM1rUeN06QpWdfAcZxO0fMAgAE6ZqA= Date: Tue, 4 Nov 2014 05:26:28 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D01606176@shsmsx102.ccr.corp.intel.com> References: <1411478047-1251-2-git-send-email-jing.d.chen@intel.com> <1413454046-13407-1-git-send-email-jing.d.chen@intel.com> <1413454046-13407-3-git-send-email-jing.d.chen@intel.com> <2027422.tgQyvDmmaG@xps13> In-Reply-To: <2027422.tgQyvDmmaG@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 2/6] igb: change for VMDQ arguments expansion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Nov 2014 05:18:48 -0000 Hi,=20 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, November 04, 2014 2:37 AM > To: Chen, Jing D > Cc: dev@dpdk.org; Ananyev, Konstantin > Subject: Re: [PATCH v2 2/6] igb: change for VMDQ arguments expansion >=20 > 2014-10-16 18:07, Chen Jing D: > > --- a/lib/librte_pmd_e1000/igb_ethdev.c > > +++ b/lib/librte_pmd_e1000/igb_ethdev.c > > @@ -1286,18 +1286,21 @@ eth_igb_infos_get(struct rte_eth_dev *dev, > > dev_info->max_rx_queues =3D 16; > > dev_info->max_tx_queues =3D 16; > > dev_info->max_vmdq_pools =3D ETH_8_POOLS; > > + dev_info->vmdq_queue_num =3D 16; > > break; > > > > case e1000_82580: > > dev_info->max_rx_queues =3D 8; > > dev_info->max_tx_queues =3D 8; > > dev_info->max_vmdq_pools =3D ETH_8_POOLS; > > + dev_info->vmdq_queue_num =3D 8; > > break; > > > > case e1000_i350: > > dev_info->max_rx_queues =3D 8; > > dev_info->max_tx_queues =3D 8; > > dev_info->max_vmdq_pools =3D ETH_8_POOLS; > > + dev_info->vmdq_queue_num =3D 8; > > break; >=20 > Why not simply set it only once? > dev_info->vmdq_queue_num =3D dev_info->max_rx_queues; There are some other NIC types in this 'switch'. Vmdq_queue_num is set in = case max_vmdq_pools is not 0. >=20 > -- > Thomas