From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jing.d.chen@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id E741A8032
 for <dev@dpdk.org>; Thu,  4 Dec 2014 15:30:45 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP; 04 Dec 2014 06:29:20 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="425048305"
Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80])
 by FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2014 06:18:58 -0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Thu, 4 Dec 2014 22:29:17 +0800
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.216]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.86]) with mapi id 14.03.0195.001;
 Thu, 4 Dec 2014 22:29:16 +0800
From: "Chen, Jing D" <jing.d.chen@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
Thread-Index: AQHQD6e5LtHHrZY+mk2pPcece2l9IZx+s+sAgACGyJD//3zhAIAAwoFw
Date: Thu, 4 Dec 2014 14:29:15 +0000
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D0162B469@shsmsx102.ccr.corp.intel.com>
References: <1417686605-6778-1-git-send-email-jing.d.chen@intel.com>
 <4822681.F5vea3YAsE@xps13>
 <4341B239C0EFF9468EE453F9E9F4604D0162B2C6@shsmsx102.ccr.corp.intel.com>
 <2122900.sczHU7BWUg@xps13>
In-Reply-To: <2122900.sczHU7BWUg@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Dec 2014 14:30:46 -0000



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, December 4, 2014 6:39 PM
> To: Chen, Jing D
> Cc: dev@dpdk.org; Qiu, Michael
> Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
>=20
> 2014-12-04 10:30, Chen, Jing D:
> > As I don't know what commit he is based on, I'd like to generate a new
> patch with latest dpdk repo.
>=20
> There's something wrong here. You rework a patch and you don't know what
> was the current status but you expect that the reviewers can understand i=
t
> better than you?

You don't understand me. Please read my above words again.
As I said, he is in vacation, I came to fix problem. I know exactly what's =
the problem. So, I used simple way.=20

> You are breaking all the elementary rules of patch management.

Please kindly list all the elementary rules of patch management, please. If=
 possible, can you post it somewhere so other new guys can find and follow?

> We have currently 2 fixes pending for the same bug.
>=20
> PS: please don't top post.

I apologized for top post.=20

>=20
> --
> Thomas
>=20
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > Sent: Thursday, December 04, 2014 6:26 PM
> > > To: Chen, Jing D
> > > Cc: dev@dpdk.org; Qiu, Michael
> > > Subject: Re: [dpdk-dev] [PATCH] i40e: Fix a vlan bug
> > >
> > > 2014-12-04 10:18, Qiu, Michael:
> > > > Hi Mark,
> > > >
> > > > I think Huawei (huawei.xie@intel.com) has one patch set to fix this
> issue.
> > > >
> > > > If your patch is totally different with him:
> > > >
> > > > [dpdk-dev] [PATCH v4 0/2] lib/librte_pmd_i40e: set vlan filter fix
> > > >
> > > > please ignore my comments :)
> > > >
> > > > But you both calculation are different.
> > >
> > > Yes, please Jing (Mark), if you reworked the v4 patch, it would
> > > clearer to have a changelog, to name it v5 and to insert it in the
> > > previous thread with --in-reply-to.
> > > At the moment, both patches block each other.
> > >
> > > --
> > > Thomas