From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E7BA42A61 for ; Mon, 2 Feb 2015 09:10:32 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 02 Feb 2015 00:07:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,505,1418112000"; d="scan'208";a="660195288" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga001.fm.intel.com with ESMTP; 02 Feb 2015 00:10:22 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 2 Feb 2015 16:10:19 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.91]) with mapi id 14.03.0195.001; Mon, 2 Feb 2015 16:10:19 +0800 From: "Chen, Jing D" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH 18/18] Change mk/rte.app.mk to add fm10k lib into link Thread-Index: AQHQPErZgYv4Q3hPg028FpzThf0rCJzac5eAgAKQU+A= Date: Mon, 2 Feb 2015 08:10:17 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D016631DC@shsmsx102.ccr.corp.intel.com> References: <1422594454-11045-1-git-send-email-jing.d.chen@intel.com> <1422594454-11045-19-git-send-email-jing.d.chen@intel.com> <20150201005059.GC31443@localhost.localdomain> In-Reply-To: <20150201005059.GC31443@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 18/18] Change mk/rte.app.mk to add fm10k lib into link X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Feb 2015 08:10:33 -0000 Hi Neil, > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Sunday, February 01, 2015 8:51 AM > To: Chen, Jing D > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 18/18] Change mk/rte.app.mk to add fm10k > lib into link >=20 > On Fri, Jan 30, 2015 at 01:07:34PM +0800, Chen Jing D(Mark) wrote: > > From: Jeff Shaw > > > > Signed-off-by: Jeff Shaw > > Signed-off-by: Chen Jing D(Mark) > > --- > > mk/rte.app.mk | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > > index 4294d9a..87d8763 100644 > > --- a/mk/rte.app.mk > > +++ b/mk/rte.app.mk > > @@ -211,6 +211,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_I40E_PMD),y) > > LDLIBS +=3D -lrte_pmd_i40e > > endif > > > > +ifeq ($(CONFIG_RTE_LIBRTE_FM10K_PMD),y) > > +LDLIBS +=3D -lrte_pmd_fm10k > > +endif > > + > > ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > > LDLIBS +=3D -lrte_pmd_ixgbe > > endif > > -- > > 1.7.7.6 > > > > > This patch should be merged with patch 17, and patch 2, and placed at the > end of > your series to avoid a FTBFS issue My rationale is to make every single patch not to break the compile. So, I'= d like to add the binary library into compile and link in last 2 patches, after all t= he actual code are patched. For Patch 2, I think you are right, maybe a better way is to = move it as=20 patch "16".=20 But I'm not sure whether I should merge these 3 together. You know, somebod= y may not happy to see the changes in different directory to appear in single pat= ch. =20 > Neil