From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 302F29AA4 for ; Tue, 3 Feb 2015 07:48:01 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 02 Feb 2015 22:44:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,511,1418112000"; d="scan'208";a="660699026" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by fmsmga001.fm.intel.com with ESMTP; 02 Feb 2015 22:47:58 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 3 Feb 2015 14:47:14 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.161]) with mapi id 14.03.0195.001; Tue, 3 Feb 2015 14:47:13 +0800 From: "Chen, Jing D" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH 03/18] fm10k: Add empty fm10k files Thread-Index: AQHQPErIuHHy5Tg05UC3lptn6sYToJzZvkQAgAMW9JCAAAc7AIABpTgw Date: Tue, 3 Feb 2015 06:47:13 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D01664DEE@shsmsx102.ccr.corp.intel.com> References: <1422594454-11045-1-git-send-email-jing.d.chen@intel.com> <1422594454-11045-4-git-send-email-jing.d.chen@intel.com> <20150131140200.GA22012@localhost.localdomain> <4341B239C0EFF9468EE453F9E9F4604D01661FA5@shsmsx102.ccr.corp.intel.com> <20150202133848.GA21700@hmsreliant.think-freely.org> In-Reply-To: <20150202133848.GA21700@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 03/18] fm10k: Add empty fm10k files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 06:48:01 -0000 Hi Neil, > -----Original Message----- > From: Neil Horman [mailto:nhorman@tuxdriver.com] > Sent: Monday, February 02, 2015 9:39 PM > To: Chen, Jing D > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 03/18] fm10k: Add empty fm10k files >=20 > On Mon, Feb 02, 2015 at 05:34:43AM +0000, Chen, Jing D wrote: > > Hi Neil, > > > > > -----Original Message----- > > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > > Sent: Saturday, January 31, 2015 10:02 PM > > > To: Chen, Jing D > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 03/18] fm10k: Add empty fm10k files > > > > > > On Fri, Jan 30, 2015 at 01:07:19PM +0800, Chen Jing D(Mark) wrote: > > > > From: Jeff Shaw > > > > > > > > Define macros and basic data structure. > > > > Define rte_log wrapper functions. > > > > > > > > Signed-off-by: Jeff Shaw > > > > Signed-off-by: Chen Jing D(Mark) > > > > --- > > > > lib/librte_pmd_fm10k/Makefile | 96 ++++++++++++++++ > > > > lib/librte_pmd_fm10k/fm10k.h | 224 > > > +++++++++++++++++++++++++++++++++++++ > > > > lib/librte_pmd_fm10k/fm10k_logs.h | 66 +++++++++++ > > > > 3 files changed, 386 insertions(+), 0 deletions(-) > > > > create mode 100644 lib/librte_pmd_fm10k/Makefile > > > > create mode 100644 lib/librte_pmd_fm10k/fm10k.h > > > > create mode 100644 lib/librte_pmd_fm10k/fm10k_ethdev.c > > > > create mode 100644 lib/librte_pmd_fm10k/fm10k_logs.h > > > > create mode 100644 lib/librte_pmd_fm10k/fm10k_rxtx.c > > > > > > > Why are you adding empty files? > > > > The 2 ".c" files are empty while the 2 ".h" files include code. "Makefi= le" > includes rules to > > compile the ".c" files, I don't like to break the compile for every sin= gle patch, > that's why > > the 2 ".c" files are added in this patch. > > > That doesn't really answer the question. Theres no need to add empty fil= es > here. Just add the headers alone and add the empy files on the first com= mit > where you have code to put in them. Adjust the makefile so that you add > them > into the compilation in the same commit that you populate the file to avo= id a > FTBFS error. > Neil Got you. I'll add the content with new files. Thanks! >=20 > > > > > > Neil > > > > Thanks for your comments. > > Mark > >