From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 86EF09E5 for ; Tue, 21 Jul 2015 09:15:26 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 21 Jul 2015 00:15:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,514,1432623600"; d="scan'208";a="732579178" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by orsmga001.jf.intel.com with ESMTP; 21 Jul 2015 00:15:23 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 21 Jul 2015 15:15:22 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.165]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.46]) with mapi id 14.03.0224.002; Tue, 21 Jul 2015 15:15:21 +0800 From: "Chen, Jing D" To: Stephen Hemminger , "Qiu, Michael" Thread-Topic: [PATCH] fm10K: fix interrupt fault handling Thread-Index: AQHQwCgy1JlFHX+8r0eafxXKNmUZ/53liVNA Date: Tue, 21 Jul 2015 07:15:21 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D0172404A@shsmsx102.ccr.corp.intel.com> References: <1437093202-30265-1-git-send-email-stephen@networkplumber.org> In-Reply-To: <1437093202-30265-1-git-send-email-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] fm10K: fix interrupt fault handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2015 07:15:27 -0000 Hi, Stephen, > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, July 17, 2015 8:33 AM > To: Qiu, Michael; Chen, Jing D > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [PATCH] fm10K: fix interrupt fault handling >=20 > The fm10k driver was reading the interrupt cause register but then > using the interrupt mask register defines to look at the bits. > The result is that if a fault happens, the driver would never clear > the fault and would get into an infinite cycle of interrupts. >=20 > Note: I don't work for Intel or have the hardware manuals (probably > requires NDA anyway), but this looks logical and matches how the > known working Linux driver handles these bits. >=20 > Signed-off-by: Stephen Hemminger Good catch! Thanks! Acked-by: Jing Chen