From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id CCF975682 for ; Tue, 27 Oct 2015 06:26:08 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 26 Oct 2015 22:26:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,203,1444719600"; d="scan'208";a="835818371" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 26 Oct 2015 22:26:07 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 26 Oct 2015 22:26:07 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.253]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.106]) with mapi id 14.03.0248.002; Tue, 27 Oct 2015 13:26:03 +0800 From: "Chen, Jing D" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v2 01/16] fm10k: add new vPMD file Thread-Index: AQHRDK5iSw5jVMt6eU+fXhIjA4klGJ53JZAAgAGc0PD//5GogIAGgURQ Date: Tue, 27 Oct 2015 05:26:03 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D02AE4A29@shsmsx102.ccr.corp.intel.com> References: <1443531824-22767-2-git-send-email-jing.d.chen@intel.com> <1445507104-22563-1-git-send-email-jing.d.chen@intel.com> <1445507104-22563-2-git-send-email-jing.d.chen@intel.com> <20151022085840.1d082e75@xeon-e3> <4341B239C0EFF9468EE453F9E9F4604D02AE290A@shsmsx102.ccr.corp.intel.com> <20151023100115.GB8464@bricha3-MOBL3> In-Reply-To: <20151023100115.GB8464@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 01/16] fm10k: add new vPMD file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2015 05:26:09 -0000 Hi, Bruce, Best Regards, Mark > -----Original Message----- > From: Richardson, Bruce > Sent: Friday, October 23, 2015 6:01 PM > To: Chen, Jing D > Cc: Stephen Hemminger; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 01/16] fm10k: add new vPMD file >=20 > On Fri, Oct 23, 2015 at 08:39:56AM +0000, Chen, Jing D wrote: > > Hi, Stephen, > > > > Best Regards, > > Mark > > > > > > > -----Original Message----- > > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > Sent: Thursday, October 22, 2015 11:59 PM > > > To: Chen, Jing D > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v2 01/16] fm10k: add new vPMD file > > > > > > On Thu, 22 Oct 2015 17:44:49 +0800 > > > "Chen Jing D(Mark)" wrote: > > > > > > > +#ifndef __INTEL_COMPILER > > > > +#pragma GCC diagnostic ignored "-Wcast-qual" > > > > +#endif > > > > > > Since this is new code, can't you make it work correctly > > > with Gcc. Rather than turning off a useful diagnostic. > > > > This macro is necessary for later SSE functions or I'll have to add som= e > > Un-necessary cast to avoid compile failure. > > > > I can add it in later patch. But it will have to show up anyway, right? >=20 > Actually, casting won't make the warnings go away either. You'll always g= et a > warning about removing the volatile from the structure members when you > pass > them to the intrinsic functions. Only option is to temporarily disable th= e > warning > [or else write your own versions of the intrinsics that do support volati= les :-)] >=20 > /Bruce Thanks for the clarifications. :)