From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5AB9A8D39 for ; Thu, 10 Dec 2015 07:36:33 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 09 Dec 2015 22:36:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,407,1444719600"; d="scan'208";a="10747850" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 09 Dec 2015 22:36:32 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Dec 2015 22:36:32 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 9 Dec 2015 22:36:31 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.158]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.28]) with mapi id 14.03.0248.002; Thu, 10 Dec 2015 14:36:30 +0800 From: "Chen, Jing D" To: "Mcnamara, John" , "dev@dpdk.org" Thread-Topic: [PATCH] doc: add fm10k driver Thread-Index: AQHRMlsmFTcoS9TeL0Gyl9d7dr3KTp7CLr8AgAGWlCA= Date: Thu, 10 Dec 2015 06:36:29 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D03E84A78@shsmsx102.ccr.corp.intel.com> References: <1449649486-22505-1-git-send-email-jing.d.chen@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: add fm10k driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Dec 2015 06:36:34 -0000 Hi, John, Best Regards, Mark > -----Original Message----- > From: Mcnamara, John > Sent: Wednesday, December 09, 2015 10:21 PM > To: Chen, Jing D; dev@dpdk.org > Subject: RE: [PATCH] doc: add fm10k driver >=20 > > -----Original Message----- > > From: Chen, Jing D > > Sent: Wednesday, December 9, 2015 8:25 AM > > To: dev@dpdk.org > > Cc: Mcnamara, John; Chen, Jing D > > Subject: [PATCH] doc: add fm10k driver > > > > From: "Chen Jing D(Mark)" > > > > This documentation covers introdutions and limitations on Intel > > FM10000 series products. >=20 > Hi Mark, >=20 > Thanks for that. >=20 > The docs build cleanly but there is one whitespace warning on merge. >=20 > Minor comments below. >=20 >=20 >=20 > > @@ -0,0 +1,54 @@ > > +.. BSD LICENSE > > + Copyright(c) 2010-2015 Intel Corporation. All rights reserved. >=20 > The year should be 2015 only and this line shouldn't be indented in relat= ion > to the next lines. >=20 >=20 >=20 > > +FM10K Poll Mode Driver > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > +The FM10K poll mode driver library provides support for Intel FM10000 > > +family of 40GbE/100GbE adapters. >=20 > The DPDK Documentation Guidelines say to leave a blank line after section > headers (here and with the other sections): >=20 > > +FM10K Poll Mode Driver > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > +The FM10K poll mode driver library provides support for Intel FM10000 > > +family of 40GbE/100GbE adapters. >=20 > See: http://dpdk.org/doc/guides/contributing/documentation.html#rst- > guidelines >=20 >=20 > > +The FM10K poll mode driver library provides support for Intel FM10000 > > +family of 40GbE/100GbE adapters. >=20 > Might be worth introducing the common FM10K name here as well: >=20 > The FM10K poll mode driver library provides support for the Intel FM10000 > (FM10K) family of 40GbE/100GbE adapters. >=20 > > +Intel FM10000 family of NICs integrate an hardware switch and multiple > > +host interfaces. FM10K PMD driver only manages host interfaces. For th= e >=20 > The doc uses FM10000 in some places and FM10K in others. It should use on= e > or the other consistently. >=20 >=20 >=20 > > +switch component, another switch driver has to be loaded prior to FM10= K > > PMD driver. > > +The switch driver either can be acquired by Intel support or from belo= w > > link: > > +https://github.com/match-interface >=20 > Better to add an actual link like: >=20 > The switch driver can be acquired for Intel support or from the > `Match Interface `_ project. >=20 > Also should that be to: https://github.com/match-interface/match >=20 >=20 >=20 > > + > > +CRC strip > > +FM10000 family always strip CRC for every packets coming into host > > interface. >=20 >=20 > Limitations > ----------- >=20 > Switch manager > ~~~~~~~~~~~~~~ >=20 > The Intel FM10000 family of NICs integrate a hardware switch and multiple > host >=20 > Etc. >=20 > > +Max packet length > > +FM10000 family support maximum of 15K jumbo frame. The value is fixed > > +and can't be changed. So, even (struct > > +rte_eth_conf).rxmode.max_rx_pkt_len is set to a value other than 15364= , > > the frames with 15364 byte still can reach to host interface. >=20 > This isn't clear (to me). Maybe something like: >=20 > The FM10000 family of NICS support a maximum of a 15K jumbo frame. The > value > is fixed and cannot be changed. So, even when the > ``rxmode.max_rx_pkt_len`` > member of ``struct rte_eth_conf`` is set to a value lower than 15364, fra= mes > up to 15364 bytes can still reach the host interface. >=20 >=20 > Regards, >=20 > John. > -- Many thanks for the comments, I'll change accordingly.