From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B191E2965 for ; Thu, 24 Mar 2016 07:40:20 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 23 Mar 2016 23:40:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,383,1455004800"; d="scan'208";a="72301129" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 23 Mar 2016 23:40:19 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 23 Mar 2016 23:40:19 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 23 Mar 2016 23:40:19 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.132]) with mapi id 14.03.0248.002; Thu, 24 Mar 2016 14:40:18 +0800 From: "Chen, Jing D" To: Michael Frasca CC: "dev@dpdk.org" Thread-Topic: [PATCH] fm10k: conditionally disable RSS during device initialization Thread-Index: AQHRhFwMr7xmNRmhZEecE+5QpXRtrZ9mWouQgAAqWACAAZ/mwA== Date: Thu, 24 Mar 2016 06:40:17 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D04465361@shsmsx102.ccr.corp.intel.com> References: <1458665888-4577-1-git-send-email-michael.frasca@oracle.com> <4341B239C0EFF9468EE453F9E9F4604D04464381@shsmsx102.ccr.corp.intel.com> <8634D5E0-C1B2-4194-B9A4-E0BDC982B36B@oracle.com> In-Reply-To: <8634D5E0-C1B2-4194-B9A4-E0BDC982B36B@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fm10k: conditionally disable RSS during device initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2016 06:40:21 -0000 Hi, Frasca, > -----Original Message----- > From: Michael Frasca [mailto:michael.frasca@oracle.com] > Sent: Wednesday, March 23, 2016 9:43 PM > To: Chen, Jing D > Cc: dev@dpdk.org > Subject: Re: [PATCH] fm10k: conditionally disable RSS during device > initialization >=20 > Hi Jing, >=20 > I ran into this issue while trying to run experiments with different RSS > configurations (no RSS being one cases). It is not clear to me that setti= ng this > register to zero is the best way to disable RSS. >=20 > After digging further, I have a theory that I'm having this issues becaus= e I've > only attached my DPDK application to SR-IOV ports. In > fm10k_dev_dglort_map_configure(), I see that 'RSS Length' is set for the > DGLORT > decoder. However, it appears that this is only invoked for physical funct= ions. >=20 > Could this be my problem? Is it required that I bind to the physical func= tion > if I want to properly manipulate RSS? >=20 > Thanks, > Mike >=20 I don't know exactly what problem you ran into. I think we needn't worry ab= out=20 those DGLORT setting when using VF device. I've followed steps to use SRIOV device with RSS enabled and disabled, both are worked well from my side after applying your patch. Below is my setup. 1. PF with Linux driver "fm10k-next_0.19.3". 2. DPDK with latest code from master branch, apply your patch. 3. Use 1 VF device created by kernel driver. 4. use l3fwd with " ./examples/l3fwd/build/l3fwd -c fc -n 4 -- -p 0x1 --con= fig=3D"(0,0,2),(0,1,2),(0,2,3),(0,3,3)"" with RSS enabled. After sending packets, I can see all 4 queues receive= d packets. 5. use l3fwd with " ./examples/l3fwd/build/l3fwd -c fc -n 4 -- -p 0x1 --con= fig=3D"(0,0,2)"" with RSS disabled. After sending packets, I can see queue 0 received pa= ckets. Can you explain what actual problem is? We can talk offline.