From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 433652C06 for ; Mon, 18 Apr 2016 10:42:03 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 18 Apr 2016 01:42:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,501,1455004800"; d="scan'208";a="934627758" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 18 Apr 2016 01:42:02 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 18 Apr 2016 01:41:05 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 18 Apr 2016 01:41:01 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.232]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.229]) with mapi id 14.03.0248.002; Mon, 18 Apr 2016 16:40:59 +0800 From: "Chen, Jing D" To: Michael Frasca CC: "dev@dpdk.org" Thread-Topic: [PATCH] fm10k: set packet type for multi-segment packets Thread-Index: AQHRloR8Zb8e07jdqUqw0xvy4e08z5+PbMZQ Date: Mon, 18 Apr 2016 08:40:59 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D0448821D@shsmsx102.ccr.corp.intel.com> References: <1460662340-18034-1-git-send-email-michael.frasca@oracle.com> In-Reply-To: <1460662340-18034-1-git-send-email-michael.frasca@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fm10k: set packet type for multi-segment packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2016 08:42:03 -0000 Hi, Frasca, > -----Original Message----- > From: Michael Frasca [mailto:michael.frasca@oracle.com] > Sent: Friday, April 15, 2016 3:32 AM > To: Chen, Jing D > Cc: dev@dpdk.org; Michael Frasca > Subject: [PATCH] fm10k: set packet type for multi-segment packets >=20 > When building a chain of mbufs for a multi-segment packet, the > packet_type field resides at the end of the chain. It should be > copied forward to the head of the list. >=20 > Fixes: fe65e1e1ce61 ("fm10k: add vector scatter Rx") >=20 > Signed-off-by: Michael Frasca > --- > drivers/net/fm10k/fm10k_rxtx_vec.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/fm10k/fm10k_rxtx_vec.c > b/drivers/net/fm10k/fm10k_rxtx_vec.c > index f8efe8f..66f126f 100644 > --- a/drivers/net/fm10k/fm10k_rxtx_vec.c > +++ b/drivers/net/fm10k/fm10k_rxtx_vec.c > @@ -608,6 +608,7 @@ fm10k_reassemble_packets(struct fm10k_rx_queue > *rxq, > /* it's the last packet of the set */ > start->hash =3D end->hash; > start->ol_flags =3D end->ol_flags; > + start->packet_type =3D end->packet_type; > pkts[pkt_idx++] =3D start; > start =3D end =3D NULL; > } > -- > 2.5.0 Good catch. Just one comment. We'll parse packet type until=20 "RTE_LIBRTE_FM10K_RX_OLFLAGS_ENABLE" is applied. Can we add this macro for your change? Same to "hash" and "olf_flags". Best Regards, Mark