From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jing.d.chen@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 22E6E2B9D
 for <dev@dpdk.org>; Thu, 21 Jul 2016 10:48:36 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga102.fm.intel.com with ESMTP; 21 Jul 2016 01:48:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,398,1464678000"; d="scan'208";a="850458263"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
 by orsmga003.jf.intel.com with ESMTP; 21 Jul 2016 01:48:31 -0700
Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 21 Jul 2016 01:48:31 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 21 Jul 2016 01:48:31 -0700
Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.8]) with mapi id 14.03.0248.002;
 Thu, 21 Jul 2016 16:48:29 +0800
From: "Chen, Jing D" <jing.d.chen@intel.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Lin, Xueqin" <xueqin.lin@intel.com>
Thread-Topic: [PATCH] net/fm10k: fix RSS hash config
Thread-Index: AQHR4ylUxz43l/qlu0q4Sqo5t+jhr6Aikg7g
Date: Thu, 21 Jul 2016 08:48:29 +0000
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D044DECE4@shsmsx102.ccr.corp.intel.com>
References: <1469089470-5764-1-git-send-email-xiao.w.wang@intel.com>
In-Reply-To: <1469089470-5764-1-git-send-email-xiao.w.wang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] net/fm10k: fix RSS hash config
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Jul 2016 08:48:37 -0000

Hi,

> diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_e=
thdev.c
> index 144b2de..01f4a72 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -2159,8 +2159,8 @@ fm10k_rss_hash_update(struct rte_eth_dev *dev,
>=20
>  	PMD_INIT_FUNC_TRACE();
>=20
> -	if (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *
> -		FM10K_RSSRK_ENTRIES_PER_REG)
> +	if (key && (rss_conf->rss_key_len < FM10K_RSSRK_SIZE *
> +				FM10K_RSSRK_ENTRIES_PER_REG))
>  		return -EINVAL;
>=20
>  	if (hf =3D=3D 0)

It's also possible that app wants to update rss key and not expect to updat=
e hash
function.
Is that indicate we shouldn't return error in case hf =3D=3D 0?