From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jing.d.chen@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 30B8D2B8E for <dev@dpdk.org>; Wed, 7 Dec 2016 16:33:25 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP; 07 Dec 2016 07:33:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="40059459" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 07 Dec 2016 07:33:02 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Dec 2016 07:33:02 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.142]) with mapi id 14.03.0248.002; Wed, 7 Dec 2016 23:33:00 +0800 From: "Chen, Jing D" <jing.d.chen@intel.com> To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v2 29/32] net/i40e: parse more VF parameter and configure Thread-Index: AQHSUDqbletdmO52FEqayj47Xa92kaD8E96AgACJUaA= Date: Wed, 7 Dec 2016 15:32:59 +0000 Message-ID: <4341B239C0EFF9468EE453F9E9F4604D3A3C3471@shsmsx102.ccr.corp.intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-30-git-send-email-wenzhuo.lu@intel.com> <f1fc596a-0bbb-5911-fa97-c751ab2b03e0@intel.com> In-Reply-To: <f1fc596a-0bbb-5911-fa97-c751ab2b03e0@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWRhN2I4NDgtOTg5MS00YzkwLWI3ZGUtMzk3YTMzMzFmNzQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlQ5MklrektzZ0VVTDdyd2Z5TGhBbVgzWE1ZQ01nS2xzYkp5R1ZGRlZwK2c9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 29/32] net/i40e: parse more VF parameter and configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 07 Dec 2016 15:33:26 -0000 Hi, Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 11:19 PM > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org > Cc: Chen, Jing D <jing.d.chen@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2 29/32] net/i40e: parse more VF paramete= r > and configure >=20 > On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > > When VF requested to configure TX queue, a few parameters are missed > > to be configured in PF host. This change have more fields parsed and > > configured for TX context. >=20 > What is the effect of missing Tx paramters configured? >=20 > If this cause a bug, this patch should be a fix. >=20 This need to analyze case by case. If PF driver is serving a DPDK VF client= ,=20 the missing part is OK. If serving a Linux VF client, the missing part will= =20 cause some unexpected TX queue behaviors.=20 So, this is an enhancement to support Linux VF client.=20 > > > > Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com> > > --- > > drivers/net/i40e/i40e_pf.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c > > index 8319c2c..1ad5ed1 100644 > > --- a/drivers/net/i40e/i40e_pf.c > > +++ b/drivers/net/i40e/i40e_pf.c > > @@ -422,10 +422,12 @@ > > > > /* clear the context structure first */ > > memset(&tx_ctx, 0, sizeof(tx_ctx)); > > - tx_ctx.new_context =3D 1; > > tx_ctx.base =3D txq->dma_ring_addr / I40E_QUEUE_BASE_ADDR_UNIT; > > tx_ctx.qlen =3D txq->ring_len; > > tx_ctx.rdylist =3D rte_le_to_cpu_16(vf->vsi->info.qs_handle[0]); > > + tx_ctx.head_wb_ena =3D txq->headwb_enabled; > > + tx_ctx.head_wb_addr =3D txq->dma_headwb_addr; > > + > > err =3D i40e_clear_lan_tx_queue_context(hw, abs_queue_id); > > if (err !=3D I40E_SUCCESS) > > return err; > >