[dpdk-dev] [PATCH RFC] eal: remove useless output

[dpdk-dev] [PATCH RFC] eal: remove useless output

[David Marchand]

From: Didier Pallard <didier.pallard@6wind.com>

Increasing maximum number of lcores gives a huge place to undetected
lcores in output traces. Moreover, this output does not give any
interesting information, since list of undetected lcores can be deduced
from list of detected ones.
So remove output related to undetected cores.

Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
---
 lib/librte_eal/bsdapp/eal/eal_lcore.c   |    1 -
 lib/librte_eal/linuxapp/eal/eal_lcore.c |    1 -
 2 files changed, 2 deletions(-)

diff --git a/lib/librte_eal/bsdapp/eal/eal_lcore.c b/lib/librte_eal/bsdapp/eal/eal_lcore.c
index e2f3793..81b5f13 100644
--- a/lib/librte_eal/bsdapp/eal/eal_lcore.c
+++ b/lib/librte_eal/bsdapp/eal/eal_lcore.c
@@ -77,7 +77,6 @@ rte_eal_cpu_init(void)
 
 		lcore_config[lcore_id].detected = (lcore_id < ncpus);
 		if (lcore_config[lcore_id].detected == 0) {
-			RTE_LOG(DEBUG, EAL, "Skip lcore %u (not detected)\n", lcore_id);
 			config->lcore_role[lcore_id] = ROLE_OFF;
 			continue;
 		}
diff --git a/lib/librte_eal/linuxapp/eal/eal_lcore.c b/lib/librte_eal/linuxapp/eal/eal_lcore.c
index d310d85..03f4ba3 100644
--- a/lib/librte_eal/linuxapp/eal/eal_lcore.c
+++ b/lib/librte_eal/linuxapp/eal/eal_lcore.c
@@ -158,7 +158,6 @@ rte_eal_cpu_init(void)
 	for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
 		lcore_config[lcore_id].detected = cpu_detected(lcore_id);
 		if (lcore_config[lcore_id].detected == 0) {
-			RTE_LOG(DEBUG, EAL, "Skip lcore %u (not detected)\n", lcore_id);
 			config->lcore_role[lcore_id] = ROLE_OFF;
 			continue;
 		}
-- 
1.7.10.4

Re: [dpdk-dev] [PATCH RFC] eal: remove useless output

[Thomas Monjalon]

2014-04-30 16:14, David Marchand:
> From: Didier Pallard <didier.pallard@6wind.com>
> 
> Increasing maximum number of lcores gives a huge place to undetected
> lcores in output traces. Moreover, this output does not give any
> interesting information, since list of undetected lcores can be deduced
> from list of detected ones.
> So remove output related to undetected cores.
> 
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied for version 1.7.0.

-- 
Thomas