From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 632EBA054F; Tue, 18 Feb 2020 16:46:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A46B31C06A; Tue, 18 Feb 2020 16:46:05 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id BAA061BFF5 for ; Tue, 18 Feb 2020 16:46:04 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5310722138; Tue, 18 Feb 2020 10:46:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 18 Feb 2020 10:46:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=9PlYKsLN82WsxfEDkocxe76PMOv5qhuo+ES/1EKOkdY=; b=QHNACfqbOxC9 k7T5Oaj9SAXfsMVp7DSmOhE7+v9bShZZbXITu7PqjbPL/fHkDNXXRhUr1tNtRz6n FhFFshFxAntKYIcUUP7UjE+O7kZqfDNvDnnTGIVeHlbWRE94bVRWZGIocOp5NZSO s3PSJML+GToDxSd/VlLaj2XvymdhlB0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9PlYKsLN82WsxfEDkocxe76PMOv5qhuo+ES/1EKOk dY=; b=VBZloLS/4+ZxtLDdZqb9vFS2Q+xCVDYT7oeCk1okCGE1cEdkRiRKpjCsz KJ0f7LjzmWQTBAm+PgDtyLzkfSBXcpT1VCk18q6JvSzuIgENyOXgSqy8lueqjoF7 mJI3hQkSIRidEqu4kXXQBQSTSAN/AvmCPsifqmoYJ/fPmNWBPGoJPguZjQYouvOU BKmccPN5rIN8Cnkv0nsU5NomK+TKZ02PGqWHHtqGnEecivk0UPc9AFdx4tix+nl0 tZG+SBlZC5xIS94RKDHH2UsgW3J/pUZcfV+/vsxginRqfXe+3VQbB5ysAF06+kbV MhL83D4+tpEW9laM3BeSgHq6Pd05g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeekgdektdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepthhrrghvihhsqdgtihdrtghomhdpshhouhhrtggvfigrrhgvrdhorhhgpdhl rghunhgthhhprggurdhnvghtpdhshhgsrdgtihdpkhgvrhhnvghlrdhorhhgnecukfhppe ejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 159E2328005E; Tue, 18 Feb 2020 10:46:02 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, aconole@redhat.com, christian.ehrhardt@canonical.com, dodji@redhat.com, kevin.laatz@intel.com, Michael Santana Date: Tue, 18 Feb 2020 16:46:01 +0100 Message-ID: <4348229.k3LOHGUjKi@xps> In-Reply-To: <20200218142916.657-1-david.marchand@redhat.com> References: <20200217135929.30987-1-david.marchand@redhat.com> <20200218142916.657-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ci: build and use libabigail 1.6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/02/2020 15:29, David Marchand: > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > breakage [1]. > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > in launchpad [3]. > > But for now, build and use the last version 1.6 so that the ABI checks > can be kept. > > 1: https://travis-ci.com/DPDK/dpdk/jobs/287872118#L2242 > 2: https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commitdiff;h=215b7eb4fe8b > 3: https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607 > > Signed-off-by: David Marchand Acked-by: Thomas Monjalon I suggest few improvements below: > --- a/.ci/linux-build.sh > +++ b/.ci/linux-build.sh > if [ "$ABI_CHECKS" = "1" ]; then What do you think about moving the libabigail install in a function? We could justify this with a comment about installing the latest version. > + LIBABIGAIL_REPO=${LIBABIGAIL_REPO:-https://sourceware.org/git/libabigail.git} > + LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6} > + > + if [ "$(cat libabigail/VERSION 2>/dev/null)" != "$LIBABIGAIL_VERSION" ]; then > + rm -rf libabigail > + # if we change libabigail, invalidate existing abi cache > + rm -rf reference > + fi > + > + if [ ! -d libabigail ]; then > + git clone --single-branch -b $LIBABIGAIL_VERSION $LIBABIGAIL_REPO libabigail/src Why not using the tarball? http://mirrors.kernel.org/sourceware/libabigail/libabigail-1.6.tar.gz > + cd libabigail/src && autoreconf -i && cd - > + instdir=$(pwd)/libabigail > + mkdir libabigail/src/build > + cd libabigail/src/build && ../configure --prefix=$instdir && cd - > + make -C libabigail/src/build all install > + > + rm -rf libabigail/src > + echo $LIBABIGAIL_VERSION > libabigail/VERSION > + fi > + > + export PATH=$(pwd)/libabigail/bin:$PATH