Re: [dpdk-dev] [PATCH 1/6] cryptodev: Initial DPDK Crypto APIs and device framework release

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi Declan,

2015-10-03 00:01, Declan Doherty:
> Co-authored-by: Des O Dea <des.j.o.dea@intel.com>
> Co-authored-by: John Griffin <john.griffin@intel.com>
> Co-authored-by: Fiona Trahe <fiona.trahe@intel.com>

Common practice is to use Signed-off-by below for co-authors.

> This patch contains the initial proposed APIs and device framework for
> integrating crypto packet processing into DPDK.
> 
> features include:
>  - Crypto device configuration / management APIs
>  - Definitions of supported cipher algorithms and operations.
>  - Definitions of supported hash/authentication algorithms and
>    operations.
>  - Crypto session management APIs
>  - Crypto operation data structures and APIs allocation of crypto
>    operation structure used to specify the crypto operations to
>    be performed  on a particular mbuf.
>  - Extension of mbuf to contain crypto operation data pointer and
>    extra flags.
>  - Burst enqueue / dequeue APIs for processing of crypto operations.

It would be easier to review if features were split in separate patches.
You don't need to have a fine grain but maybe 1 patch for basic management
then 1 for the session management, 1 for the algos and another 1 for the stats.

Other comment: you've added some API which are not implemented (hotplug, restore).
Why not declare them later when they will be implemented?

The QuickAssist doc is not needed if the code is not submitted.

Volunteer for a sub-tree?
Thanks.