From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id F082A5B1E
 for <dev@dpdk.org>; Fri,  2 Nov 2018 10:39:30 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id 77EB6951;
 Fri,  2 Nov 2018 05:39:28 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Fri, 02 Nov 2018 05:39:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=M489t91iITPgjoT7D1JFPU9MWqEsQglGLDtSPJKkWtQ=; b=UAMZomcXqTvE
 jZD3/6m7C5tr4OXC68dO2D7wN1DCIudCQGIuXZ2VN3VzQ8XLK3X+95c8s5AEbgva
 s+dZ12pu3rgZme/Hl/Ft2y5N0R7wQr31IodKj/8k5t/+uSRlvSiyGbMHToVelbMq
 jS3pbEwZsuD9DnXcbdExv0mhcshUSVY=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=M489t91iITPgjoT7D1JFPU9MWqEsQglGLDtSPJKkW
 tQ=; b=abqhEUtQhYniQ0/zPMdzskAal3vkokhbgBrphUaA3K+S0wkBnZFYZZ4HB
 AmwnVTvbS8K8AMuxoEFC4erOg3yOvRURH6w7Zv6IupUL7DLPVvcbp0MoNuhTHqg/
 jAii46cW+NOe5rES4e6LoXt0GNg3/f4vYkergflrtf2HW7ce+E/aPbvolyIdqUL6
 S7c4j7SfEKXBTRbX128X/Kz5pVD/5f2qzZRKg9VxQTYwZelOoD+G+ja4W5k8b+qR
 QPtcApnnfIcfGq6sTHsp7AtYVpbpR62h/+38PA03AoTXhyamdzKj5xQrRT5wOZju
 qZ0nqf+fxI11RMqSVHh36BSA88FNg==
X-ME-Sender: <xms:TxvcWya4UmtQGHyC1COb72rrpD5g90mOR27oJxbpBNXEFpF9qS2iuw>
X-ME-Proxy: <xmx:TxvcW2SbPyM55uHYEpxiMiuCubuBUH0ZSJ2r_8Tw90huC8tTxT6x-A>
 <xmx:TxvcW1TkUVsR4Igao7rPGqICvoaZnX9BNAzR3b1MAyl34dLMa3mVYw>
 <xmx:TxvcW4HcJP0eLPfQRK2LjUZJj-BxOvnEQL8YY-xxPBP2ky9X9GODlw>
 <xmx:TxvcW5kTN3rhXE7qPsOt9uQPGBZopHZOPA__eGgmj1-GR0VFRc7cbg>
 <xmx:TxvcW4Ae-EHkCQZMgNJikIWZDM7YnrqNSjPcs1AE1p9GrFj7OI1GMA>
 <xmx:UBvcWy4K1lQxFmuPnXkLiyZ37ErL3i6uncHPME33drwpmrNoB2mSBg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 93BCB103E5;
 Fri,  2 Nov 2018 05:39:26 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
Date: Fri, 02 Nov 2018 10:39:24 +0100
Message-ID: <4348558.Aku75RrXBD@xps>
In-Reply-To: <1541138405-6608-1-git-send-email-arnon@qwilt.com>
References: <1541138405-6608-1-git-send-email-arnon@qwilt.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] devtools: add explicit warning messages
	for forbidden tokens
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Nov 2018 09:39:31 -0000

02/11/2018 07:00, Arnon Warshavsky:
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> @@ -49,13 +49,16 @@ check_forbidden_additions() { # <patch>
>  	awk -v FOLDERS="lib drivers" \
>  		-v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
>  		-v RET_ON_FAIL=1 \
> +		-v MESSAGE='Using rte_panic/rte_exit' \
>  		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
>  		"$1"
>  	# svg figures must be included with wildcard extension
>  	# because of png conversion for pdf docs
> +	message="Using explicit .svg extension in figures instead of .*"
>  	awk -v FOLDERS='doc' \
>  		-v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
>  		-v RET_ON_FAIL=1 \
> +		-v MESSAGE="$message" \
>  		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
>  		"$1"
>  }

Why using a variable for message in the second check?