From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 967E3A0032; Wed, 11 May 2022 23:17:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C09540DDD; Wed, 11 May 2022 23:17:12 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id B2551406B4 for ; Wed, 11 May 2022 23:17:11 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id D02AD320090D; Wed, 11 May 2022 17:17:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 11 May 2022 17:17:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1652303828; x= 1652390228; bh=XPHZeKSBqngm7vIAuS3It6jf2VBucbhW7Oew9kOhsFk=; b=N 7xjnmKKo0UjrZNGruEPrCtTLWg+bKV4qhhcmDR2P9xw/jrvvceun/IydbhBcb04c F9PNC/uvdvcE5wigTFm29Ev3E6rbb7yiXl6YCMS2cIQMs6l2ELySh5j0fIVCdW6r DadR+dkaHwpmhUR/GE1QaGcegBRFJuLH2g/ejrMdLzwSRF4htA1tQoF3/cDd+7wC bF/+xLaLRFiSsAgzyvV1IfJgVNHV99ImQSjX27wFYKQ+/ZsB8oHu2/LDsBe9OGfl AIvJoCdy0yCL+Zt7GgixPvjs+bOIjhbuWKEVQqLxAG7FHU6wjaK8/Ng7enNOouqq yZa05BfV9cE3ycYw3Tv5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652303828; x=1652390228; bh=XPHZeKSBqngm7 vIAuS3It6jf2VBucbhW7Oew9kOhsFk=; b=J9wMhz3NaRtKHPZltYP5IhGnPwUh0 RWR43fjXpXM7OJU+cZGNGJ6nbM8Mh5IPsF7kXErzM30wj6VHHAtWorO+CssxgXwK cxth4QedoR6ZDhAQHI2cXvYfmivh/HH/6G+8du44oVFZS5wkLyetNNVDxg65uEet MFQBeIVDGiMaMrhKRbb48fTcQgHF1i2kec2qCNq9eG0LxzJFvCLqODSXx18gp0wl Ovk8c5CxjxM/tGDTDKyntR3uybBLO7Na/Ou3fWGJeIfSDXdfkTtqNl6ICJSkBxet mCkpsN+egb4BG+SKNgFvdN35X6dMEU2v+loxmd9teGtbBVOmyJFZAKg4w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgeehgdduheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 May 2022 17:17:07 -0400 (EDT) From: Thomas Monjalon To: "Wu, Wenjun1" , "Zhang, Qi Z" Cc: "dev@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: Re: [PATCH v1] net/iavf: fix resource leak issue Date: Wed, 11 May 2022 23:17:04 +0200 Message-ID: <4349564.Wku2Vz74k6@thomas> In-Reply-To: References: <20220510005425.1648591-1-wenjun1.wu@intel.com> <2551212.tIAgqjz4sF@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/05/2022 17:31, Zhang, Qi Z: > From: Thomas Monjalon > > 11/05/2022 13:46, Zhang, Qi Z: > > > From: Wu, Wenjun1 > > > > > > > > This patch fixes resource leak issue reported by coverity. > > > > > > > > Coverity issue: 378017 > > > > Fixes: b14e8a57b9fe ("net/iavf: support quanta size configuration") > > > > > > > > Signed-off-by: Wenjun Wu > > > > > > Acked-by: Qi Zhang > > > > > > Applied to dpdk-next-net-intel. > > > > In the title, the word "issue" is useless. > > It would be more interesting to precise where is the leak. > > > > Added below into commit log in dpdk-next-net-intel. > > kvlist should be freed before return an error due to invalid quanta size. It does not explain what is the scenario. What is the impacted feature?