From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 63D3F5583 for ; Fri, 24 Mar 2017 17:38:51 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 24 Mar 2017 09:38:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,215,1486454400"; d="scan'208";a="1146561937" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga002.fm.intel.com with ESMTP; 24 Mar 2017 09:38:05 -0700 To: Olivier Matz References: <1489754838-1455-1-git-send-email-hemant.agrawal@nxp.com> <1489754838-1455-2-git-send-email-hemant.agrawal@nxp.com> <7d898278-9331-0c72-cabd-9318c6d65f1e@intel.com> <5af16ee7-fdcc-5b03-0897-f0657e8f8e7f@intel.com> <20170324173146.477a5157@platinum> Cc: Hemant Agrawal , dev@dpdk.org, thomas.monjalon@6wind.com, shreyansh.jain@nxp.com From: Ferruh Yigit Message-ID: <434e5f68-430b-1676-fed8-3527f25f3081@intel.com> Date: Fri, 24 Mar 2017 16:38:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170324173146.477a5157@platinum> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1] mempool/dpaa2: add DPAA2 hardware offloaded mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 16:38:51 -0000 On 3/24/2017 4:31 PM, Olivier Matz wrote: > Hi Ferruh, > > On Fri, 24 Mar 2017 15:59:50 +0000, Ferruh Yigit wrote: >> On 3/24/2017 2:57 PM, Ferruh Yigit wrote: >>> On 3/17/2017 12:47 PM, Hemant Agrawal wrote: >>>> DPAA2 Hardware Mempool handlers allow enqueue/dequeue from NXP's >>>> QBMAN hardware block. >>>> CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS is set to 'dpaa2', if the pool >>>> is enabled. >>>> >>>> This memory pool currently supports packet mbuf type blocks only. >>>> >>>> Signed-off-by: Hemant Agrawal >>> >>> Applied to dpdk-next-net/master, thanks. >> >> Hi Olivier, >> >> I get this to next-net, since dpaa2 net driver depends this one. >> >> But were you planning any review on the code? Or is it good to go as it is? > > Yes, but I'm afraid I won't be able to do it today. OK, when you done your review, we can act according its result. I just want to remind the dependency chain, dpaa2 net depends this patch, and dpaa2 crypto depends net one. An early integration from next-net required so that next-crypto can finish its work before integration deadline. Thanks, ferruh > > From high level, I'm still a little puzzled by the amount of references > to mbuf in a mempool handler code, which should theorically handle any > kind of objects. > > Is it planned to support other kind of objects? > Does this driver passes the mempool autotest? > Can the user be aware of these limitations? > > > Thanks, > Olivier >