From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Tao, Zhe" <zhe.tao@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] i40e:Fix the Descriptor Done check mechanism for i40e
Date: Fri, 10 Jul 2015 18:56:33 +0200 [thread overview]
Message-ID: <4354156.5trOTC7DZb@xps13> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F8C6473D@SHSMSX104.ccr.corp.intel.com>
> > If a descriptor the device drive is handling is the context descriptor, its type
> > value will be 0x1.
> > When using the not operator ! to do the conditional check, if the expression
> > value is zero, the device driver will consider the transaction for this descriptor
> > has been completed, even its DD field is still 0x1 which means NIC has not
> > finished the operation on this descriptor.
> > Use the 0xF to check the DD status to avoid the above issue happens.
> >
> > Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Applied, thanks
next prev parent reply other threads:[~2015-07-10 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 17:11 [dpdk-dev] [PATCH] i40e: Fix the clean up function for i40e, the DD bits are multiplex with descriptor type field. so cannot use "not zero" as the rule for the completion of Tx descriptor Zhe Tao
2015-07-08 9:29 ` [dpdk-dev] [PATCH v2] i40e:Fix the Description Done check mechanism for i40e Zhe Tao
2015-07-09 2:58 ` [dpdk-dev] [PATCH v3] i40e:Fix the Descriptor " Zhe Tao
2015-07-09 3:31 ` Wu, Jingjing
2015-07-10 16:56 ` Thomas Monjalon [this message]
2015-07-16 19:20 ` [dpdk-dev] [PATCH] i40e: Fix the clean up function for i40e, the DD bits are multiplex with descriptor type field. so cannot use "not zero" as the rule for the completion of Tx descriptor Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4354156.5trOTC7DZb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=zhe.tao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).