From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 0D1D7C3A0 for ; Fri, 10 Jul 2015 18:57:42 +0200 (CEST) Received: by wiwl6 with SMTP id l6so51828540wiw.0 for ; Fri, 10 Jul 2015 09:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=o98KuJo7ksUjNmAsdhYzXP4A+5KdLC4OWwiJ4sAtaJ8=; b=DXI0O1ZdN6w/T8juHcRfe64AMUnuZF1iI3BlYOb9SGROgS4wJjO9CwuM+Q0BhmgHvl tdEIyXInSaAlXDGG6eLSjHFCUPe2fM26ZPml67onCEJ6Y7Om/x/O5BOTQNdsYSyrlQ8/ CN3iaFWVd/dGq2bjJPs9bZG1n5O5oYyNSyRqmwMzCaO0evNPRCrm22cJXBXtXmdyMkbu x3jfSqCd1lLYfDSqtEkKXZ0KdVG7470F0zYFRT1MJU3hCHJAa7DnQqQzGNLWnFpPFOz9 raX0Pn51jJF6VBWZMYp5IaQ+hRuHofdpj6d47dNrF3sqcBWTiI/F9Sq7YHnTIZ9JEjI4 yBcw== X-Gm-Message-State: ALoCoQnZvFVBKLe16WqkEubeuk2ua8bL+C6hUW/9KPiN+iZbaea7lLC4EMkwt4sloJhmbMT0T26T X-Received: by 10.194.112.3 with SMTP id im3mr43370956wjb.54.1436547461875; Fri, 10 Jul 2015 09:57:41 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id j7sm14425653wjz.11.2015.07.10.09.57.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Jul 2015 09:57:41 -0700 (PDT) From: Thomas Monjalon To: "Tao, Zhe" Date: Fri, 10 Jul 2015 18:56:33 +0200 Message-ID: <4354156.5trOTC7DZb@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8C6473D@SHSMSX104.ccr.corp.intel.com> References: <1436347759-31915-1-git-send-email-zhe.tao@intel.com> <1436410688-663-1-git-send-email-zhe.tao@intel.com> <9BB6961774997848B5B42BEC655768F8C6473D@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] i40e:Fix the Descriptor Done check mechanism for i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 16:57:42 -0000 > > If a descriptor the device drive is handling is the context descriptor, its type > > value will be 0x1. > > When using the not operator ! to do the conditional check, if the expression > > value is zero, the device driver will consider the transaction for this descriptor > > has been completed, even its DD field is still 0x1 which means NIC has not > > finished the operation on this descriptor. > > Use the 0xF to check the DD status to avoid the above issue happens. > > > > Signed-off-by: Zhe Tao > Acked-by: Jingjing Wu Applied, thanks